From: Jianqun <xjq@rock-chips.com>
To: Mark Brown <broonie@kernel.org>, Jianqun <jay.xu@rock-chips.com>
Cc: heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, huangtao@rock-chips.com,
cf@rock-chips.com
Subject: Re: [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller
Date: Sun, 14 Sep 2014 10:20:11 +0800 [thread overview]
Message-ID: <5414FB5B.8090907@rock-chips.com> (raw)
In-Reply-To: <20140913163613.GI7960@sirena.org.uk>
在 09/14/2014 12:36 AM, Mark Brown 写道:
> On Sat, Sep 13, 2014 at 08:42:12AM +0800, Jianqun wrote:
>> Reference rockchip I2S controller TRM, modify some registers' property
>> I2S_FIFOLR: read / write, but not volatile, not precious
>> I2S_INTSR: read / write
>> I2S_CLR: volatile, register value will be cleared by read
>
> Applied, again this is a bug fix (volatile and precious being wrong seem
> like bugs) so should have been earlier in the series.
>
ok, I'll re-order the patches
WARNING: multiple messages have this Message-ID (diff)
From: xjq@rock-chips.com (Jianqun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller
Date: Sun, 14 Sep 2014 10:20:11 +0800 [thread overview]
Message-ID: <5414FB5B.8090907@rock-chips.com> (raw)
In-Reply-To: <20140913163613.GI7960@sirena.org.uk>
? 09/14/2014 12:36 AM, Mark Brown ??:
> On Sat, Sep 13, 2014 at 08:42:12AM +0800, Jianqun wrote:
>> Reference rockchip I2S controller TRM, modify some registers' property
>> I2S_FIFOLR: read / write, but not volatile, not precious
>> I2S_INTSR: read / write
>> I2S_CLR: volatile, register value will be cleared by read
>
> Applied, again this is a bug fix (volatile and precious being wrong seem
> like bugs) so should have been earlier in the series.
>
ok, I'll re-order the patches
next prev parent reply other threads:[~2014-09-14 2:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 0:38 [PATCH 0/5] ASoC: rockchip-i2s: patches for rockchip i2s driver Jianqun
2014-09-13 0:38 ` Jianqun
2014-09-13 0:40 ` [PATCH 1/5] ASoC: rockchip-i2s: fix rockchip i2s defination more reasonable Jianqun
2014-09-13 0:40 ` Jianqun
2014-09-13 16:38 ` Mark Brown
2014-09-13 16:38 ` Mark Brown
2014-09-13 0:41 ` [PATCH 2/5] ASoC: rockchip-i2s: fix master mode set bit error Jianqun
2014-09-13 0:41 ` Jianqun
2014-09-13 16:35 ` Mark Brown
2014-09-13 16:35 ` Mark Brown
2014-09-13 16:35 ` Mark Brown
2014-09-14 2:06 ` Jianqun
2014-09-14 2:06 ` Jianqun
2014-09-14 2:06 ` Jianqun
2014-09-13 0:41 ` [PATCH 3/5] ASoC: rockchip-i2s: add dma data to snd_soc_dai Jianqun
2014-09-13 0:41 ` Jianqun
2014-09-13 16:38 ` Mark Brown
2014-09-13 16:38 ` Mark Brown
2014-09-13 0:42 ` [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller Jianqun
2014-09-13 0:42 ` Jianqun
2014-09-13 16:36 ` Mark Brown
2014-09-13 16:36 ` Mark Brown
2014-09-14 2:20 ` Jianqun [this message]
2014-09-14 2:20 ` Jianqun
2014-09-13 20:57 ` Sergei Shtylyov
2014-09-13 20:57 ` Sergei Shtylyov
2014-09-14 2:29 ` Jianqun
2014-09-14 2:29 ` Jianqun
2014-09-14 18:53 ` Sergei Shtylyov
2014-09-14 18:53 ` Sergei Shtylyov
2014-09-13 0:43 ` [PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S controller Jianqun
2014-09-13 0:43 ` Jianqun
2014-09-13 16:36 ` Mark Brown
2014-09-13 16:36 ` Mark Brown
2014-09-14 2:24 ` Jianqun
2014-09-14 2:24 ` Jianqun
2014-09-13 16:37 ` Mark Brown
2014-09-13 16:37 ` Mark Brown
2014-09-14 2:27 ` Jianqun
2014-09-14 2:27 ` Jianqun
2014-09-15 16:54 ` Mark Brown
2014-09-15 16:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5414FB5B.8090907@rock-chips.com \
--to=xjq@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.