From: Hartmut Knaack <knaack.h@gmx.de>
To: Jonathan Cameron <jic23@kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
IIO <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
DEVICE TREE <devicetree@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>
Cc: Carlo Caione <carlo@caione.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Aaron Lu <aaron.lu@intel.com>, Alan Cox <alan@linux.intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Fugang Duan <B38611@freescale.com>, Arnd Bergmann <arnd@arndb.de>,
Zubair Lutfullah <zubair.lutfullah@gmail.com>,
Sebastian Reichel <sre@debian.org>,
Johannes Thumshirn <johannes.thumshirn@men.de>,
Philippe Reynes <tremyfr@yahoo.fr>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>,
Doug Anderson <dianders@chromium.org>,
Ramakrishna Pallala <ramakrishna.pallala@intel.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH v3 5/5] iio: add documentation for current attribute
Date: Sun, 14 Sep 2014 15:13:48 +0200 [thread overview]
Message-ID: <5415948C.6080509@gmx.de> (raw)
In-Reply-To: <5414A138.9080602@kernel.org>
Jonathan Cameron schrieb, Am 13.09.2014 21:55:
> On 12/09/14 00:15, Jacob Pan wrote:
>> Add documentation for input current raw reading and scale.
>>
>> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> The content is fine, but please look at how the other types are handled.
> The raw attribute is described along with the units etc in it's own
> section, but the _scale attribute just gets lumped in with the equivalent
> for all the other channel types.
>
> Thanks,
>
> Jonathan
>> ---
>> Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index d760b02..3c76bd8 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1028,3 +1028,11 @@ Contact: linux-iio@vger.kernel.org
>> Description:
>> Raw value of rotation from true/magnetic north measured with
>> or without compensation from tilt sensors.
>> +
>> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_raw
>> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_scale
>> +KernelVersion: 3.18
>> +Contact: linux-iio@vger.kernel.org
>> +Description:
>> + Raw current measurement from channel X. Units after application of
>> + scale and offset are milliamps.
Where is the offset?
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
IIO <linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
DEVICE TREE <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
Srinivas Pandruvada
<srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Aaron Lu <aaron.lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Fugang Duan <B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Zubair Lutfullah
<zubair.lutfullah-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sebastian Reichel <sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>,
Johannes Thumshirn
<johannes.thumshirn-csrFAY9JiS4@public.gmane.org>,
Philippe Reynes <tremyfr-Qt13gs6zZMY@public.gmane.org>,
Angelo Compagnucci
<angelo.compagnucci-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Ramakrishna Pallala
<ramakrishna.pallala-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
Maxime Ripard <maxime.ripard@free-elec>
Subject: Re: [PATCH v3 5/5] iio: add documentation for current attribute
Date: Sun, 14 Sep 2014 15:13:48 +0200 [thread overview]
Message-ID: <5415948C.6080509@gmx.de> (raw)
In-Reply-To: <5414A138.9080602-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Jonathan Cameron schrieb, Am 13.09.2014 21:55:
> On 12/09/14 00:15, Jacob Pan wrote:
>> Add documentation for input current raw reading and scale.
>>
>> Signed-off-by: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> The content is fine, but please look at how the other types are handled.
> The raw attribute is described along with the units etc in it's own
> section, but the _scale attribute just gets lumped in with the equivalent
> for all the other channel types.
>
> Thanks,
>
> Jonathan
>> ---
>> Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index d760b02..3c76bd8 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1028,3 +1028,11 @@ Contact: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Description:
>> Raw value of rotation from true/magnetic north measured with
>> or without compensation from tilt sensors.
>> +
>> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_raw
>> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_scale
>> +KernelVersion: 3.18
>> +Contact: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> +Description:
>> + Raw current measurement from channel X. Units after application of
>> + scale and offset are milliamps.
Where is the offset?
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-09-14 13:13 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 23:15 [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Jacob Pan
2014-09-11 23:15 ` Jacob Pan
2014-09-11 23:15 ` [PATCH v3 1/5] mfd/axp20x: rename files to support more devices Jacob Pan
2014-09-11 23:15 ` Jacob Pan
2014-09-13 20:00 ` Jonathan Cameron
2014-09-13 20:00 ` Jonathan Cameron
2014-09-15 16:28 ` Jacob Pan
2014-09-15 16:28 ` Jacob Pan
2014-09-15 22:18 ` Lee Jones
2014-09-15 22:18 ` Lee Jones
2014-09-11 23:15 ` [PATCH v3 2/5] mfd/axp2xx: extend axp20x to support axp288 pmic Jacob Pan
2014-09-11 23:15 ` Jacob Pan
2014-09-15 22:22 ` Lee Jones
2014-09-15 22:22 ` Lee Jones
2014-09-15 22:32 ` Jacob Pan
2014-09-15 22:32 ` Jacob Pan
2014-09-15 23:34 ` Lee Jones
2014-09-15 23:34 ` Lee Jones
2014-09-11 23:15 ` [PATCH v3 3/5] regulator/axp20x: use axp2xx consolidated header Jacob Pan
2014-09-11 23:15 ` Jacob Pan
2014-09-13 20:01 ` Jonathan Cameron
2014-09-13 20:01 ` Jonathan Cameron
2014-09-11 23:15 ` [PATCH v3 4/5] iio/adc/axp288: add support for axp288 gpadc Jacob Pan
2014-09-11 23:15 ` Jacob Pan
2014-09-12 12:44 ` Peter Meerwald
2014-09-13 19:52 ` Jonathan Cameron
2014-09-14 13:09 ` Hartmut Knaack
2014-09-16 18:21 ` Jacob Pan
2014-09-16 22:24 ` Hartmut Knaack
2014-09-16 10:00 ` Jacob Pan
2014-09-11 23:15 ` [PATCH v3 5/5] iio: add documentation for current attribute Jacob Pan
2014-09-11 23:15 ` Jacob Pan
2014-09-13 19:55 ` Jonathan Cameron
2014-09-13 19:55 ` Jonathan Cameron
2014-09-14 13:13 ` Hartmut Knaack [this message]
2014-09-14 13:13 ` Hartmut Knaack
2014-09-15 20:29 ` Jacob Pan
2014-09-15 20:29 ` Jacob Pan
2014-09-12 15:18 ` [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Maxime Ripard
2014-09-12 15:18 ` Maxime Ripard
2014-09-12 19:36 ` Jacob Pan
2014-09-12 19:36 ` Jacob Pan
2014-09-15 9:02 ` Maxime Ripard
2014-09-15 9:02 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5415948C.6080509@gmx.de \
--to=knaack.h@gmx.de \
--cc=B38611@freescale.com \
--cc=aaron.lu@intel.com \
--cc=alan@linux.intel.com \
--cc=angelo.compagnucci@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jic23@kernel.org \
--cc=johannes.thumshirn@men.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=pmeerw@pmeerw.net \
--cc=ramakrishna.pallala@intel.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sre@debian.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tremyfr@yahoo.fr \
--cc=zubair.lutfullah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.