From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system
Date: Mon, 15 Sep 2014 16:03:09 +0200 [thread overview]
Message-ID: <5416F19D.4030105@collabora.co.uk> (raw)
In-Reply-To: <20140912150537.56419981804c68f9108a22b6@linux-foundation.org>
Hello Andrew,
Thanks a lot for taking a look to these patches!
On 09/13/2014 12:05 AM, Andrew Morton wrote:
> On Fri, 12 Sep 2014 10:17:39 +0200 Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote:
>
>> From: Doug Anderson <dianders@chromium.org>
>>
>> The max77686 includes an RTC that keeps power during suspend. It's
>> convenient to be able to use it as a wakeup source.
>>
>> NOTE: due to wakeup ordering problems this patch alone doesn't work so
>> well on exynos5250-snow. You also need something that brings the i2c
>> bus up before the max77686 wakeup runs.
>
> I removed this paragraph.
>
Great.
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> And I rewrote this to Signed-off-by:, as you were on the patch delivery
> path. Documentation/SubmittingPatches section 12 has the gory details.
>
Yes, originally Doug posted this patch separately but was never picked so I
included on my series but forgot to add my s-o-b and also to remove the note
paragraph.
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system
Date: Mon, 15 Sep 2014 16:03:09 +0200 [thread overview]
Message-ID: <5416F19D.4030105@collabora.co.uk> (raw)
In-Reply-To: <20140912150537.56419981804c68f9108a22b6@linux-foundation.org>
Hello Andrew,
Thanks a lot for taking a look to these patches!
On 09/13/2014 12:05 AM, Andrew Morton wrote:
> On Fri, 12 Sep 2014 10:17:39 +0200 Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote:
>
>> From: Doug Anderson <dianders@chromium.org>
>>
>> The max77686 includes an RTC that keeps power during suspend. It's
>> convenient to be able to use it as a wakeup source.
>>
>> NOTE: due to wakeup ordering problems this patch alone doesn't work so
>> well on exynos5250-snow. You also need something that brings the i2c
>> bus up before the max77686 wakeup runs.
>
> I removed this paragraph.
>
Great.
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> And I rewrote this to Signed-off-by:, as you were on the patch delivery
> path. Documentation/SubmittingPatches section 12 has the gory details.
>
Yes, originally Doug posted this patch separately but was never picked so I
included on my series but forgot to add my s-o-b and also to remove the note
paragraph.
Best regards,
Javier
next prev parent reply other threads:[~2014-09-15 14:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 8:17 [PATCH RESEND v9 0/5] Add Maxim 77802 RTC support Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 15:12 ` Doug Anderson
2014-09-12 15:12 ` Doug Anderson
2014-09-12 15:54 ` Javier Martinez Canillas
2014-09-12 15:54 ` Javier Martinez Canillas
2014-09-12 16:03 ` Doug Anderson
2014-09-12 16:03 ` Doug Anderson
2014-09-12 22:05 ` Andrew Morton
2014-09-12 22:05 ` Andrew Morton
2014-09-15 14:03 ` Javier Martinez Canillas [this message]
2014-09-15 14:03 ` Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 2/5] rtc: max77686: Remove dead code for SMPL and WTSR Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 3/5] rtc: max77686: Fail to probe if no RTC regmap irqchip is set Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 4/5] rtc: max77686: Remove unneded info log Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 8:17 ` [PATCH RESEND v9 5/5] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 8:17 ` Javier Martinez Canillas
2014-09-12 22:13 ` Andrew Morton
2014-09-12 22:13 ` Andrew Morton
2014-09-15 14:07 ` Javier Martinez Canillas
2014-09-15 14:07 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416F19D.4030105@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.