From: Nishanth Menon <nm@ti.com>
To: Jim Davis <jim.epost@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: randconfig build error with next-20140915, in drivers/input/misc/palmas-pwrbutton.c
Date: Mon, 15 Sep 2014 12:30:22 -0500 [thread overview]
Message-ID: <5417222E.30201@ti.com> (raw)
In-Reply-To: <CA+r1ZhjG4oSVSWnO4SXomJArxJdnUpdSHeGxV41Z4Hw1B8eEaQ@mail.gmail.com>
On 09/15/2014 09:40 AM, Jim Davis wrote:
> Building with the attached random configuration file,
>
> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol
> 'platform_driver_unregister'
> make[1]: *** [__modpost] Error 1
>
For some reason, I was unable to reproduce this in my build with ARM
OMAP5 configuration... but with the x86 configuration, I was.
https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=adff5962fdd2f29bac943bc014ebd529444b2153
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n101
I used MODULE_LICENSE("GPL V2")
Looks like a typo crept in. And s/V/v seems to squelch the warning(at
least in the x86 build) for the randconfig. I will post a patch
accordingly. Thanks for catching the same.
diff --git a/drivers/input/misc/palmas-pwrbutton.c
b/drivers/input/misc/palmas-pwrbutton.c
index 3f90211..06ffe04 100644
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
MODULE_ALIAS("platform:palmas-pwrbutton");
MODULE_DESCRIPTION("Palmas Power Button");
-MODULE_LICENSE("GPL V2");
+MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Texas Instruments Inc.");
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Jim Davis <jim.epost@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
<linux-input@vger.kernel.org>
Subject: Re: randconfig build error with next-20140915, in drivers/input/misc/palmas-pwrbutton.c
Date: Mon, 15 Sep 2014 12:30:22 -0500 [thread overview]
Message-ID: <5417222E.30201@ti.com> (raw)
In-Reply-To: <CA+r1ZhjG4oSVSWnO4SXomJArxJdnUpdSHeGxV41Z4Hw1B8eEaQ@mail.gmail.com>
On 09/15/2014 09:40 AM, Jim Davis wrote:
> Building with the attached random configuration file,
>
> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol
> 'platform_driver_unregister'
> make[1]: *** [__modpost] Error 1
>
For some reason, I was unable to reproduce this in my build with ARM
OMAP5 configuration... but with the x86 configuration, I was.
https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=adff5962fdd2f29bac943bc014ebd529444b2153
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n101
I used MODULE_LICENSE("GPL V2")
Looks like a typo crept in. And s/V/v seems to squelch the warning(at
least in the x86 build) for the randconfig. I will post a patch
accordingly. Thanks for catching the same.
diff --git a/drivers/input/misc/palmas-pwrbutton.c
b/drivers/input/misc/palmas-pwrbutton.c
index 3f90211..06ffe04 100644
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
MODULE_ALIAS("platform:palmas-pwrbutton");
MODULE_DESCRIPTION("Palmas Power Button");
-MODULE_LICENSE("GPL V2");
+MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Texas Instruments Inc.");
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-09-15 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 14:40 randconfig build error with next-20140915, in drivers/input/misc/palmas-pwrbutton.c Jim Davis
2014-09-15 17:30 ` Nishanth Menon [this message]
2014-09-15 17:30 ` Nishanth Menon
2014-09-15 19:15 ` Nishanth Menon
2014-09-15 19:15 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5417222E.30201@ti.com \
--to=nm@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jim.epost@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.