From: Nishanth Menon <nm@ti.com>
To: Jim Davis <jim.epost@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License
Date: Mon, 15 Sep 2014 13:00:44 -0500 [thread overview]
Message-ID: <5417294C.2010506@ti.com> (raw)
In-Reply-To: <1410803937-27022-1-git-send-email-nm@ti.com>
On 09/15/2014 12:58 PM, Nishanth Menon wrote:
> Follow the license string convention indicated in include/linux/module.h
> (don't capitalize v).
>
> This fixes following randconfig warning:
> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister'
>
Uggh.. forgot to add:
Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2
>
> drivers/input/misc/palmas-pwrbutton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
> index 3f90211..4ed6f78 100644
> --- a/drivers/input/misc/palmas-pwrbutton.c
> +++ b/drivers/input/misc/palmas-pwrbutton.c
> @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
>
> MODULE_ALIAS("platform:palmas-pwrbutton");
> MODULE_DESCRIPTION("Palmas Power Button");
> -MODULE_LICENSE("GPL V2");
> +MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Texas Instruments Inc.");
>
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Input: palmas-pwrbutton: Fix typo in License
Date: Mon, 15 Sep 2014 13:00:44 -0500 [thread overview]
Message-ID: <5417294C.2010506@ti.com> (raw)
In-Reply-To: <1410803937-27022-1-git-send-email-nm@ti.com>
On 09/15/2014 12:58 PM, Nishanth Menon wrote:
> Follow the license string convention indicated in include/linux/module.h
> (don't capitalize v).
>
> This fixes following randconfig warning:
> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister'
>
Uggh.. forgot to add:
Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2
>
> drivers/input/misc/palmas-pwrbutton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
> index 3f90211..4ed6f78 100644
> --- a/drivers/input/misc/palmas-pwrbutton.c
> +++ b/drivers/input/misc/palmas-pwrbutton.c
> @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
>
> MODULE_ALIAS("platform:palmas-pwrbutton");
> MODULE_DESCRIPTION("Palmas Power Button");
> -MODULE_LICENSE("GPL V2");
> +MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Texas Instruments Inc.");
>
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Jim Davis <jim.epost@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License
Date: Mon, 15 Sep 2014 13:00:44 -0500 [thread overview]
Message-ID: <5417294C.2010506@ti.com> (raw)
In-Reply-To: <1410803937-27022-1-git-send-email-nm@ti.com>
On 09/15/2014 12:58 PM, Nishanth Menon wrote:
> Follow the license string convention indicated in include/linux/module.h
> (don't capitalize v).
>
> This fixes following randconfig warning:
> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister'
>
Uggh.. forgot to add:
Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2
>
> drivers/input/misc/palmas-pwrbutton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
> index 3f90211..4ed6f78 100644
> --- a/drivers/input/misc/palmas-pwrbutton.c
> +++ b/drivers/input/misc/palmas-pwrbutton.c
> @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
>
> MODULE_ALIAS("platform:palmas-pwrbutton");
> MODULE_DESCRIPTION("Palmas Power Button");
> -MODULE_LICENSE("GPL V2");
> +MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Texas Instruments Inc.");
>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-09-15 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 17:58 [PATCH] Input: palmas-pwrbutton: Fix typo in License Nishanth Menon
2014-09-15 17:58 ` Nishanth Menon
2014-09-15 17:58 ` Nishanth Menon
2014-09-15 18:00 ` Nishanth Menon [this message]
2014-09-15 18:00 ` Nishanth Menon
2014-09-15 18:00 ` Nishanth Menon
2014-09-15 21:35 ` Dmitry Torokhov
2014-09-15 21:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5417294C.2010506@ti.com \
--to=nm@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jim.epost@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.