From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] arm: mx35: use common timer functions
Date: Tue, 16 Sep 2014 12:56:13 +0200 [thread overview]
Message-ID: <5418174D.8010501@denx.de> (raw)
In-Reply-To: <1407853561-23688-4-git-send-email-andrew.ruder@elecsyscorp.com>
Hi Andrew,
On 12/08/2014 16:26, andrew.ruder at elecsyscorp.com wrote:
> From: Andrew Ruder <andrew.ruder@elecsyscorp.com>
>
> This patch moves mx35 to the common timer functions added in commit
>
> 8dfafdd - Introduce common timer functions <Rob Herring>
>
> The (removed) mx35 timer code (specifically __udelay()) could deadlock at
> the 32-bit boundary of get_ticks(). get_ticks() returned a 32-bit value
> cast up to a 64-bit value. If get_ticks() + tmo in __udelay() crossed
> the 32-bit boundary, the while condition became unconditionally true and
> locks the processor. Rather than patch the specific mx35 issues, simply
> move everything over to the common code.
>
> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>
> This patch has been COMPILE tested only. The situation isn't quite as
> bad on mx35 as 32-bit rollover occurs in about a day and a half.
>
I have applied both patches for MX31 and MX35, even if I had no time to
make myself a test. I hope in this way there is more testers before release.
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2014-09-16 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 14:25 [U-Boot] [PATCH 0/3] Initial cleanup of arm port timer subsystem andrew.ruder at elecsyscorp.com
2014-08-12 14:25 ` [U-Boot] [PATCH 1/3] arm: pxa: use common timer functions andrew.ruder at elecsyscorp.com
2014-08-12 18:20 ` Marek Vasut
2014-08-30 15:13 ` [U-Boot] [U-Boot,1/3] " Tom Rini
2014-09-16 14:44 ` Andrew Ruder
2014-08-12 14:26 ` [U-Boot] [PATCH 2/3] arm: mx31: " andrew.ruder at elecsyscorp.com
2014-08-12 18:21 ` Marek Vasut
2014-08-12 14:26 ` [U-Boot] [PATCH 3/3] arm: mx35: " andrew.ruder at elecsyscorp.com
2014-09-16 10:56 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418174D.8010501@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.