All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "heiko@sntech.de" <heiko@sntech.de>,
	"dianders@chromium.org" <dianders@chromium.org>,
	"sonnyrao@chromium.org" <sonnyrao@chromium.org>,
	"addy.ke@rock-chips.com" <addy.ke@rock-chips.com>,
	"cf@rock-chips.com" <cf@rock-chips.com>,
	"xjq@rock-chips.com" <xjq@rock-chips.com>,
	"hj@rock-chips.com" <hj@rock-chips.com>,
	"huangtao@rock-chips.com" <huangtao@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Jason Cooper <jason@lakedaemon.net>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Olof Johansson <olof@lixom.net>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Rohit Vaswani <rvaswani@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.k>
Subject: Re: [PATCH v2 1/3] Documentation: dt-bindings: add dt binding info for rk3288-smp
Date: Wed, 17 Sep 2014 09:12:28 +0800	[thread overview]
Message-ID: <5418DFFC.5030808@rock-chips.com> (raw)
In-Reply-To: <20140916185439.GF14191@leverpostej>

Hi Mark,

     Thanks for your comment.
On 09/17/2014 02:54 AM, Mark Rutland wrote:
> On Tue, Sep 16, 2014 at 11:44:28AM +0100, Kever Yang wrote:
>> This add documentation for rk3288 smp dt binding
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> Changes in v2:
>> - add documentation
>>
>>   Documentation/devicetree/bindings/arm/cpus.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
>> index 298e2f6..4b46233 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.txt
>> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
>> @@ -195,6 +195,7 @@ nodes to be present and contain the properties described below.
>>   			    "qcom,kpss-acc-v1"
>>   			    "qcom,kpss-acc-v2"
>>   			    "rockchip,rk3066-smp"
>> +			    "rockchip,rk3288-smp"
> How do these differ?
rk3066 and rk3288 smp bring up code is quite different, so I need a new 
node "rockchip,rk3288-smp"
other than "rockchip,rk3066-smp".
>
> What does "rockchip,rk3288-smp" mean exactly?
The driver who using this node is in 2/3 of this patchset, it goes to 
linux-arm-kernel list and linux-rockchip
list, I'm not sure if you have get that, maybe I need a RESEND?
>
> Presumably other nodes / properties are required?
Base on linux-next, I think only "rockchip,rk3288-smp" is new node to my 
driver.

BR
-Kever

WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "heiko@sntech.de" <heiko@sntech.de>,
	"dianders@chromium.org" <dianders@chromium.org>,
	"sonnyrao@chromium.org" <sonnyrao@chromium.org>,
	"addy.ke@rock-chips.com" <addy.ke@rock-chips.com>,
	"cf@rock-chips.com" <cf@rock-chips.com>,
	"xjq@rock-chips.com" <xjq@rock-chips.com>,
	"hj@rock-chips.com" <hj@rock-chips.com>,
	"huangtao@rock-chips.com" <huangtao@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Jason Cooper <jason@lakedaemon.net>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Olof Johansson <olof@lixom.net>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Rohit Vaswani <rvaswani@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] Documentation: dt-bindings: add dt binding info for rk3288-smp
Date: Wed, 17 Sep 2014 09:12:28 +0800	[thread overview]
Message-ID: <5418DFFC.5030808@rock-chips.com> (raw)
In-Reply-To: <20140916185439.GF14191@leverpostej>

Hi Mark,

     Thanks for your comment.
On 09/17/2014 02:54 AM, Mark Rutland wrote:
> On Tue, Sep 16, 2014 at 11:44:28AM +0100, Kever Yang wrote:
>> This add documentation for rk3288 smp dt binding
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> Changes in v2:
>> - add documentation
>>
>>   Documentation/devicetree/bindings/arm/cpus.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
>> index 298e2f6..4b46233 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.txt
>> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
>> @@ -195,6 +195,7 @@ nodes to be present and contain the properties described below.
>>   			    "qcom,kpss-acc-v1"
>>   			    "qcom,kpss-acc-v2"
>>   			    "rockchip,rk3066-smp"
>> +			    "rockchip,rk3288-smp"
> How do these differ?
rk3066 and rk3288 smp bring up code is quite different, so I need a new 
node "rockchip,rk3288-smp"
other than "rockchip,rk3066-smp".
>
> What does "rockchip,rk3288-smp" mean exactly?
The driver who using this node is in 2/3 of this patchset, it goes to 
linux-arm-kernel list and linux-rockchip
list, I'm not sure if you have get that, maybe I need a RESEND?
>
> Presumably other nodes / properties are required?
Base on linux-next, I think only "rockchip,rk3288-smp" is new node to my 
driver.

BR
-Kever


  reply	other threads:[~2014-09-17  1:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 10:44 [PATCH v2 0/3] add basic rk3288 smp support Kever Yang
2014-09-16 10:44 ` Kever Yang
2014-09-16 10:44 ` Kever Yang
2014-09-16 10:44 ` [PATCH v2 1/3] Documentation: dt-bindings: add dt binding info for rk3288-smp Kever Yang
2014-09-16 18:54   ` Mark Rutland
2014-09-16 18:54     ` Mark Rutland
2014-09-17  1:12     ` Kever Yang [this message]
2014-09-17  1:12       ` Kever Yang
     [not found]       ` <5418DFFC.5030808-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-17 19:50         ` Mark Rutland
2014-09-17 19:50           ` Mark Rutland
2014-09-16 10:44 ` [PATCH v2 2/3] ARM: rockchip: add basic smp support for rk3288 Kever Yang
2014-09-16 10:44   ` Kever Yang
2014-09-16 20:17   ` Sonny Rao
2014-09-16 20:17     ` Sonny Rao
2014-09-17  1:03     ` Kever Yang
2014-09-17  1:03       ` Kever Yang
2014-09-17  8:03       ` Heiko Stübner
2014-09-17  8:03         ` Heiko Stübner
2014-09-16 10:44 ` [PATCH v2 3/3] ARM: dts: add intmem node for rk3288 smp support Kever Yang
2014-09-16 10:44   ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5418DFFC.5030808@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=addy.ke@rock-chips.com \
    --cc=cf@rock-chips.com \
    --cc=devicetree@vger.k \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=heiko@sntech.de \
    --cc=hj@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedaemon.net \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=rvaswani@codeaurora.org \
    --cc=sonnyrao@chromium.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=xjq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.