* [PATCH] can: at91_can: prepare and unprepare the clock
@ 2014-09-17 9:05 David Dueck
2014-09-17 9:12 ` Marc Kleine-Budde
0 siblings, 1 reply; 6+ messages in thread
From: David Dueck @ 2014-09-17 9:05 UTC (permalink / raw)
To: linux-arm-kernel
This prevents a warning.
Signed-off-by: David Dueck <davidcdueck@googlemail.com>
Signed-off-by: Anthony Harivel <anthony.harivel@emtrion.de>
---
drivers/net/can/at91_can.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index f07fa89..7dcb790 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -1123,7 +1123,7 @@ static int at91_open(struct net_device *dev)
struct at91_priv *priv = netdev_priv(dev);
int err;
- clk_enable(priv->clk);
+ clk_prepare_enable(priv->clk);
/* check or determine and set bittime */
err = open_candev(dev);
@@ -1149,7 +1149,7 @@ static int at91_open(struct net_device *dev)
out_close:
close_candev(dev);
out:
- clk_disable(priv->clk);
+ clk_disable_unprepare(priv->clk);
return err;
}
@@ -1166,7 +1166,7 @@ static int at91_close(struct net_device *dev)
at91_chip_stop(dev, CAN_STATE_STOPPED);
free_irq(dev->irq, dev);
- clk_disable(priv->clk);
+ clk_disable_unprepare(priv->clk);
close_candev(dev);
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] can: at91_can: prepare and unprepare the clock
@ 2014-09-17 9:05 David Dueck
0 siblings, 0 replies; 6+ messages in thread
From: David Dueck @ 2014-09-17 9:05 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: mkl, wg, nicolas.ferre, Anthony Harivel
This prevents a warning.
Signed-off-by: David Dueck <davidcdueck@googlemail.com>
Signed-off-by: Anthony Harivel <anthony.harivel@emtrion.de>
---
drivers/net/can/at91_can.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index f07fa89..7dcb790 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -1123,7 +1123,7 @@ static int at91_open(struct net_device *dev)
struct at91_priv *priv = netdev_priv(dev);
int err;
- clk_enable(priv->clk);
+ clk_prepare_enable(priv->clk);
/* check or determine and set bittime */
err = open_candev(dev);
@@ -1149,7 +1149,7 @@ static int at91_open(struct net_device *dev)
out_close:
close_candev(dev);
out:
- clk_disable(priv->clk);
+ clk_disable_unprepare(priv->clk);
return err;
}
@@ -1166,7 +1166,7 @@ static int at91_close(struct net_device *dev)
at91_chip_stop(dev, CAN_STATE_STOPPED);
free_irq(dev->irq, dev);
- clk_disable(priv->clk);
+ clk_disable_unprepare(priv->clk);
close_candev(dev);
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] can: at91_can: prepare and unprepare the clock
2014-09-17 9:05 [PATCH] can: at91_can: prepare and unprepare the clock David Dueck
@ 2014-09-17 9:12 ` Marc Kleine-Budde
0 siblings, 0 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2014-09-17 9:12 UTC (permalink / raw)
To: David Dueck, linux-arm-kernel
Cc: wg, nicolas.ferre, Anthony Harivel, linux-can@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
On 09/17/2014 11:05 AM, David Dueck wrote:
> This prevents a warning.
Which warning?
Can you please check the return value of clock_prepare_enbale().
Marc
BTW: Please add linux-can@vger.kernel.org on Cc for CAN related patches.
> Signed-off-by: David Dueck <davidcdueck@googlemail.com>
> Signed-off-by: Anthony Harivel <anthony.harivel@emtrion.de>
> ---
> drivers/net/can/at91_can.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
> index f07fa89..7dcb790 100644
> --- a/drivers/net/can/at91_can.c
> +++ b/drivers/net/can/at91_can.c
> @@ -1123,7 +1123,7 @@ static int at91_open(struct net_device *dev)
> struct at91_priv *priv = netdev_priv(dev);
> int err;
>
> - clk_enable(priv->clk);
> + clk_prepare_enable(priv->clk);
>
> /* check or determine and set bittime */
> err = open_candev(dev);
> @@ -1149,7 +1149,7 @@ static int at91_open(struct net_device *dev)
> out_close:
> close_candev(dev);
> out:
> - clk_disable(priv->clk);
> + clk_disable_unprepare(priv->clk);
>
> return err;
> }
> @@ -1166,7 +1166,7 @@ static int at91_close(struct net_device *dev)
> at91_chip_stop(dev, CAN_STATE_STOPPED);
>
> free_irq(dev->irq, dev);
> - clk_disable(priv->clk);
> + clk_disable_unprepare(priv->clk);
>
> close_candev(dev);
>
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] can: at91_can: prepare and unprepare the clock
@ 2014-09-17 9:12 ` Marc Kleine-Budde
0 siblings, 0 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2014-09-17 9:12 UTC (permalink / raw)
To: linux-arm-kernel
On 09/17/2014 11:05 AM, David Dueck wrote:
> This prevents a warning.
Which warning?
Can you please check the return value of clock_prepare_enbale().
Marc
BTW: Please add linux-can at vger.kernel.org on Cc for CAN related patches.
> Signed-off-by: David Dueck <davidcdueck@googlemail.com>
> Signed-off-by: Anthony Harivel <anthony.harivel@emtrion.de>
> ---
> drivers/net/can/at91_can.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
> index f07fa89..7dcb790 100644
> --- a/drivers/net/can/at91_can.c
> +++ b/drivers/net/can/at91_can.c
> @@ -1123,7 +1123,7 @@ static int at91_open(struct net_device *dev)
> struct at91_priv *priv = netdev_priv(dev);
> int err;
>
> - clk_enable(priv->clk);
> + clk_prepare_enable(priv->clk);
>
> /* check or determine and set bittime */
> err = open_candev(dev);
> @@ -1149,7 +1149,7 @@ static int at91_open(struct net_device *dev)
> out_close:
> close_candev(dev);
> out:
> - clk_disable(priv->clk);
> + clk_disable_unprepare(priv->clk);
>
> return err;
> }
> @@ -1166,7 +1166,7 @@ static int at91_close(struct net_device *dev)
> at91_chip_stop(dev, CAN_STATE_STOPPED);
>
> free_irq(dev->irq, dev);
> - clk_disable(priv->clk);
> + clk_disable_unprepare(priv->clk);
>
> close_candev(dev);
>
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140917/e395fcfd/attachment-0001.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] can: at91_can: prepare and unprepare the clock
2014-09-17 9:12 ` Marc Kleine-Budde
@ 2014-09-17 10:11 ` D. Dueck
-1 siblings, 0 replies; 6+ messages in thread
From: D. Dueck @ 2014-09-17 10:11 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: linux-arm-kernel, wg, nicolas.ferre, Anthony Harivel,
linux-can@vger.kernel.org
2014-09-17 11:12 GMT+02:00 Marc Kleine-Budde <mkl@pengutronix.de>:
> Which warning?
I will rephrase this. When using COMMON_CLK, for example on sama5d3, we
have to prepare the clock first. I will send v2.
> Can you please check the return value of clock_prepare_enbale().
Yes, sorry I missed that.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] can: at91_can: prepare and unprepare the clock
@ 2014-09-17 10:11 ` D. Dueck
0 siblings, 0 replies; 6+ messages in thread
From: D. Dueck @ 2014-09-17 10:11 UTC (permalink / raw)
To: linux-arm-kernel
2014-09-17 11:12 GMT+02:00 Marc Kleine-Budde <mkl@pengutronix.de>:
> Which warning?
I will rephrase this. When using COMMON_CLK, for example on sama5d3, we
have to prepare the clock first. I will send v2.
> Can you please check the return value of clock_prepare_enbale().
Yes, sorry I missed that.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-17 10:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 9:05 [PATCH] can: at91_can: prepare and unprepare the clock David Dueck
2014-09-17 9:12 ` Marc Kleine-Budde
2014-09-17 9:12 ` Marc Kleine-Budde
2014-09-17 10:11 ` D. Dueck
2014-09-17 10:11 ` D. Dueck
-- strict thread matches above, loose matches on Subject: below --
2014-09-17 9:05 David Dueck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.