From: James Hogan <james.hogan@imgtec.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-fsdevel@vger.kernel.org, linux-metag@vger.kernel.org
Subject: Re: [PATCH] vfs: workaround gcc <4.6 build error in link_path_walk()
Date: Wed, 17 Sep 2014 15:05:09 +0100 [thread overview]
Message-ID: <54199515.6000402@imgtec.com> (raw)
In-Reply-To: <20140916173951.GX7996@ZenIV.linux.org.uk>
On 16/09/14 18:39, Al Viro wrote:
> On Tue, Sep 16, 2014 at 01:07:35PM +0100, James Hogan wrote:
>> Commit d6bb3e9075bb (vfs: simplify and shrink stack frame of
>> link_path_walk()) introduced build problems with GCC versions older than
>> 4.6 due to the initialisation of a member of an anonymous union in
>> struct qstr without enclosing braces.
>>
>> This hits GCC bug 10676 [1] (which was fixed in GCC 4.6 by [2]), and
>> causes the following build error:
>> fs/namei.c: In function 'link_path_walk':
>> fs/namei.c:1778: error: unknown field 'hash_len' specified in initializer
>>
>> This is worked around by adding explicit braces.
>
> IOW, the same thing QSTR_INIT is doing...
QSTR_INIT only initialises len and name, not the hash.
Cheers
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
<linux-fsdevel@vger.kernel.org>, <linux-metag@vger.kernel.org>
Subject: Re: [PATCH] vfs: workaround gcc <4.6 build error in link_path_walk()
Date: Wed, 17 Sep 2014 15:05:09 +0100 [thread overview]
Message-ID: <54199515.6000402@imgtec.com> (raw)
In-Reply-To: <20140916173951.GX7996@ZenIV.linux.org.uk>
On 16/09/14 18:39, Al Viro wrote:
> On Tue, Sep 16, 2014 at 01:07:35PM +0100, James Hogan wrote:
>> Commit d6bb3e9075bb (vfs: simplify and shrink stack frame of
>> link_path_walk()) introduced build problems with GCC versions older than
>> 4.6 due to the initialisation of a member of an anonymous union in
>> struct qstr without enclosing braces.
>>
>> This hits GCC bug 10676 [1] (which was fixed in GCC 4.6 by [2]), and
>> causes the following build error:
>> fs/namei.c: In function 'link_path_walk':
>> fs/namei.c:1778: error: unknown field 'hash_len' specified in initializer
>>
>> This is worked around by adding explicit braces.
>
> IOW, the same thing QSTR_INIT is doing...
QSTR_INIT only initialises len and name, not the hash.
Cheers
James
next prev parent reply other threads:[~2014-09-17 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 12:07 [PATCH] vfs: workaround gcc <4.6 build error in link_path_walk() James Hogan
2014-09-16 12:07 ` James Hogan
2014-09-16 17:39 ` Al Viro
2014-09-17 14:05 ` James Hogan [this message]
2014-09-17 14:05 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54199515.6000402@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=geert@linux-m68k.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.