* [PATCH] selftests/memfd: Run test on all architectures @ 2014-09-15 22:59 ` Pranith Kumar 0 siblings, 0 replies; 9+ messages in thread From: Pranith Kumar @ 2014-09-15 22:59 UTC (permalink / raw) To: Shuah Khan, Andrew Morton, Hugh Dickins, David Herrmann, Phong Tran, open list:KERNEL SELFTEST F..., open list Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> --- tools/testing/selftests/memfd/Makefile | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile index ad4ab01..b80cd10 100644 --- a/tools/testing/selftests/memfd/Makefile +++ b/tools/testing/selftests/memfd/Makefile @@ -1,38 +1,17 @@ -uname_M := $(shell uname -m 2>/dev/null || echo not) -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) -ifeq ($(ARCH),i386) - ARCH := x86 -endif -ifeq ($(ARCH),x86_64) - ARCH := x86 -endif - CFLAGS += -D_FILE_OFFSET_BITS=64 -CFLAGS += -I../../../../arch/x86/include/generated/uapi/ -CFLAGS += -I../../../../arch/x86/include/uapi/ CFLAGS += -I../../../../include/uapi/ CFLAGS += -I../../../../include/ all: -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_tests: all -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -endif @./memfd_test || echo "memfd_test: [FAIL]" build_fuse: -ifeq ($(ARCH),x86) gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt gcc $(CFLAGS) fuse_test.c -o fuse_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_fuse: build_fuse @./run_fuse_test.sh || echo "fuse_test: [FAIL]" -- 2.1.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] selftests/memfd: Run test on all architectures @ 2014-09-15 22:59 ` Pranith Kumar 0 siblings, 0 replies; 9+ messages in thread From: Pranith Kumar @ 2014-09-15 22:59 UTC (permalink / raw) To: Shuah Khan, Andrew Morton, Hugh Dickins, David Herrmann, Phong Tran, open list:KERNEL SELFTEST F..., open list Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> --- tools/testing/selftests/memfd/Makefile | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile index ad4ab01..b80cd10 100644 --- a/tools/testing/selftests/memfd/Makefile +++ b/tools/testing/selftests/memfd/Makefile @@ -1,38 +1,17 @@ -uname_M := $(shell uname -m 2>/dev/null || echo not) -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) -ifeq ($(ARCH),i386) - ARCH := x86 -endif -ifeq ($(ARCH),x86_64) - ARCH := x86 -endif - CFLAGS += -D_FILE_OFFSET_BITS=64 -CFLAGS += -I../../../../arch/x86/include/generated/uapi/ -CFLAGS += -I../../../../arch/x86/include/uapi/ CFLAGS += -I../../../../include/uapi/ CFLAGS += -I../../../../include/ all: -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_tests: all -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -endif @./memfd_test || echo "memfd_test: [FAIL]" build_fuse: -ifeq ($(ARCH),x86) gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt gcc $(CFLAGS) fuse_test.c -o fuse_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_fuse: build_fuse @./run_fuse_test.sh || echo "fuse_test: [FAIL]" -- 2.1.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests/memfd: Run test on all architectures 2014-09-15 22:59 ` Pranith Kumar (?) @ 2014-09-17 12:28 ` David Herrmann 2014-09-17 15:36 ` Shuah Khan -1 siblings, 1 reply; 9+ messages in thread From: David Herrmann @ 2014-09-17 12:28 UTC (permalink / raw) To: Pranith Kumar Cc: Shuah Khan, Andrew Morton, Hugh Dickins, Phong Tran, open list:KERNEL SELFTEST F..., open list Hi On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar <bobby.prani@gmail.com> wrote: > Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. > > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> Now that most archs have __NR_memfd_create, this is: Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Thanks David > --- > tools/testing/selftests/memfd/Makefile | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile > index ad4ab01..b80cd10 100644 > --- a/tools/testing/selftests/memfd/Makefile > +++ b/tools/testing/selftests/memfd/Makefile > @@ -1,38 +1,17 @@ > -uname_M := $(shell uname -m 2>/dev/null || echo not) > -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) > -ifeq ($(ARCH),i386) > - ARCH := x86 > -endif > -ifeq ($(ARCH),x86_64) > - ARCH := x86 > -endif > - > CFLAGS += -D_FILE_OFFSET_BITS=64 > -CFLAGS += -I../../../../arch/x86/include/generated/uapi/ > -CFLAGS += -I../../../../arch/x86/include/uapi/ > CFLAGS += -I../../../../include/uapi/ > CFLAGS += -I../../../../include/ > > all: > -ifeq ($(ARCH),x86) > gcc $(CFLAGS) memfd_test.c -o memfd_test > -else > - echo "Not an x86 target, can't build memfd selftest" > -endif > > run_tests: all > -ifeq ($(ARCH),x86) > gcc $(CFLAGS) memfd_test.c -o memfd_test > -endif > @./memfd_test || echo "memfd_test: [FAIL]" > > build_fuse: > -ifeq ($(ARCH),x86) > gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt > gcc $(CFLAGS) fuse_test.c -o fuse_test > -else > - echo "Not an x86 target, can't build memfd selftest" > -endif > > run_fuse: build_fuse > @./run_fuse_test.sh || echo "fuse_test: [FAIL]" > -- > 2.1.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests/memfd: Run test on all architectures 2014-09-17 12:28 ` David Herrmann @ 2014-09-17 15:36 ` Shuah Khan [not found] ` <5419AA71.4020506-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Shuah Khan @ 2014-09-17 15:36 UTC (permalink / raw) To: David Herrmann, Pranith Kumar Cc: Andrew Morton, Hugh Dickins, Phong Tran, open list:KERNEL SELFTEST F..., open list, Shuah Khan On 09/17/2014 06:28 AM, David Herrmann wrote: > Hi > > On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar <bobby.prani@gmail.com> wrote: >> Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. >> >> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > > Now that most archs have __NR_memfd_create, this is: > > Reviewed-by: David Herrmann <dh.herrmann@gmail.com> > Hmm. I am seeing failures on x86_64 on top of Linus's tree (without this patch) make -C tools/testing/selftests/memfd/make: Entering directory `/lkml/linus_git_3.14/tools/testing/selftests/memfd' gcc -D_FILE_OFFSET_BITS=64 -I../../../../arch/x86/include/generated/uapi/ -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ -I../../../../include/ memfd_test.c -o memfd_test memfd_test.c: In function ‘sys_memfd_create’: memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in this function) return syscall(__NR_memfd_create, name, flags); ^ memfd_test.c:26:17: note: each undeclared identifier is reported only once for each function it appears in Could you please look into this?? It appears __NR_memfd_create isn't defined on x86_64??? thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <5419AA71.4020506-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>]
* Re: [PATCH] selftests/memfd: Run test on all architectures 2014-09-17 15:36 ` Shuah Khan @ 2014-09-17 15:39 ` Pranith Kumar 0 siblings, 0 replies; 9+ messages in thread From: Pranith Kumar @ 2014-09-17 15:39 UTC (permalink / raw) To: Shuah Khan Cc: David Herrmann, Andrew Morton, Hugh Dickins, Phong Tran, open list:KERNEL SELFTEST F..., open list On Wed, Sep 17, 2014 at 11:36 AM, Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> wrote: > Hmm. I am seeing failures on x86_64 on top of Linus's tree > (without this patch) > > make -C tools/testing/selftests/memfd/make: Entering directory > `/lkml/linus_git_3.14/tools/testing/selftests/memfd' > gcc -D_FILE_OFFSET_BITS=64 > -I../../../../arch/x86/include/generated/uapi/ > -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ > -I../../../../include/ memfd_test.c -o memfd_test > memfd_test.c: In function ‘sys_memfd_create’: > memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in > this function) > return syscall(__NR_memfd_create, name, flags); > ^ > memfd_test.c:26:17: note: each undeclared identifier is reported only > once for each function it appears in > > Could you please look into this?? It appears __NR_memfd_create isn't > defined on x86_64??? > Hi Shuah, Did you compile the tree before trying to compile this test? Compiling the kernel will generate the required symbols which are used in this test. Thanks! -- Pranith ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests/memfd: Run test on all architectures @ 2014-09-17 15:39 ` Pranith Kumar 0 siblings, 0 replies; 9+ messages in thread From: Pranith Kumar @ 2014-09-17 15:39 UTC (permalink / raw) To: Shuah Khan Cc: David Herrmann, Andrew Morton, Hugh Dickins, Phong Tran, open list:KERNEL SELFTEST F..., open list On Wed, Sep 17, 2014 at 11:36 AM, Shuah Khan <shuahkh@osg.samsung.com> wrote: > Hmm. I am seeing failures on x86_64 on top of Linus's tree > (without this patch) > > make -C tools/testing/selftests/memfd/make: Entering directory > `/lkml/linus_git_3.14/tools/testing/selftests/memfd' > gcc -D_FILE_OFFSET_BITS=64 > -I../../../../arch/x86/include/generated/uapi/ > -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ > -I../../../../include/ memfd_test.c -o memfd_test > memfd_test.c: In function ‘sys_memfd_create’: > memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in > this function) > return syscall(__NR_memfd_create, name, flags); > ^ > memfd_test.c:26:17: note: each undeclared identifier is reported only > once for each function it appears in > > Could you please look into this?? It appears __NR_memfd_create isn't > defined on x86_64??? > Hi Shuah, Did you compile the tree before trying to compile this test? Compiling the kernel will generate the required symbols which are used in this test. Thanks! -- Pranith ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests/memfd: Run test on all architectures 2014-09-17 15:36 ` Shuah Khan @ 2014-09-17 15:39 ` David Herrmann 0 siblings, 0 replies; 9+ messages in thread From: David Herrmann @ 2014-09-17 15:39 UTC (permalink / raw) To: Shuah Khan Cc: Pranith Kumar, Andrew Morton, Hugh Dickins, Phong Tran, open list:KERNEL SELFTEST F..., open list Hi On Wed, Sep 17, 2014 at 5:36 PM, Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> wrote: > On 09/17/2014 06:28 AM, David Herrmann wrote: >> Hi >> >> On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar <bobby.prani@gmail.com> wrote: >>> Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. >>> >>> Signed-off-by: Pranith Kumar <bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> >> Now that most archs have __NR_memfd_create, this is: >> >> Reviewed-by: David Herrmann <dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> > > Hmm. I am seeing failures on x86_64 on top of Linus's tree > (without this patch) > > make -C tools/testing/selftests/memfd/make: Entering directory > `/lkml/linus_git_3.14/tools/testing/selftests/memfd' > gcc -D_FILE_OFFSET_BITS=64 > -I../../../../arch/x86/include/generated/uapi/ > -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ > -I../../../../include/ memfd_test.c -o memfd_test > memfd_test.c: In function ‘sys_memfd_create’: > memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in > this function) > return syscall(__NR_memfd_create, name, flags); > ^ > memfd_test.c:26:17: note: each undeclared identifier is reported only > once for each function it appears in > > Could you please look into this?? It appears __NR_memfd_create isn't > defined on x86_64??? You need the headers installed in your system. By dropping the arch-includes from the Makefile, we require 3.17 headers in /usr/include. Thanks David ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests/memfd: Run test on all architectures @ 2014-09-17 15:39 ` David Herrmann 0 siblings, 0 replies; 9+ messages in thread From: David Herrmann @ 2014-09-17 15:39 UTC (permalink / raw) To: Shuah Khan Cc: Pranith Kumar, Andrew Morton, Hugh Dickins, Phong Tran, open list:KERNEL SELFTEST F..., open list Hi On Wed, Sep 17, 2014 at 5:36 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: > On 09/17/2014 06:28 AM, David Herrmann wrote: >> Hi >> >> On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar <bobby.prani@gmail.com> wrote: >>> Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. >>> >>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> >> >> Now that most archs have __NR_memfd_create, this is: >> >> Reviewed-by: David Herrmann <dh.herrmann@gmail.com> >> > > Hmm. I am seeing failures on x86_64 on top of Linus's tree > (without this patch) > > make -C tools/testing/selftests/memfd/make: Entering directory > `/lkml/linus_git_3.14/tools/testing/selftests/memfd' > gcc -D_FILE_OFFSET_BITS=64 > -I../../../../arch/x86/include/generated/uapi/ > -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ > -I../../../../include/ memfd_test.c -o memfd_test > memfd_test.c: In function ‘sys_memfd_create’: > memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in > this function) > return syscall(__NR_memfd_create, name, flags); > ^ > memfd_test.c:26:17: note: each undeclared identifier is reported only > once for each function it appears in > > Could you please look into this?? It appears __NR_memfd_create isn't > defined on x86_64??? You need the headers installed in your system. By dropping the arch-includes from the Makefile, we require 3.17 headers in /usr/include. Thanks David ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests/memfd: Run test on all architectures 2014-09-17 15:39 ` David Herrmann (?) @ 2014-09-17 15:41 ` Shuah Khan -1 siblings, 0 replies; 9+ messages in thread From: Shuah Khan @ 2014-09-17 15:41 UTC (permalink / raw) To: David Herrmann Cc: Pranith Kumar, Andrew Morton, Hugh Dickins, Phong Tran, open list:KERNEL SELFTEST F..., open list On 09/17/2014 09:39 AM, David Herrmann wrote: > Hi > > On Wed, Sep 17, 2014 at 5:36 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >> On 09/17/2014 06:28 AM, David Herrmann wrote: >>> Hi >>> >>> On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar <bobby.prani@gmail.com> wrote: >>>> Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. >>>> >>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> >>> >>> Now that most archs have __NR_memfd_create, this is: >>> >>> Reviewed-by: David Herrmann <dh.herrmann@gmail.com> >>> >> >> Hmm. I am seeing failures on x86_64 on top of Linus's tree >> (without this patch) >> >> make -C tools/testing/selftests/memfd/make: Entering directory >> `/lkml/linus_git_3.14/tools/testing/selftests/memfd' >> gcc -D_FILE_OFFSET_BITS=64 >> -I../../../../arch/x86/include/generated/uapi/ >> -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ >> -I../../../../include/ memfd_test.c -o memfd_test >> memfd_test.c: In function ‘sys_memfd_create’: >> memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in >> this function) >> return syscall(__NR_memfd_create, name, flags); >> ^ >> memfd_test.c:26:17: note: each undeclared identifier is reported only >> once for each function it appears in >> >> Could you please look into this?? It appears __NR_memfd_create isn't >> defined on x86_64??? > > You need the headers installed in your system. By dropping the > arch-includes from the Makefile, we require 3.17 headers in > /usr/include. > Sorry - wrong system without the headers installed. My bad. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-17 15:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-15 22:59 [PATCH] selftests/memfd: Run test on all architectures Pranith Kumar
2014-09-15 22:59 ` Pranith Kumar
2014-09-17 12:28 ` David Herrmann
2014-09-17 15:36 ` Shuah Khan
[not found] ` <5419AA71.4020506-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-09-17 15:39 ` Pranith Kumar
2014-09-17 15:39 ` Pranith Kumar
2014-09-17 15:39 ` David Herrmann
2014-09-17 15:39 ` David Herrmann
2014-09-17 15:41 ` Shuah Khan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.