From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@canonical.com>
Cc: James Bottomley <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout
Date: Thu, 18 Sep 2014 11:03:26 -0600 [thread overview]
Message-ID: <541B105E.1030507@fb.com> (raw)
In-Reply-To: <20140918163549.GB3950@lst.de>
On 2014-09-18 10:35, Christoph Hellwig wrote:
> On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote:
>> If there are two requests or more timed out, the dispatch queue
>> is put into stopped state and never be recoverd, and there
>> is no such problem in non-mq mode.
>>
>> This patch trys to recover the stopped queue when the queue
>> becomes unbusy, then the following retries can move on.
>>
>> Basically this patch maintains same behavior for this situation
>> with non-mq mode.
>
> This looks somewhat similar to the issues that Doug reported, and I remember
> when he was last running into boot problems it was timeout related, too.
>
> As far as the implementation is concerned I think the correct fix is
> to clear the BLK_MQ_S_STOPPED queue flags in blk_mq_kick_requeue_list.
Since that's the kick part of the requeue, auto-starting the queue for
that makes a lot of sense. I say that's the way we go.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@canonical.com>
Cc: James Bottomley <JBottomley@parallels.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout
Date: Thu, 18 Sep 2014 11:03:26 -0600 [thread overview]
Message-ID: <541B105E.1030507@fb.com> (raw)
In-Reply-To: <20140918163549.GB3950@lst.de>
On 2014-09-18 10:35, Christoph Hellwig wrote:
> On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote:
>> If there are two requests or more timed out, the dispatch queue
>> is put into stopped state and never be recoverd, and there
>> is no such problem in non-mq mode.
>>
>> This patch trys to recover the stopped queue when the queue
>> becomes unbusy, then the following retries can move on.
>>
>> Basically this patch maintains same behavior for this situation
>> with non-mq mode.
>
> This looks somewhat similar to the issues that Doug reported, and I remember
> when he was last running into boot problems it was timeout related, too.
>
> As far as the implementation is concerned I think the correct fix is
> to clear the BLK_MQ_S_STOPPED queue flags in blk_mq_kick_requeue_list.
Since that's the kick part of the requeue, auto-starting the queue for
that makes a lot of sense. I say that's the way we go.
--
Jens Axboe
next prev parent reply other threads:[~2014-09-18 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 15:59 [PATCH] scsi-mq: fix hw queue hang caused by timeout Ming Lei
2014-09-18 16:35 ` Christoph Hellwig
2014-09-18 17:03 ` Jens Axboe [this message]
2014-09-18 17:03 ` Jens Axboe
2014-09-19 13:07 ` Ming Lei
2014-09-19 14:18 ` Ming Lei
2014-09-19 14:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B105E.1030507@fb.com \
--to=axboe@fb.com \
--cc=JBottomley@parallels.com \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.