Re: [meta-fsl-arm-extra][PATCH] linux-boundary (3.10.17): add CONFIG_USB_G_MULTI

[Eric Nelson <eric.nelson@boundarydevices.com>]

Hi Simon,

On 09/18/2014 05:05 AM, Simon Kuhnle wrote:
> Hi Eric,
> 
> On 08/22/2014 12:06 AM, Eric Nelson wrote:
>> On 07/28/2014 04:30 AM, Simon Kuhnle wrote:
>>>
>>> Signed-off-by: Simon Kuhnle <simon.kuhnle@methodpark.de>
>>> ---
>>>   .../nitrogen6x-lite/defconfig                      |    1 +
>>>   .../linux-boundary-3.10.17/nitrogen6x/defconfig    |    1 +
>>>   2 files changed, 2 insertions(+)
>>>
>>> diff --git
>>> a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig
>>> b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig
>>> index dbe579e..c077a5f 100644
>>> ---
>>> a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig
>>> +++
>>> b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig
>>> @@ -229,6 +229,7 @@ CONFIG_USB_ZERO=m
>>>   CONFIG_USB_ETH=m
>>>   CONFIG_USB_MASS_STORAGE=m
>>>   CONFIG_USB_G_SERIAL=m
>>> +CONFIG_USB_G_MULTI=m
>>>   CONFIG_MMC=y
>>>   CONFIG_MMC_UNSAFE_RESUME=y
>>>   CONFIG_MMC_SDHCI=y
>>> diff --git
>>> a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig
>>> b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig
>>> index 6bb7159..810d040 100644
>>> --- a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig
>>> +++ b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig
>>> @@ -242,6 +242,7 @@ CONFIG_USB_ZERO=m
>>>   CONFIG_USB_ETH=m
>>>   CONFIG_USB_MASS_STORAGE=m
>>>   CONFIG_USB_G_SERIAL=m
>>> +CONFIG_USB_G_MULTI=m
>>>   CONFIG_MMC=y
>>>   CONFIG_MMC_UNSAFE_RESUME=y
>>>   CONFIG_MMC_SDHCI=y
>>>
>>
>> Sorry it took so long to respond. I wanted to test this out for
>> any regressions.
>>
>> I just did, and it looks harmless. I'm still not sure how this
>> is useful without the inclusion of either or both USB_G_MULTI_CDC or
>> USB_G_MULTI_RNDIS, but...
> 
> sorry it took _me_ so long to respond and thank you for applying the patch!
> 

No worries.

This change was committed to master while you were out!

https://github.com/Freescale/meta-fsl-arm-extra/commit/664e70e

> If CONFIG_USB_G_MULTI is selected then USB_G_MULTI_RNDIS is selected
> automatically, at least in the builds I did.
> 
> According to the help files of both the RNDIS option, as well as the CDC
> option, choosing RNDIS seems like the best option. Selecting both CDC
> and RNDIS confuses Windows machines and RNDIS alone should work  on
> Windows out of the box (that I did not test) and it worked on my Ubuntu
> 14.04. workstation without problems.
> 
> Maybe I should send in another patch that explicitly enables
> USB_G_MULTI_RNDIS and unsets USB_G_MULTI_CDC, so it is obvious what
> happens. Sorry for the confusion.
> 

I figured that out, tested, and acked.

Thanks for the patch.


Eric