From: gang.chen.5i5j@gmail.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
Date: Sat, 20 Sep 2014 12:19:24 +0800 [thread overview]
Message-ID: <541D004C.6020108@gmail.com> (raw)
In-Reply-To: <540D3C89.6080702@monstr.eu>
Hello Maintainers:
Please help check this patch, when you have time.
Thanks.
On 09/08/2014 01:20 PM, Michal Simek wrote:
> On 09/03/2014 05:50 PM, Chen Gang wrote:
>> Need include it for irq_of_parse_and_map(), the related error with
>> allmodconfig under microblaze:
>>
>> drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
>> irq = irq_of_parse_and_map(dn, 0);
>> ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/usb/host/ehci-xilinx-of.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>> index fe57710..a232836 100644
>> --- a/drivers/usb/host/ehci-xilinx-of.c
>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>> @@ -31,6 +31,7 @@
>> #include <linux/of.h>
>> #include <linux/of_platform.h>
>> #include <linux/of_address.h>
>> +#include <linux/of_irq.h>
>>
>> /**
>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
>>
>
> Acked-by: Michal Simek <monstr@monstr.eu>
>
> Thanks,
> Michal
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: monstr@monstr.eu, stern@rowland.harvard.edu
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
michal.simek@xilinx.com, linux-usb@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
Date: Sat, 20 Sep 2014 12:19:24 +0800 [thread overview]
Message-ID: <541D004C.6020108@gmail.com> (raw)
In-Reply-To: <540D3C89.6080702@monstr.eu>
Hello Maintainers:
Please help check this patch, when you have time.
Thanks.
On 09/08/2014 01:20 PM, Michal Simek wrote:
> On 09/03/2014 05:50 PM, Chen Gang wrote:
>> Need include it for irq_of_parse_and_map(), the related error with
>> allmodconfig under microblaze:
>>
>> drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’:
>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration]
>> irq = irq_of_parse_and_map(dn, 0);
>> ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/usb/host/ehci-xilinx-of.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>> index fe57710..a232836 100644
>> --- a/drivers/usb/host/ehci-xilinx-of.c
>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>> @@ -31,6 +31,7 @@
>> #include <linux/of.h>
>> #include <linux/of_platform.h>
>> #include <linux/of_address.h>
>> +#include <linux/of_irq.h>
>>
>> /**
>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
>>
>
> Acked-by: Michal Simek <monstr@monstr.eu>
>
> Thanks,
> Michal
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2014-09-20 4:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 15:50 [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error Chen Gang
2014-09-03 15:50 ` Chen Gang
2014-09-08 5:20 ` Michal Simek
2014-09-08 5:20 ` Michal Simek
2014-09-20 4:19 ` Chen Gang [this message]
2014-09-20 4:19 ` Chen Gang
2014-09-22 13:25 ` Michal Simek
2014-09-22 13:25 ` Michal Simek
2014-09-24 15:41 ` Alan Stern
2014-09-24 15:41 ` Alan Stern
2014-09-29 1:52 ` Greg Kroah-Hartman
2014-09-29 1:52 ` Greg Kroah-Hartman
2014-09-29 7:01 ` Chen Gang
2014-09-29 7:01 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541D004C.6020108@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.