From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] ARM: mvebu: armada-xp: Add I2C eeprom on Lenovo ix4-300d
Date: Sat, 20 Sep 2014 11:55:58 +0200 [thread overview]
Message-ID: <541D4F2E.9020707@gmail.com> (raw)
In-Reply-To: <1411157684-6991-8-git-send-email-sebastian.hesselbarth@gmail.com>
On 09/19/2014 10:14 PM, Sebastian Hesselbarth wrote:
> There is an I2C eeprom connected on Lenovo ix4-300d, add the
> corresponding node.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
...
> ---
> arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> index c5ee6c00766c..cef50da88e45 100644
> --- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> @@ -98,6 +98,11 @@
> reg = <0x2e>;
> };
>
> + at24c64 at 50 {
nit: the node name should describe function, not its type.
@Jason, when you take this in, feel free to name the node eeprom at 50
instead.
Sebastian
> + compatible = "atmel,24c64";
> + reg = <0x50>;
> + };
> +
> pcf8563 at 51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
>
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Benoit Masson <yahoo-+V3Jd3LB6RBWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 7/8] ARM: mvebu: armada-xp: Add I2C eeprom on Lenovo ix4-300d
Date: Sat, 20 Sep 2014 11:55:58 +0200 [thread overview]
Message-ID: <541D4F2E.9020707@gmail.com> (raw)
In-Reply-To: <1411157684-6991-8-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 09/19/2014 10:14 PM, Sebastian Hesselbarth wrote:
> There is an I2C eeprom connected on Lenovo ix4-300d, add the
> corresponding node.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
...
> ---
> arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> index c5ee6c00766c..cef50da88e45 100644
> --- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> @@ -98,6 +98,11 @@
> reg = <0x2e>;
> };
>
> + at24c64@50 {
nit: the node name should describe function, not its type.
@Jason, when you take this in, feel free to name the node eeprom@50
instead.
Sebastian
> + compatible = "atmel,24c64";
> + reg = <0x50>;
> + };
> +
> pcf8563@51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Benoit Masson <yahoo@perenite.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] ARM: mvebu: armada-xp: Add I2C eeprom on Lenovo ix4-300d
Date: Sat, 20 Sep 2014 11:55:58 +0200 [thread overview]
Message-ID: <541D4F2E.9020707@gmail.com> (raw)
In-Reply-To: <1411157684-6991-8-git-send-email-sebastian.hesselbarth@gmail.com>
On 09/19/2014 10:14 PM, Sebastian Hesselbarth wrote:
> There is an I2C eeprom connected on Lenovo ix4-300d, add the
> corresponding node.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
...
> ---
> arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> index c5ee6c00766c..cef50da88e45 100644
> --- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> @@ -98,6 +98,11 @@
> reg = <0x2e>;
> };
>
> + at24c64@50 {
nit: the node name should describe function, not its type.
@Jason, when you take this in, feel free to name the node eeprom@50
instead.
Sebastian
> + compatible = "atmel,24c64";
> + reg = <0x50>;
> + };
> +
> pcf8563@51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
>
next prev parent reply other threads:[~2014-09-20 9:55 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 20:14 [PATCH 0/8] Armada XP pinctrl consolidation and ix4-300d fixes Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 1/8] ARM: mvebu: armada-xp: Consolidate pinctrl node Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:39 ` Thomas Petazzoni
2014-09-19 20:39 ` Thomas Petazzoni
2014-09-19 20:39 ` Thomas Petazzoni
2014-09-19 20:14 ` [PATCH 2/8] ARM: mvebu: armada-xp: Add node alias to pinctrl and add base address Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:40 ` Thomas Petazzoni
2014-09-19 20:40 ` Thomas Petazzoni
2014-09-19 20:40 ` Thomas Petazzoni
2014-09-19 20:14 ` [PATCH 3/8] ARM: mvebu: armada-xp: Use pinctrl node alias Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:42 ` Thomas Petazzoni
2014-09-19 20:42 ` Thomas Petazzoni
2014-09-19 20:14 ` [PATCH 4/8] ARM: mvebu: armada-xp: Move GE0/1 pinctrl settings for RGMII Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 5/8] ARM: mvebu: armada-xp: Add GE0 pinctrl settings for GMII Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 6/8] ARM: mvebu: armada-xp: Add RGMII pinctrl to Lenovo ix4-300d Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 7/8] ARM: mvebu: armada-xp: Add I2C eeprom on " Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-20 9:55 ` Sebastian Hesselbarth [this message]
2014-09-20 9:55 ` Sebastian Hesselbarth
2014-09-20 9:55 ` Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 8/8] ARM: mvebu: armada-xp: Fix 74hc595 count for " Sebastian Hesselbarth
2014-09-19 20:14 ` Sebastian Hesselbarth
2014-09-21 14:11 ` [PATCH 0/8] Armada XP pinctrl consolidation and ix4-300d fixes Benoit Masson
2014-09-21 14:11 ` Benoit Masson
2014-10-03 14:11 ` Jason Cooper
2014-10-03 14:11 ` Jason Cooper
2014-10-03 14:11 ` Jason Cooper
2014-10-03 15:06 ` Sebastian Hesselbarth
2014-10-03 15:06 ` Sebastian Hesselbarth
2014-10-03 15:06 ` Sebastian Hesselbarth
2014-10-03 15:29 ` Benoit Masson
2014-10-03 15:29 ` Benoit Masson
2014-10-03 15:41 ` Sebastian Hesselbarth
2014-10-03 15:41 ` Sebastian Hesselbarth
2014-10-05 23:11 ` Benoit Masson
2014-10-05 23:11 ` Benoit Masson
2014-10-06 7:47 ` Sebastian Hesselbarth
2014-10-06 7:47 ` Sebastian Hesselbarth
2014-10-06 7:47 ` Sebastian Hesselbarth
2014-10-06 8:36 ` Gregory CLEMENT
2014-10-06 8:36 ` Gregory CLEMENT
2014-10-06 8:36 ` Gregory CLEMENT
[not found] ` <BAB12F2D-0142-4362-BA04-59D8E6B16AAE@perenite.com>
2014-10-06 9:14 ` Gregory CLEMENT
2014-10-06 9:14 ` Gregory CLEMENT
2014-10-06 9:14 ` Gregory CLEMENT
2014-10-06 16:13 ` Sebastian Hesselbarth
2014-10-06 16:13 ` Sebastian Hesselbarth
2014-10-15 0:53 ` Benoit Masson
2014-10-15 0:53 ` Benoit Masson
2014-10-15 0:53 ` Benoit Masson
[not found] ` <1CDF8F6B-42FF-4D6A-B52F-6DB270F2673C@perenite.com>
2014-10-15 14:41 ` Andrew Lunn
2014-10-15 14:41 ` Andrew Lunn
2014-10-15 15:35 ` Benoit Masson
2014-10-15 15:35 ` Benoit Masson
2014-10-15 14:42 ` Jason Cooper
2014-10-15 14:42 ` Jason Cooper
2014-10-15 14:49 ` Sebastian Hesselbarth
2014-10-15 14:49 ` Sebastian Hesselbarth
2014-10-15 14:55 ` Andrew Lunn
2014-10-15 14:55 ` Andrew Lunn
2014-10-15 14:55 ` Andrew Lunn
2014-10-15 15:30 ` Jason Cooper
2014-10-15 15:30 ` Jason Cooper
2014-10-15 15:56 ` Jason Cooper
2014-10-15 15:56 ` Jason Cooper
2014-11-01 22:59 ` Jason Cooper
2014-11-01 22:59 ` Jason Cooper
2014-11-01 22:36 ` Jason Cooper
2014-11-01 22:36 ` Jason Cooper
2014-11-01 22:36 ` Jason Cooper
2014-11-01 22:48 ` Sebastian Hesselbarth
2014-11-01 22:48 ` Sebastian Hesselbarth
2014-11-01 22:48 ` Sebastian Hesselbarth
2014-11-02 19:03 ` Jason Cooper
2014-11-02 19:03 ` Jason Cooper
2014-11-02 19:03 ` Jason Cooper
2014-11-02 19:19 ` Sebastian Hesselbarth
2014-11-02 19:19 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541D4F2E.9020707@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.