From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Jean-Michel Hautbois
<jean-michel.hautbois-B+Q8N6RmIDZBDgjK7y7TUQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH] i2c: Add generic support passing secondary devices addresses
Date: Sat, 20 Sep 2014 21:50:51 +0200 [thread overview]
Message-ID: <541DDA9B.40904@metafoo.de> (raw)
In-Reply-To: <20140920164858.GA2260@katana>
On 09/20/2014 06:49 PM, Wolfram Sang wrote:
> On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote:
>> Some I2C devices have multiple addresses assigned, for example each address
>> corresponding to a different internal register map page of the device.
>> So far drivers which need support for this have handled this with a driver
>> specific and non-generic implementation, e.g. passing the additional address
>> via platform data.
>
> This raises the first question for me: Are the additional addresses
> configurable? Sadly, I can't find good documentation for the adv7604.
> Otherwise, if I know I have a adv7604 and know its addresses, this
> information should go into the driver and not the DT.
>
They are. The current driver hard codes the other addresses, but that's not
working when you have multiple adv7604s on the same I2C bus.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Wolfram Sang <wsa@the-dreams.de>,
Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH] i2c: Add generic support passing secondary devices addresses
Date: Sat, 20 Sep 2014 21:50:51 +0200 [thread overview]
Message-ID: <541DDA9B.40904@metafoo.de> (raw)
In-Reply-To: <20140920164858.GA2260@katana>
On 09/20/2014 06:49 PM, Wolfram Sang wrote:
> On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote:
>> Some I2C devices have multiple addresses assigned, for example each address
>> corresponding to a different internal register map page of the device.
>> So far drivers which need support for this have handled this with a driver
>> specific and non-generic implementation, e.g. passing the additional address
>> via platform data.
>
> This raises the first question for me: Are the additional addresses
> configurable? Sadly, I can't find good documentation for the adv7604.
> Otherwise, if I know I have a adv7604 and know its addresses, this
> information should go into the driver and not the DT.
>
They are. The current driver hard codes the other addresses, but that's not
working when you have multiple adv7604s on the same I2C bus.
- Lars
next prev parent reply other threads:[~2014-09-20 19:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:02 [PATCH] i2c: Add generic support passing secondary devices addresses Jean-Michel Hautbois
[not found] ` <1409925739-28188-1-git-send-email-jean-michel.hautbois-B+Q8N6RmIDZBDgjK7y7TUQ@public.gmane.org>
2014-09-20 16:49 ` Wolfram Sang
2014-09-20 16:49 ` Wolfram Sang
2014-09-20 19:50 ` Lars-Peter Clausen [this message]
2014-09-20 19:50 ` Lars-Peter Clausen
[not found] ` <541DDA9B.40904-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-09-21 17:49 ` Wolfram Sang
2014-09-21 17:49 ` Wolfram Sang
2014-09-21 19:23 ` Lars-Peter Clausen
2014-09-21 19:23 ` Lars-Peter Clausen
2014-09-22 10:45 ` Mika Westerberg
2014-09-22 10:45 ` Mika Westerberg
[not found] ` <20140922104555.GQ1786-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-22 13:27 ` Lars-Peter Clausen
2014-09-22 13:27 ` Lars-Peter Clausen
[not found] ` <542023C8.8080802-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-09-22 13:45 ` Mika Westerberg
2014-09-22 13:45 ` Mika Westerberg
2014-09-22 14:11 ` Lars-Peter Clausen
[not found] ` <54202E28.80500-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-09-22 14:41 ` Mika Westerberg
2014-09-22 14:41 ` Mika Westerberg
[not found] ` <20140922144144.GF1786-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-10-03 10:46 ` Wolfram Sang
2014-10-03 10:46 ` Wolfram Sang
2014-10-15 18:54 ` Srinivas Pandruvada
2014-10-15 18:54 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541DDA9B.40904@metafoo.de \
--to=lars-qo5elluwu/uelga04laivw@public.gmane.org \
--cc=jean-michel.hautbois-B+Q8N6RmIDZBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.