From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] i2c-rcar: fix RCAR_IRQ_ACK_{RECV|SEND}
Date: Sun, 21 Sep 2014 21:39:39 +0400 [thread overview]
Message-ID: <541F0D5B.5060707@cogentembedded.com> (raw)
In-Reply-To: <20140920095130.GK1612@katana>
Hello.
On 09/20/2014 01:51 PM, Wolfram Sang wrote:
>> Bits 8-31 of all registers reflect the value of bits 0-7 on reads and should be
>> 0 on writes, according to the manuals. RCAR_IRQ_ACK_{RECV|SEND} macros have all
>> 1's in bits 8-31, thus going against the manuals, so fix them.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Cc: stable@vger.kernel.org
> Applied to for-current, thanks!
Thanks. However, I don't see it in your tree (and neither my cleanups).
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] i2c-rcar: fix RCAR_IRQ_ACK_{RECV|SEND}
Date: Sun, 21 Sep 2014 17:39:39 +0000 [thread overview]
Message-ID: <541F0D5B.5060707@cogentembedded.com> (raw)
In-Reply-To: <20140920095130.GK1612@katana>
Hello.
On 09/20/2014 01:51 PM, Wolfram Sang wrote:
>> Bits 8-31 of all registers reflect the value of bits 0-7 on reads and should be
>> 0 on writes, according to the manuals. RCAR_IRQ_ACK_{RECV|SEND} macros have all
>> 1's in bits 8-31, thus going against the manuals, so fix them.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Cc: stable@vger.kernel.org
> Applied to for-current, thanks!
Thanks. However, I don't see it in your tree (and neither my cleanups).
WBR, Sergei
next prev parent reply other threads:[~2014-09-21 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 23:34 [PATCH] i2c-rcar: fix RCAR_IRQ_ACK_{RECV|SEND} Sergei Shtylyov
2014-09-05 23:34 ` Sergei Shtylyov
[not found] ` <2641177.jdYX8POT82-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2014-09-20 9:51 ` Wolfram Sang
2014-09-20 9:51 ` Wolfram Sang
2014-09-21 17:39 ` Sergei Shtylyov [this message]
2014-09-21 17:39 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541F0D5B.5060707@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.