All of lore.kernel.org
 help / color / mirror / Atom feed
From: kever.yang@rock-chips.com (Kever Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: add initcall to set clk defaults after syscons are available
Date: Mon, 22 Sep 2014 15:56:09 +0800	[thread overview]
Message-ID: <541FD619.3060108@rock-chips.com> (raw)
In-Reply-To: <1566610.B4NH8lpaoI@diego>

Heiko,

On 08/07/2014 08:57 PM, Heiko St?bner wrote:
> PLLs on Rockchip platforms report their locking state in an external
> register situated in the "General Register Files" which is provided
> through a syscon device.
>
> When the initial clk init runs, this syscon is of course not yet
> available, making it impossible to set PLLs to other frequencies
> through the assigned-rate property of the clock-controller node.
>
> Syscon devices are initialized through a postcore initcall, so add an
> arch_initcall to rerun the rockchip specific clock initalization when
> the GRF is available.
>
> As the clock init already runs two times (through of_clk_add_provider
> and of_clk_init), a third time shouldn't hurt to much and in the best
> case wouldn't change any settings at all.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>   drivers/clk/rockchip/clk.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index 9a3adb1..e14b108 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -23,6 +23,7 @@
>   #include <linux/slab.h>
>   #include <linux/clk.h>
>   #include <linux/clk-provider.h>
> +#include <linux/clk/clk-conf.h>
>   #include <linux/mfd/syscon.h>
>   #include <linux/regmap.h>
>   #include "clk.h"
> @@ -126,6 +127,18 @@ void __init rockchip_clk_init(struct device_node *np, void __iomem *base,
>   	of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data);
>   }
>   
> +/**
> + * Set clock-defaults again, after grf regmap is available for PLLs.
> + */
> +static int __init rockchip_clk_set_defaults(void)
> +{
> +	if (cru_node)
> +		return of_clk_set_defaults(cru_node, true);
> +
> +	return 0;
> +}
> +arch_initcall(rockchip_clk_set_defaults);
> +
>   struct regmap *rockchip_clk_get_grf(void)
>   {
>   	if (IS_ERR(grf))
This patch works on my rk3288 evb, so,
Tested-by: Kever Yang <kever.yang@rock-chips.com>

WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>,
	"Mike Turquette" <mturquette@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: rockchip: add initcall to set clk defaults after syscons are available
Date: Mon, 22 Sep 2014 15:56:09 +0800	[thread overview]
Message-ID: <541FD619.3060108@rock-chips.com> (raw)
In-Reply-To: <1566610.B4NH8lpaoI@diego>

Heiko,

On 08/07/2014 08:57 PM, Heiko Stübner wrote:
> PLLs on Rockchip platforms report their locking state in an external
> register situated in the "General Register Files" which is provided
> through a syscon device.
>
> When the initial clk init runs, this syscon is of course not yet
> available, making it impossible to set PLLs to other frequencies
> through the assigned-rate property of the clock-controller node.
>
> Syscon devices are initialized through a postcore initcall, so add an
> arch_initcall to rerun the rockchip specific clock initalization when
> the GRF is available.
>
> As the clock init already runs two times (through of_clk_add_provider
> and of_clk_init), a third time shouldn't hurt to much and in the best
> case wouldn't change any settings at all.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>   drivers/clk/rockchip/clk.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index 9a3adb1..e14b108 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -23,6 +23,7 @@
>   #include <linux/slab.h>
>   #include <linux/clk.h>
>   #include <linux/clk-provider.h>
> +#include <linux/clk/clk-conf.h>
>   #include <linux/mfd/syscon.h>
>   #include <linux/regmap.h>
>   #include "clk.h"
> @@ -126,6 +127,18 @@ void __init rockchip_clk_init(struct device_node *np, void __iomem *base,
>   	of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data);
>   }
>   
> +/**
> + * Set clock-defaults again, after grf regmap is available for PLLs.
> + */
> +static int __init rockchip_clk_set_defaults(void)
> +{
> +	if (cru_node)
> +		return of_clk_set_defaults(cru_node, true);
> +
> +	return 0;
> +}
> +arch_initcall(rockchip_clk_set_defaults);
> +
>   struct regmap *rockchip_clk_get_grf(void)
>   {
>   	if (IS_ERR(grf))
This patch works on my rk3288 evb, so,
Tested-by: Kever Yang <kever.yang@rock-chips.com>


  reply	other threads:[~2014-09-22  7:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07 12:57 [PATCH] clk: rockchip: add initcall to set clk defaults after syscons are available Heiko Stübner
2014-08-07 12:57 ` Heiko Stübner
2014-09-22  7:56 ` Kever Yang [this message]
2014-09-22  7:56   ` Kever Yang
2014-09-24 20:21 ` Doug Anderson
2014-09-24 20:21   ` Doug Anderson
2014-09-24 20:27   ` Heiko Stübner
2014-09-24 20:27     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541FD619.3060108@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.