From: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Michal Simek
<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] i2c: cadence: Remove .owner field for driver
Date: Mon, 22 Sep 2014 11:36:53 +0200 [thread overview]
Message-ID: <541FEDB5.7050305@monstr.eu> (raw)
In-Reply-To: <20140920091106.GB1612@katana>
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
On 09/20/2014 11:11 AM, Wolfram Sang wrote:
> On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
>> There is no need to init .owner field.
>>
>> Based on the patch from Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> "mmc: remove .owner field for drivers using module_platform_driver"
^
this shouldn't be there.
>>
>> This patch removes the superflous .owner field for drivers which
>
> It says drivers, but does only one...
I have c&p this from Peter's description that's why there are just drivers.
>
>> use the module_platform_driver API, as this is overriden in
>> platform_driver_register anyway."
>
> ... so: any interest in doing this for the whole subsystem? Basically
> good catch, though.
Mark was also interested about doing this for spi. Doing this for the whole
kernel will be the best. coccinelle script
is good option I have never played with it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] i2c: cadence: Remove .owner field for driver
Date: Mon, 22 Sep 2014 11:36:53 +0200 [thread overview]
Message-ID: <541FEDB5.7050305@monstr.eu> (raw)
In-Reply-To: <20140920091106.GB1612@katana>
On 09/20/2014 11:11 AM, Wolfram Sang wrote:
> On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
>> There is no need to init .owner field.
>>
>> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
>> "mmc: remove .owner field for drivers using module_platform_driver"
^
this shouldn't be there.
>>
>> This patch removes the superflous .owner field for drivers which
>
> It says drivers, but does only one...
I have c&p this from Peter's description that's why there are just drivers.
>
>> use the module_platform_driver API, as this is overriden in
>> platform_driver_register anyway."
>
> ... so: any interest in doing this for the whole subsystem? Basically
> good catch, though.
Mark was also interested about doing this for spi. Doing this for the whole
kernel will be the best. coccinelle script
is good option I have never played with it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140922/9088a705/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@monstr.eu>
To: Wolfram Sang <wsa@the-dreams.de>, Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: cadence: Remove .owner field for driver
Date: Mon, 22 Sep 2014 11:36:53 +0200 [thread overview]
Message-ID: <541FEDB5.7050305@monstr.eu> (raw)
In-Reply-To: <20140920091106.GB1612@katana>
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
On 09/20/2014 11:11 AM, Wolfram Sang wrote:
> On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
>> There is no need to init .owner field.
>>
>> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
>> "mmc: remove .owner field for drivers using module_platform_driver"
^
this shouldn't be there.
>>
>> This patch removes the superflous .owner field for drivers which
>
> It says drivers, but does only one...
I have c&p this from Peter's description that's why there are just drivers.
>
>> use the module_platform_driver API, as this is overriden in
>> platform_driver_register anyway."
>
> ... so: any interest in doing this for the whole subsystem? Basically
> good catch, though.
Mark was also interested about doing this for spi. Doing this for the whole
kernel will be the best. coccinelle script
is good option I have never played with it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-09-22 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 11:56 [PATCH 1/2] i2c: cadence: Remove .owner field for driver Michal Simek
2014-08-13 11:56 ` Michal Simek
2014-08-13 11:56 ` [PATCH 2/2] i2c: i2c-xiic: " Michal Simek
[not found] ` <c076984af7e65c433fdfd3a3b0f8d20da2c18013.1407931005.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2014-09-20 9:11 ` [PATCH 1/2] i2c: cadence: " Wolfram Sang
2014-09-20 9:11 ` Wolfram Sang
2014-09-20 9:11 ` Wolfram Sang
2014-09-22 9:36 ` Michal Simek [this message]
2014-09-22 9:36 ` Michal Simek
2014-09-22 9:36 ` Michal Simek
2014-11-07 18:15 ` Wolfram Sang
2014-11-07 18:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541FEDB5.7050305@monstr.eu \
--to=monstr-psz03upnqpehxe+lvdladg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.