From: Rik van Riel <riel@redhat.com>
To: Andres Lagar-Cavilla <andreslc@google.com>,
Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Feiner <pfeiner@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: Andres Lagar-Cavilla <andreslc@gooogle.com>
Subject: Re: [PATCH] kvm: Fix page ageing bugs
Date: Mon, 22 Sep 2014 16:18:42 -0400 [thread overview]
Message-ID: <54208422.8010209@redhat.com> (raw)
In-Reply-To: <1411415878-30346-1-git-send-email-andreslc@google.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/22/2014 03:57 PM, Andres Lagar-Cavilla wrote:
> 1. We were calling clear_flush_young_notify in unmap_one, but we
> are within an mmu notifier invalidate range scope. The spte exists
> no more (due to range_start) and the accessed bit info has already
> been propagated (due to kvm_pfn_set_accessed). Simply call
> clear_flush_young.
>
> 2. We clear_flush_young on a primary MMU PMD, but this may be
> mapped as a collection of PTEs by the secondary MMU (e.g. during
> log-dirty). This required expanding the interface of the
> clear_flush_young mmu notifier, so a lot of code has been trivially
> touched.
>
> 3. In the absence of shadow_accessed_mask (e.g. EPT A bit), we
> emulate the access bit by blowing the spte. This requires proper
> synchronizing with MMU notifier consumers, like every other removal
> of spte's does.
Acked-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUIIQiAAoJEM553pKExN6DWeoH/RpkYF1QCxnbxgZhnioaWjyu
Rp/kN6Rck6Eu3k/yRI6k+8IhgUJWkVhSXybTIDl1X6aVGgYwhaeOv2zPPfshfM6h
ABE3pLFjs2qtdotZXFSvZ4mNwbQE73YHphAbmFUBSdm2Oz1bj6Qfq+KYFdM+aQd7
UYIFgtdGg/tyLMqE25J7pAnSDRR5GKmAKLvkFjN3Q8O4ynD3rExH1yTMLtQbyKvb
oadSzaQLBOkLDAj3rpiOTl52B2tlQS+cxWqEfzA/AXOK8TkllDKIQT5BeRXV5O1c
/WsZmusiA6KYgjLxnL0K9XJpgpOQ5unYAFyIGgYmKiaN6PQsd+pGM5GDnOWGorE=
=dftO
-----END PGP SIGNATURE-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Andres Lagar-Cavilla <andreslc@google.com>,
Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Feiner <pfeiner@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: Andres Lagar-Cavilla <andreslc@gooogle.com>
Subject: Re: [PATCH] kvm: Fix page ageing bugs
Date: Mon, 22 Sep 2014 16:18:42 -0400 [thread overview]
Message-ID: <54208422.8010209@redhat.com> (raw)
In-Reply-To: <1411415878-30346-1-git-send-email-andreslc@google.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/22/2014 03:57 PM, Andres Lagar-Cavilla wrote:
> 1. We were calling clear_flush_young_notify in unmap_one, but we
> are within an mmu notifier invalidate range scope. The spte exists
> no more (due to range_start) and the accessed bit info has already
> been propagated (due to kvm_pfn_set_accessed). Simply call
> clear_flush_young.
>
> 2. We clear_flush_young on a primary MMU PMD, but this may be
> mapped as a collection of PTEs by the secondary MMU (e.g. during
> log-dirty). This required expanding the interface of the
> clear_flush_young mmu notifier, so a lot of code has been trivially
> touched.
>
> 3. In the absence of shadow_accessed_mask (e.g. EPT A bit), we
> emulate the access bit by blowing the spte. This requires proper
> synchronizing with MMU notifier consumers, like every other removal
> of spte's does.
Acked-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUIIQiAAoJEM553pKExN6DWeoH/RpkYF1QCxnbxgZhnioaWjyu
Rp/kN6Rck6Eu3k/yRI6k+8IhgUJWkVhSXybTIDl1X6aVGgYwhaeOv2zPPfshfM6h
ABE3pLFjs2qtdotZXFSvZ4mNwbQE73YHphAbmFUBSdm2Oz1bj6Qfq+KYFdM+aQd7
UYIFgtdGg/tyLMqE25J7pAnSDRR5GKmAKLvkFjN3Q8O4ynD3rExH1yTMLtQbyKvb
oadSzaQLBOkLDAj3rpiOTl52B2tlQS+cxWqEfzA/AXOK8TkllDKIQT5BeRXV5O1c
/WsZmusiA6KYgjLxnL0K9XJpgpOQ5unYAFyIGgYmKiaN6PQsd+pGM5GDnOWGorE=
=dftO
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-09-22 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 19:57 [PATCH] kvm: Fix page ageing bugs Andres Lagar-Cavilla
2014-09-22 19:57 ` Andres Lagar-Cavilla
2014-09-22 20:18 ` Rik van Riel [this message]
2014-09-22 20:18 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2014-09-22 18:34 Andres Lagar-Cavilla
2014-09-22 18:34 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54208422.8010209@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreslc@google.com \
--cc=andreslc@gooogle.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.