From: Paolo Bonzini <pbonzini@redhat.com>
To: Andres Lagar-Cavilla <andreslc@google.com>,
Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Feiner <pfeiner@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: Andres Lagar-Cavilla <andreslc@gooogle.com>
Subject: Re: [PATCH v3] kvm: Fix page ageing bugs
Date: Mon, 22 Sep 2014 23:48:12 +0200 [thread overview]
Message-ID: <5420991C.2000400@redhat.com> (raw)
In-Reply-To: <1411417565-15748-1-git-send-email-andreslc@google.com>
Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto:
> + __entry->gfn = gfn;
> + __entry->hva = ((gfn - slot->base_gfn) >>
This must be <<.
> + PAGE_SHIFT) + slot->userspace_addr;
> + /*
> + * No need for _notify because we're called within an
> + * mmu_notifier_invalidate_range_ {start|end} scope.
> + */
Why "called within"? It is try_to_unmap_cluster itself that calls
mmu_notifier_invalidate_range_*, so "we're within an
mmu_notifier_invalidate_range_start/end scope" sounds better, and it's
also what you use in the commit message.
Paolo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andres Lagar-Cavilla <andreslc@google.com>,
Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Feiner <pfeiner@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: Andres Lagar-Cavilla <andreslc@gooogle.com>
Subject: Re: [PATCH v3] kvm: Fix page ageing bugs
Date: Mon, 22 Sep 2014 23:48:12 +0200 [thread overview]
Message-ID: <5420991C.2000400@redhat.com> (raw)
In-Reply-To: <1411417565-15748-1-git-send-email-andreslc@google.com>
Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto:
> + __entry->gfn = gfn;
> + __entry->hva = ((gfn - slot->base_gfn) >>
This must be <<.
> + PAGE_SHIFT) + slot->userspace_addr;
> + /*
> + * No need for _notify because we're called within an
> + * mmu_notifier_invalidate_range_ {start|end} scope.
> + */
Why "called within"? It is try_to_unmap_cluster itself that calls
mmu_notifier_invalidate_range_*, so "we're within an
mmu_notifier_invalidate_range_start/end scope" sounds better, and it's
also what you use in the commit message.
Paolo
next prev parent reply other threads:[~2014-09-22 21:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 18:34 [PATCH] kvm: Fix page ageing bugs Andres Lagar-Cavilla
2014-09-22 18:34 ` Andres Lagar-Cavilla
2014-09-22 20:00 ` [PATCH v2] " Andres Lagar-Cavilla
2014-09-22 20:00 ` Andres Lagar-Cavilla
2014-09-22 20:26 ` [PATCH v3] " Andres Lagar-Cavilla
2014-09-22 20:26 ` Andres Lagar-Cavilla
2014-09-22 21:48 ` Paolo Bonzini [this message]
2014-09-22 21:48 ` Paolo Bonzini
2014-09-22 21:54 ` Andres Lagar-Cavilla
2014-09-22 21:54 ` Andres Lagar-Cavilla
2014-09-22 21:54 ` [PATCH v4] " Andres Lagar-Cavilla
2014-09-22 21:54 ` Andres Lagar-Cavilla
2014-09-23 7:49 ` Paolo Bonzini
2014-09-23 7:49 ` Paolo Bonzini
2014-09-23 17:04 ` Andres Lagar-Cavilla
2014-09-23 17:04 ` Andres Lagar-Cavilla
2014-09-23 17:05 ` Paolo Bonzini
2014-09-23 17:05 ` Paolo Bonzini
2014-09-24 2:27 ` Wanpeng Li
2014-09-24 2:27 ` Wanpeng Li
2014-09-24 7:04 ` Paolo Bonzini
2014-09-24 7:04 ` Paolo Bonzini
2014-09-24 7:20 ` Wanpeng Li
2014-09-24 7:20 ` Wanpeng Li
2014-09-24 7:20 ` Wanpeng Li
2014-09-24 8:27 ` Paolo Bonzini
2014-09-24 8:27 ` Paolo Bonzini
2014-09-24 17:17 ` Andres Lagar-Cavilla
2014-09-24 17:17 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5420991C.2000400@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreslc@google.com \
--cc=andreslc@gooogle.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pfeiner@google.com \
--cc=riel@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.