Rate ctrl problem with 2x2 station.

Rate ctrl problem with 2x2 station.

[Ben Greear]

While testing the previously posted patches that fix up the
transmit rate for 3x3 NICs configured for 2x2 chainmask, I
noticed that an ath10k configured as 3x3 AP will use only
1x1 rates when transmitting to a 2x2 station.

From debugging so far, it appears the root cause is that
the method ath10k_peer_assoc_h_ht in mac.c is passed an
sta with rx_nss set to 3, when in fact the station *should*
be showing up as 2x2.

Possibly station system is still messed up some how...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Rate ctrl problem with 2x2 station.

[Michal Kazior]

On 23 September 2014 02:20, Ben Greear <greearb@candelatech.com> wrote:
> While testing the previously posted patches that fix up the
> transmit rate for 3x3 NICs configured for 2x2 chainmask, I
> noticed that an ath10k configured as 3x3 AP will use only
> 1x1 rates when transmitting to a 2x2 station.
>
> From debugging so far, it appears the root cause is that
> the method ath10k_peer_assoc_h_ht in mac.c is passed an
> sta with rx_nss set to 3, when in fact the station *should*
> be showing up as 2x2.
>
> Possibly station system is still messed up some how...

Am I understanding correctly that the 2x2 station is just a 3x3 ath10k
device with "tx/rx_chainmask" being set to 0x3? If so then rx_nss
being 3 is okay because setting chainmasks does not affect advertised
capabilities and association sequences remain unaffected.

The problem might be  the hw rate control is unable to deal with the
strange chainmask setup. Did you try 10.2? I've been told it contains
some rate control improvements.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Rate ctrl problem with 2x2 station.

[Ben Greear]

On 09/23/2014 01:43 AM, Michal Kazior wrote:
> On 23 September 2014 02:20, Ben Greear <greearb@candelatech.com> wrote:
>> While testing the previously posted patches that fix up the
>> transmit rate for 3x3 NICs configured for 2x2 chainmask, I
>> noticed that an ath10k configured as 3x3 AP will use only
>> 1x1 rates when transmitting to a 2x2 station.
>>
>> From debugging so far, it appears the root cause is that
>> the method ath10k_peer_assoc_h_ht in mac.c is passed an
>> sta with rx_nss set to 3, when in fact the station *should*
>> be showing up as 2x2.
>>
>> Possibly station system is still messed up some how...
> 
> Am I understanding correctly that the 2x2 station is just a 3x3 ath10k
> device with "tx/rx_chainmask" being set to 0x3? If so then rx_nss
> being 3 is okay because setting chainmasks does not affect advertised
> capabilities and association sequences remain unaffected.

I was thinking the peer's rx-nss would be what the peer (ie, station)
can receive from the AP?  If so, then it should be 2 in this case
since that is what the station is (or should be) advertising.

> The problem might be  the hw rate control is unable to deal with the
> strange chainmask setup. Did you try 10.2? I've been told it contains
> some rate control improvements.

It could easily be the hw rate control, but I will try to work around
it in the driver, as it is very likely 10.1 has same issue as my
firmware.  Certainly my 10.1 based firmware craps out if nss does
not match reality (see previously posted patches).  Looks like same
general problem on the AP side.

I have not tried 10.2, the latest snapshot I can get is from last
December, so it does not appear anyone is actively working on it,
and if it took 8 months to get into the ath10k driver, it must not be
obviously better??

I will take a look at the difference between 10.2 and 10.1 and
try to merge them into my tree when I get a chance.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Rate ctrl problem with 2x2 station.

[Avery Pennarun]

On Tue, Sep 23, 2014 at 12:02 PM, Ben Greear <greearb@candelatech.com> wrote:
> I have not tried 10.2, the latest snapshot I can get is from last
> December, so it does not appear anyone is actively working on it,
> and if it took 8 months to get into the ath10k driver, it must not be
> obviously better??

We tried the 10.2 firmware.  It definitely fixes some bugs that we've
run into (packet corruption), but it adds some even worse ones
(unexplained firmware crashes).

Certainly you could try the new firmware and see if your particular
bug is fixed.  But I also wouldn't say it's ready for prime time.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k