All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Brian Norris <computersforpeace@gmail.com>,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in
Date: Tue, 23 Sep 2014 11:51:25 +0300	[thread overview]
Message-ID: <5421348D.90606@ti.com> (raw)
In-Reply-To: <20140922185849.GT1193@ld-irv-0074>

On 09/22/2014 09:58 PM, Brian Norris wrote:
> On Sat, Sep 20, 2014 at 05:53:16PM +0100, Ezequiel Garcia wrote:
>> This fixes the following build error when omap2_nand is chosen built-in,
>> and omap_elm is chosen as a module:
>>
>>   drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
>>   drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
>>   drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
>>   drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>>
>> Fix this by making omap_elm a 'bool' driver.
> 
> Hmm, so we're sacrificing a "feature" (that omap2 + omap_elm can both be
> built as modules) because we haven't solved one particular developer UI
> inconsistency (that we don't prevent the config combination of
> MTD_NAND_OMAP2=y and MTD_NAND_OMAP_BCH=m)? I wouldn't tend to sacrifice
> the feature for the sake of a bad config.
> 
> Do you have any guesstimate as to whether the linker failure affects
> many people? Are people just hitting this with randconfig?

I think this issue was hit only during a manual menuconfig setting.

> 
> Do you know if anyone ships loadable modules for this driver? e.g., any
> embedded distros?

Not sure about other distros but TI releases always set both
OMAP_NAND and OMAP_BCH as built-in.


cheers,
-roger

> 
> I could go either way on this, but I just wasn't sure if these sorts of
> questions had been asked/answered.
> 
>> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
>> ---
>>  drivers/mtd/nand/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index f1cf503..549c0cb 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -96,7 +96,7 @@ config MTD_NAND_OMAP2
>>  
>>  config MTD_NAND_OMAP_BCH
>>  	depends on MTD_NAND_OMAP2
>> -	tristate "Support hardware based BCH error correction"
>> +	bool "Support hardware based BCH error correction"
>>  	default n
>>  	select BCH
>>  	help
> 
> Brian
> 

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Brian Norris <computersforpeace@gmail.com>,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in
Date: Tue, 23 Sep 2014 11:51:25 +0300	[thread overview]
Message-ID: <5421348D.90606@ti.com> (raw)
In-Reply-To: <20140922185849.GT1193@ld-irv-0074>

On 09/22/2014 09:58 PM, Brian Norris wrote:
> On Sat, Sep 20, 2014 at 05:53:16PM +0100, Ezequiel Garcia wrote:
>> This fixes the following build error when omap2_nand is chosen built-in,
>> and omap_elm is chosen as a module:
>>
>>   drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
>>   drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
>>   drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
>>   drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>>
>> Fix this by making omap_elm a 'bool' driver.
> 
> Hmm, so we're sacrificing a "feature" (that omap2 + omap_elm can both be
> built as modules) because we haven't solved one particular developer UI
> inconsistency (that we don't prevent the config combination of
> MTD_NAND_OMAP2=y and MTD_NAND_OMAP_BCH=m)? I wouldn't tend to sacrifice
> the feature for the sake of a bad config.
> 
> Do you have any guesstimate as to whether the linker failure affects
> many people? Are people just hitting this with randconfig?

I think this issue was hit only during a manual menuconfig setting.

> 
> Do you know if anyone ships loadable modules for this driver? e.g., any
> embedded distros?

Not sure about other distros but TI releases always set both
OMAP_NAND and OMAP_BCH as built-in.


cheers,
-roger

> 
> I could go either way on this, but I just wasn't sure if these sorts of
> questions had been asked/answered.
> 
>> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
>> ---
>>  drivers/mtd/nand/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index f1cf503..549c0cb 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -96,7 +96,7 @@ config MTD_NAND_OMAP2
>>  
>>  config MTD_NAND_OMAP_BCH
>>  	depends on MTD_NAND_OMAP2
>> -	tristate "Support hardware based BCH error correction"
>> +	bool "Support hardware based BCH error correction"
>>  	default n
>>  	select BCH
>>  	help
> 
> Brian
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2014-09-23  8:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-20 16:53 [PATCH v4 0/5] nand: OMAP collected fixes Ezequiel Garcia
2014-09-20 16:53 ` Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 1/5] nand: omap2: Remove horrible ifdefs to fix module probe Ezequiel Garcia
2014-09-20 16:53   ` Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 2/5] nand: omap2: Replace pr_err with dev_err Ezequiel Garcia
2014-09-20 16:53   ` Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 3/5] mtd: nand: Move ELM driver and rename as omap_elm Ezequiel Garcia
2014-09-20 16:53   ` Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 4/5] mtd: nand: Rename OMAP NAND driver Ezequiel Garcia
2014-09-20 16:53   ` Ezequiel Garcia
2014-09-22 18:49   ` Brian Norris
2014-09-22 18:49     ` Brian Norris
2014-09-20 16:53 ` [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in Ezequiel Garcia
2014-09-20 16:53   ` Ezequiel Garcia
2014-09-22  8:17   ` Roger Quadros
2014-09-22  8:17     ` Roger Quadros
2014-09-22 18:58   ` Brian Norris
2014-09-22 18:58     ` Brian Norris
2014-09-22 19:15     ` Ezequiel Garcia
2014-09-22 19:15       ` Ezequiel Garcia
2014-09-23  8:51     ` Roger Quadros [this message]
2014-09-23  8:51       ` Roger Quadros
2014-09-22  8:22 ` [PATCH v4 0/5] nand: OMAP collected fixes Roger Quadros
2014-09-22  8:22   ` Roger Quadros
2014-09-22 12:51   ` Ezequiel Garcia
2014-09-22 12:51     ` Ezequiel Garcia
2014-09-22 15:13     ` Roger Quadros
2014-09-22 15:13       ` Roger Quadros
2014-09-22 18:42 ` Brian Norris
2014-09-22 18:42   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5421348D.90606@ti.com \
    --to=rogerq@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.