From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
Josh Cartwright <joshc@codeaurora.org>
Subject: Re: [PATCH] rtc: pm8xxx: rework to support pm8941 rtc
Date: Tue, 23 Sep 2014 12:02:00 +0300 [thread overview]
Message-ID: <54213708.7050605@mm-sol.com> (raw)
In-Reply-To: <20140919160347.eaa72f4b715338e4210790df@linux-foundation.org>
On 09/20/2014 02:03 AM, Andrew Morton wrote:
> On Fri, 12 Sep 2014 12:44:04 +0300 Stanimir Varbanov <svarbanov@mm-sol.com> wrote:
>
>> Adds support for RTC device inside PM8941 PMIC. The RTC
>> in this PMIC have two register spaces. Thus the rtc-pm8xxx
>> is slightly reworked to reflect these differences.
>>
>> The register set for different PMIC chips are selected
>> on DT compatible string base.
>
> checkpatch (which you obviously didn't use!) says
>
> WARNING: DT compatible string "qcom,pm8941-rtc" appears un-documented -- check ./Documentation/devicetree/bindings/
> #414: FILE: drivers/rtc/rtc-pm8xxx.c:435:
> + { .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
Ahh, sorry for inconvenience I forgot to run checkpatch over this patch.
I will send follow-up patch which will add the compatible string in the
pm8xxx binding document.
--
regards,
Stan
next prev parent reply other threads:[~2014-09-23 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 9:44 [PATCH] rtc: pm8xxx: rework to support pm8941 rtc Stanimir Varbanov
2014-09-19 23:03 ` Andrew Morton
2014-09-23 9:02 ` Stanimir Varbanov [this message]
2014-09-23 8:50 ` Paul Bolle
2014-09-23 9:56 ` Stanimir Varbanov
2014-09-24 10:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54213708.7050605@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=joshc@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.