From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: use configured nss instead of max nss.
Date: Tue, 23 Sep 2014 09:48:12 -0700 [thread overview]
Message-ID: <5421A44C.8080307@candelatech.com> (raw)
In-Reply-To: <CA+BoTQn9sECMNZsxQpB4i3wHPxfVL+LXq9=2GBd-opH6+9TD=A@mail.gmail.com>
On 09/23/2014 01:59 AM, Michal Kazior wrote:
> On 23 September 2014 01:00, <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> When re-associating a station, the nss was set back to
>> maximum value even if user had configured small number
>> of tx chains. So, pay attention to user's config in
>> this case as well.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 855c71c..c5d31cc 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -4086,6 +4086,10 @@ ath10k_default_bitrate_mask(struct ath10k *ar,
>> u32 legacy = 0x00ff;
>> u8 ht = 0xff, i;
>> u16 vht = 0x3ff;
>> + u16 nrf = ar->num_rf_chains;
>> +
>> + if (ar->cfg_tx_chainmask)
>> + nrf = get_nss_from_chainmask(ar->cfg_tx_chainmask);
>
> Oh, so you do update the peer nss value here.
Yeah, I found this was needed in further testing yesterday...
> I think it might be a good idea to convey the limitation of tx/rx
> chainmask to the user: you can't change the tx/rx chainmask on the fly
> easily (while connected/have associated stations). Or do you plan to
> schedule peer reassoc in __ath10k_set_antenna() in a follow up
> patch(es) later?
My user-space tools assume you have to re-connect (requested from user-space)
after changing the chainmask. I was under the impression that this
is how ath9k works, though I could be wrong.
I would rather keep this requirement in user-space...
I am not sure where to document this...just a comment in the code?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: use configured nss instead of max nss.
Date: Tue, 23 Sep 2014 09:48:12 -0700 [thread overview]
Message-ID: <5421A44C.8080307@candelatech.com> (raw)
In-Reply-To: <CA+BoTQn9sECMNZsxQpB4i3wHPxfVL+LXq9=2GBd-opH6+9TD=A@mail.gmail.com>
On 09/23/2014 01:59 AM, Michal Kazior wrote:
> On 23 September 2014 01:00, <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> When re-associating a station, the nss was set back to
>> maximum value even if user had configured small number
>> of tx chains. So, pay attention to user's config in
>> this case as well.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 855c71c..c5d31cc 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -4086,6 +4086,10 @@ ath10k_default_bitrate_mask(struct ath10k *ar,
>> u32 legacy = 0x00ff;
>> u8 ht = 0xff, i;
>> u16 vht = 0x3ff;
>> + u16 nrf = ar->num_rf_chains;
>> +
>> + if (ar->cfg_tx_chainmask)
>> + nrf = get_nss_from_chainmask(ar->cfg_tx_chainmask);
>
> Oh, so you do update the peer nss value here.
Yeah, I found this was needed in further testing yesterday...
> I think it might be a good idea to convey the limitation of tx/rx
> chainmask to the user: you can't change the tx/rx chainmask on the fly
> easily (while connected/have associated stations). Or do you plan to
> schedule peer reassoc in __ath10k_set_antenna() in a follow up
> patch(es) later?
My user-space tools assume you have to re-connect (requested from user-space)
after changing the chainmask. I was under the impression that this
is how ath9k works, though I could be wrong.
I would rather keep this requirement in user-space...
I am not sure where to document this...just a comment in the code?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-09-23 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 23:00 [PATCH] ath10k: use configured nss instead of max nss greearb
2014-09-22 23:00 ` greearb
2014-09-23 8:59 ` Michal Kazior
2014-09-23 8:59 ` Michal Kazior
2014-09-23 16:48 ` Ben Greear [this message]
2014-09-23 16:48 ` Ben Greear
2014-09-24 7:09 ` Michal Kazior
2014-09-24 7:09 ` Michal Kazior
2014-09-24 16:09 ` Ben Greear
2014-09-24 16:09 ` Ben Greear
2014-09-25 6:16 ` Michal Kazior
2014-09-25 6:16 ` Michal Kazior
2014-09-25 13:22 ` Ben Greear
2014-09-25 13:22 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5421A44C.8080307@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.