From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Andy Gross <agross@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
arm@kernel.org, Kevin Hilman <khilman@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] soc: qcom: do not disable the iface clock in probe
Date: Tue, 23 Sep 2014 19:41:11 +0100 [thread overview]
Message-ID: <5421BEC7.60003@linaro.org> (raw)
In-Reply-To: <A61C4CA5-7558-4B3D-BF05-BBDD1C3F550F@codeaurora.org>
On 23/09/14 18:42, Kumar Gala wrote:
>
> On Aug 15, 2014, at 12:41 AM, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote:
>
>> The use case here is when we have a bootconsole which is printing the
>> characters on serial console and gsbi driver comes up after some time.
>> As gsbi driver disables the clock in probe the bootconsole locks up.
>>
>> This patch fixes the problem by disabling the clock in platform remove
>> rather than in probe.
>>
>> Tested-by: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> Changes since RFC:
>> - none, just a subject line change.
>
> Srini,
>
> We need some changes to the commit message for this to get into v3.17.
>
Sure.. I will send v2 with change log referring to
http://www.spinics.net/lists/linux-arm-msm/msg10589.html
--srini
> Probably some references to:
>
> http://www.spinics.net/lists/linux-arm-msm/msg10589.html
>
> Adding Kevin to provide details on what else should be in commit message w/regards to the regression we introduced.
>
> - k
>
WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] soc: qcom: do not disable the iface clock in probe
Date: Tue, 23 Sep 2014 19:41:11 +0100 [thread overview]
Message-ID: <5421BEC7.60003@linaro.org> (raw)
In-Reply-To: <A61C4CA5-7558-4B3D-BF05-BBDD1C3F550F@codeaurora.org>
On 23/09/14 18:42, Kumar Gala wrote:
>
> On Aug 15, 2014, at 12:41 AM, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote:
>
>> The use case here is when we have a bootconsole which is printing the
>> characters on serial console and gsbi driver comes up after some time.
>> As gsbi driver disables the clock in probe the bootconsole locks up.
>>
>> This patch fixes the problem by disabling the clock in platform remove
>> rather than in probe.
>>
>> Tested-by: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> Changes since RFC:
>> - none, just a subject line change.
>
> Srini,
>
> We need some changes to the commit message for this to get into v3.17.
>
Sure.. I will send v2 with change log referring to
http://www.spinics.net/lists/linux-arm-msm/msg10589.html
--srini
> Probably some references to:
>
> http://www.spinics.net/lists/linux-arm-msm/msg10589.html
>
> Adding Kevin to provide details on what else should be in commit message w/regards to the regression we introduced.
>
> - k
>
next prev parent reply other threads:[~2014-09-23 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 5:41 [PATCH v1] soc: qcom: do not disable the iface clock in probe Srinivas Kandagatla
2014-09-23 17:42 ` Kumar Gala
2014-09-23 17:42 ` Kumar Gala
2014-09-23 17:51 ` Kevin Hilman
2014-09-23 17:51 ` Kevin Hilman
2014-09-23 18:41 ` Srinivas Kandagatla [this message]
2014-09-23 18:41 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5421BEC7.60003@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@codeaurora.org \
--cc=arm@kernel.org \
--cc=galak@codeaurora.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.