From: Frank Schäfer <fschaefer.oss@googlemail.com>
To: lkp@lists.01.org
Subject: Re: [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)
Date: Tue, 23 Sep 2014 18:52:12 +0000 [thread overview]
Message-ID: <5421C187.2070407@googlemail.com> (raw)
In-Reply-To: <541C8A26.6050207@ventoso.org>
[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]
Am 19.09.2014 um 21:55 schrieb Luca Olivetti:
> El 19/09/14 21:22, Frank Schäfer ha escrit:
>
>>> So symbol_request() returns pointers.!= NULL
>>>
>>> A closer look at the definition of symbol_request() shows, that it does
>>> nothing if CONFIG_MODULES is disabled (it just returns its argument).
>>>
>>>
>>> One possibility to fix this bug would be to embrace these three lines with
>>>
>>> #ifdef CONFIG_DVB_USB_AF9005_REMOTE
>>> ...
>>> #endif
>> Luca, what do you think ?
>>
>> This seems to be an ancient bug, which is known at least since 5 1/2 years:
>> https://lkml.org/lkml/2009/2/4/350
> Well, it's been a while so I don't remember the details, but I think the
> same now as then ;-)
> The idea behind CONFIG_DVB_USB_AF9005_REMOTE was to provide an
> alternative implementation (based on lirc, at the time it wasn't in the
> kernel), since this adapter doesn't decode the IR pulses by itself.
> In theory you could leave it undefined but still provide an
> implementation in a different module. Just adding
>
> #ifdef CONFIG_DVB_USB_AF9005_REMOTE
>
> would nuke the (futile?) effort.
>
> Now, since the problem seems to be with CONFIG_MODULES disabled, maybe
> you could combine both conditions
>
> #if defined(CONFIG_MODULE) || defined(CONFIG_DVB_USB_AF9005_REMOTE)
What happens, if CONFIG_MODULES is enabled, but neither module
af9005-remote nor any other IR module is available ?
Has this ever been tested ?
Regards,
Frank
WARNING: multiple messages have this Message-ID (diff)
From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Luca Olivetti <luca@ventoso.org>, Fengguang Wu <fengguang.wu@intel.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, Jet Chen <jet.chen@intel.com>,
Su Tao <tao.su@intel.com>, Yuanhan Liu <yuanhan.liu@intel.com>,
LKP <lkp@01.org>,
linux-kernel@vger.kernel.org, crope@iki.fi
Subject: Re: [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)
Date: Tue, 23 Sep 2014 20:52:55 +0200 [thread overview]
Message-ID: <5421C187.2070407@googlemail.com> (raw)
In-Reply-To: <541C8A26.6050207@ventoso.org>
Am 19.09.2014 um 21:55 schrieb Luca Olivetti:
> El 19/09/14 21:22, Frank Schäfer ha escrit:
>
>>> So symbol_request() returns pointers.!= NULL
>>>
>>> A closer look at the definition of symbol_request() shows, that it does
>>> nothing if CONFIG_MODULES is disabled (it just returns its argument).
>>>
>>>
>>> One possibility to fix this bug would be to embrace these three lines with
>>>
>>> #ifdef CONFIG_DVB_USB_AF9005_REMOTE
>>> ...
>>> #endif
>> Luca, what do you think ?
>>
>> This seems to be an ancient bug, which is known at least since 5 1/2 years:
>> https://lkml.org/lkml/2009/2/4/350
> Well, it's been a while so I don't remember the details, but I think the
> same now as then ;-)
> The idea behind CONFIG_DVB_USB_AF9005_REMOTE was to provide an
> alternative implementation (based on lirc, at the time it wasn't in the
> kernel), since this adapter doesn't decode the IR pulses by itself.
> In theory you could leave it undefined but still provide an
> implementation in a different module. Just adding
>
> #ifdef CONFIG_DVB_USB_AF9005_REMOTE
>
> would nuke the (futile?) effort.
>
> Now, since the problem seems to be with CONFIG_MODULES disabled, maybe
> you could combine both conditions
>
> #if defined(CONFIG_MODULE) || defined(CONFIG_DVB_USB_AF9005_REMOTE)
What happens, if CONFIG_MODULES is enabled, but neither module
af9005-remote nor any other IR module is available ?
Has this ever been tested ?
Regards,
Frank
next prev parent reply other threads:[~2014-09-23 18:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 1:41 [media/em28xx] BUG: unable to handle kernel Fengguang Wu
2014-09-19 1:41 ` Fengguang Wu
2014-09-19 18:57 ` Frank Schäfer
2014-09-19 19:01 ` Frank Schäfer
2014-09-19 19:01 ` Frank Schäfer
2014-09-19 19:21 ` [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel) Frank Schäfer
2014-09-19 19:22 ` Frank Schäfer
2014-09-19 19:55 ` Luca Olivetti
2014-09-19 19:55 ` Luca Olivetti
2014-09-20 11:18 ` Antti Palosaari
2014-09-20 11:18 ` Antti Palosaari
2014-09-23 18:52 ` Frank Schäfer [this message]
2014-09-23 18:52 ` Frank Schäfer
2014-09-23 21:03 ` Luca Olivetti
2014-09-23 21:03 ` Luca Olivetti
2014-09-25 13:53 ` Frank Schäfer
2014-09-25 13:54 ` Frank Schäfer
2014-09-25 15:57 ` Luca Olivetti
2014-09-25 15:57 ` Luca Olivetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5421C187.2070407@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.