From: yocto6@gmail.com (nick)
To: linux-arm-kernel@lists.infradead.org
Subject: FIX Me in pgtable.h
Date: Wed, 24 Sep 2014 07:38:15 -0400 [thread overview]
Message-ID: <5422AD27.30101@gmail.com> (raw)
In-Reply-To: <542238CF.30505@codeaurora.org>
On 14-09-23 11:21 PM, Laura Abbott wrote:
> On 9/23/2014 6:04 AM, nick wrote:
>> Greetings Arm Maintainers,
>> I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
>> value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
>> and should be changed.
>> Thanks,
>> Nick
>>
>
> It's not clear to me how valuable fixing kern_addr_valid would actually
> be for arm. It seems to be used in exactly one place, fs/proc/kcore.c
> and the associated Kconfig is explicitly marked if !ARM. Nearly all
> other archs minus x86, arm64 and sparc are in the same boat as well.
>
> Thanks,
> Laura
>
Laura,
Can we remove it then as it seems that it's not needed at all.
Cheers Nick
WARNING: multiple messages have this Message-ID (diff)
From: nick <yocto6@gmail.com>
To: Laura Abbott <lauraa@codeaurora.org>, linux@arm.linux.org.uk
Cc: steve.capper@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, steve.capper@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: FIX Me in pgtable.h
Date: Wed, 24 Sep 2014 07:38:15 -0400 [thread overview]
Message-ID: <5422AD27.30101@gmail.com> (raw)
In-Reply-To: <542238CF.30505@codeaurora.org>
On 14-09-23 11:21 PM, Laura Abbott wrote:
> On 9/23/2014 6:04 AM, nick wrote:
>> Greetings Arm Maintainers,
>> I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
>> value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
>> and should be changed.
>> Thanks,
>> Nick
>>
>
> It's not clear to me how valuable fixing kern_addr_valid would actually
> be for arm. It seems to be used in exactly one place, fs/proc/kcore.c
> and the associated Kconfig is explicitly marked if !ARM. Nearly all
> other archs minus x86, arm64 and sparc are in the same boat as well.
>
> Thanks,
> Laura
>
Laura,
Can we remove it then as it seems that it's not needed at all.
Cheers Nick
next prev parent reply other threads:[~2014-09-24 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 13:04 FIX Me in pgtable.h nick
2014-09-23 13:04 ` nick
2014-09-23 13:46 ` Krzysztof Kozłowski
2014-09-23 13:46 ` Krzysztof Kozłowski
2014-09-23 15:30 ` Nicholas Krause
2014-09-23 15:30 ` Nicholas Krause
2014-09-24 3:21 ` Laura Abbott
2014-09-24 3:21 ` Laura Abbott
2014-09-24 11:38 ` nick [this message]
2014-09-24 11:38 ` nick
-- strict thread matches above, loose matches on Subject: below --
2014-07-12 5:41 FIX ME " Nick Krause
2014-07-12 5:41 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422AD27.30101@gmail.com \
--to=yocto6@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.