* [PATCH net] ipvs: fix ipv6 hook registration for local replies
@ 2014-08-22 14:53 Julian Anastasov
2014-08-28 1:55 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Julian Anastasov @ 2014-08-22 14:53 UTC (permalink / raw)
To: Simon Horman; +Cc: lvs-devel, Chris J Arges
commit fc604767613b6d2036cdc35b660bc39451040a47
("ipvs: changes for local real server") from 2.6.37
introduced DNAT support to local real server but the
IPv6 LOCAL_OUT handler ip_vs_local_reply6() is
registered incorrectly as IPv4 hook causing any outgoing
IPv4 traffic to be dropped depending on the IP header values.
Chris tracked down the problem to CONFIG_IP_VS_IPV6=y
Bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1349768
Reported-by: Chris J Arges <chris.j.arges@canonical.com>
Tested-by: Chris J Arges <chris.j.arges@canonical.com>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
---
net/netfilter/ipvs/ip_vs_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index e683675..5c34e8d 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -1906,7 +1906,7 @@ static struct nf_hook_ops ip_vs_ops[] __read_mostly = {
{
.hook = ip_vs_local_reply6,
.owner = THIS_MODULE,
- .pf = NFPROTO_IPV4,
+ .pf = NFPROTO_IPV6,
.hooknum = NF_INET_LOCAL_OUT,
.priority = NF_IP6_PRI_NAT_DST + 1,
},
--
1.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] ipvs: fix ipv6 hook registration for local replies
2014-08-22 14:53 [PATCH net] ipvs: fix ipv6 hook registration for local replies Julian Anastasov
@ 2014-08-28 1:55 ` Simon Horman
2014-09-24 14:55 ` Chris J Arges
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2014-08-28 1:55 UTC (permalink / raw)
To: Julian Anastasov; +Cc: lvs-devel, Chris J Arges
On Fri, Aug 22, 2014 at 05:53:41PM +0300, Julian Anastasov wrote:
> commit fc604767613b6d2036cdc35b660bc39451040a47
> ("ipvs: changes for local real server") from 2.6.37
> introduced DNAT support to local real server but the
> IPv6 LOCAL_OUT handler ip_vs_local_reply6() is
> registered incorrectly as IPv4 hook causing any outgoing
> IPv4 traffic to be dropped depending on the IP header values.
>
> Chris tracked down the problem to CONFIG_IP_VS_IPV6=y
> Bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1349768
>
> Reported-by: Chris J Arges <chris.j.arges@canonical.com>
> Tested-by: Chris J Arges <chris.j.arges@canonical.com>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
Thanks, and sorry for the delay.
I have queued this up in the ipvs tree as a fix for v3.17.
I also plan to ask for it to be considered for -stable.
> ---
> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
> index e683675..5c34e8d 100644
> --- a/net/netfilter/ipvs/ip_vs_core.c
> +++ b/net/netfilter/ipvs/ip_vs_core.c
> @@ -1906,7 +1906,7 @@ static struct nf_hook_ops ip_vs_ops[] __read_mostly = {
> {
> .hook = ip_vs_local_reply6,
> .owner = THIS_MODULE,
> - .pf = NFPROTO_IPV4,
> + .pf = NFPROTO_IPV6,
> .hooknum = NF_INET_LOCAL_OUT,
> .priority = NF_IP6_PRI_NAT_DST + 1,
> },
> --
> 1.9.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] ipvs: fix ipv6 hook registration for local replies
2014-08-28 1:55 ` Simon Horman
@ 2014-09-24 14:55 ` Chris J Arges
2014-09-25 0:22 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Chris J Arges @ 2014-09-24 14:55 UTC (permalink / raw)
To: Simon Horman, Julian Anastasov; +Cc: lvs-devel
On 08/27/2014 08:55 PM, Simon Horman wrote:
> On Fri, Aug 22, 2014 at 05:53:41PM +0300, Julian Anastasov wrote:
>> commit fc604767613b6d2036cdc35b660bc39451040a47
>> ("ipvs: changes for local real server") from 2.6.37
>> introduced DNAT support to local real server but the
>> IPv6 LOCAL_OUT handler ip_vs_local_reply6() is
>> registered incorrectly as IPv4 hook causing any outgoing
>> IPv4 traffic to be dropped depending on the IP header values.
>>
>> Chris tracked down the problem to CONFIG_IP_VS_IPV6=y
>> Bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1349768
>>
>> Reported-by: Chris J Arges <chris.j.arges@canonical.com>
>> Tested-by: Chris J Arges <chris.j.arges@canonical.com>
>> Signed-off-by: Julian Anastasov <ja@ssi.bg>
>
> Thanks, and sorry for the delay.
> I have queued this up in the ipvs tree as a fix for v3.17.
> I also plan to ask for it to be considered for -stable.
>
Julian,
Has this been queued up for netdev stable? Or should I send an email?
Thanks,
--chris j arges
>> ---
>> net/netfilter/ipvs/ip_vs_core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
>> index e683675..5c34e8d 100644
>> --- a/net/netfilter/ipvs/ip_vs_core.c
>> +++ b/net/netfilter/ipvs/ip_vs_core.c
>> @@ -1906,7 +1906,7 @@ static struct nf_hook_ops ip_vs_ops[] __read_mostly = {
>> {
>> .hook = ip_vs_local_reply6,
>> .owner = THIS_MODULE,
>> - .pf = NFPROTO_IPV4,
>> + .pf = NFPROTO_IPV6,
>> .hooknum = NF_INET_LOCAL_OUT,
>> .priority = NF_IP6_PRI_NAT_DST + 1,
>> },
>> --
>> 1.9.0
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] ipvs: fix ipv6 hook registration for local replies
2014-09-24 14:55 ` Chris J Arges
@ 2014-09-25 0:22 ` Simon Horman
2014-09-25 16:57 ` Pablo Neira Ayuso
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2014-09-25 0:22 UTC (permalink / raw)
To: Chris J Arges; +Cc: Julian Anastasov, lvs-devel, Pablo Neira Ayuso
[CC Pablo]
On Wed, Sep 24, 2014 at 09:55:11AM -0500, Chris J Arges wrote:
> On 08/27/2014 08:55 PM, Simon Horman wrote:
> > On Fri, Aug 22, 2014 at 05:53:41PM +0300, Julian Anastasov wrote:
> >> commit fc604767613b6d2036cdc35b660bc39451040a47
> >> ("ipvs: changes for local real server") from 2.6.37
> >> introduced DNAT support to local real server but the
> >> IPv6 LOCAL_OUT handler ip_vs_local_reply6() is
> >> registered incorrectly as IPv4 hook causing any outgoing
> >> IPv4 traffic to be dropped depending on the IP header values.
> >>
> >> Chris tracked down the problem to CONFIG_IP_VS_IPV6=y
> >> Bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1349768
> >>
> >> Reported-by: Chris J Arges <chris.j.arges@canonical.com>
> >> Tested-by: Chris J Arges <chris.j.arges@canonical.com>
> >> Signed-off-by: Julian Anastasov <ja@ssi.bg>
> >
> > Thanks, and sorry for the delay.
> > I have queued this up in the ipvs tree as a fix for v3.17.
> > I also plan to ask for it to be considered for -stable.
> >
> Julian,
> Has this been queued up for netdev stable? Or should I send an email?
> Thanks,
Pablo I'm not sure that this has been queued up for stable
(possibly due to some error on my part). What is the best
way forwards?
> --chris j arges
>
> >> ---
> >> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
> >> index e683675..5c34e8d 100644
> >> --- a/net/netfilter/ipvs/ip_vs_core.c
> >> +++ b/net/netfilter/ipvs/ip_vs_core.c
> >> @@ -1906,7 +1906,7 @@ static struct nf_hook_ops ip_vs_ops[] __read_mostly = {
> >> {
> >> .hook = ip_vs_local_reply6,
> >> .owner = THIS_MODULE,
> >> - .pf = NFPROTO_IPV4,
> >> + .pf = NFPROTO_IPV6,
> >> .hooknum = NF_INET_LOCAL_OUT,
> >> .priority = NF_IP6_PRI_NAT_DST + 1,
> >> },
> >> --
> >> 1.9.0
> >>
> >
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] ipvs: fix ipv6 hook registration for local replies
2014-09-25 0:22 ` Simon Horman
@ 2014-09-25 16:57 ` Pablo Neira Ayuso
2014-09-30 5:13 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Pablo Neira Ayuso @ 2014-09-25 16:57 UTC (permalink / raw)
To: Simon Horman; +Cc: Chris J Arges, Julian Anastasov, lvs-devel
On Thu, Sep 25, 2014 at 09:22:16AM +0900, Simon Horman wrote:
> [CC Pablo]
>
> On Wed, Sep 24, 2014 at 09:55:11AM -0500, Chris J Arges wrote:
> > On 08/27/2014 08:55 PM, Simon Horman wrote:
> > > On Fri, Aug 22, 2014 at 05:53:41PM +0300, Julian Anastasov wrote:
> > >> commit fc604767613b6d2036cdc35b660bc39451040a47
> > >> ("ipvs: changes for local real server") from 2.6.37
> > >> introduced DNAT support to local real server but the
> > >> IPv6 LOCAL_OUT handler ip_vs_local_reply6() is
> > >> registered incorrectly as IPv4 hook causing any outgoing
> > >> IPv4 traffic to be dropped depending on the IP header values.
> > >>
> > >> Chris tracked down the problem to CONFIG_IP_VS_IPV6=y
> > >> Bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1349768
> > >>
> > >> Reported-by: Chris J Arges <chris.j.arges@canonical.com>
> > >> Tested-by: Chris J Arges <chris.j.arges@canonical.com>
> > >> Signed-off-by: Julian Anastasov <ja@ssi.bg>
> > >
> > > Thanks, and sorry for the delay.
> > > I have queued this up in the ipvs tree as a fix for v3.17.
> > > I also plan to ask for it to be considered for -stable.
> > >
> > Julian,
> > Has this been queued up for netdev stable? Or should I send an email?
> > Thanks,
>
> Pablo I'm not sure that this has been queued up for stable
> (possibly due to some error on my part). What is the best
> way forwards?
Just sent a batch with pending Netfilter/IPVS to -stable. The patch
authors has been Cc'ed. I didn't Cc'ed the mailing list to not
generate more load on redudant patches, but I can do it if you prefer
so.
Let me know if we don't get any feedback from -stable soon to get this
patches in. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] ipvs: fix ipv6 hook registration for local replies
2014-09-25 16:57 ` Pablo Neira Ayuso
@ 2014-09-30 5:13 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-09-30 5:13 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Chris J Arges, Julian Anastasov, lvs-devel
On Thu, Sep 25, 2014 at 06:57:57PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Sep 25, 2014 at 09:22:16AM +0900, Simon Horman wrote:
> > [CC Pablo]
> >
> > On Wed, Sep 24, 2014 at 09:55:11AM -0500, Chris J Arges wrote:
> > > On 08/27/2014 08:55 PM, Simon Horman wrote:
> > > > On Fri, Aug 22, 2014 at 05:53:41PM +0300, Julian Anastasov wrote:
> > > >> commit fc604767613b6d2036cdc35b660bc39451040a47
> > > >> ("ipvs: changes for local real server") from 2.6.37
> > > >> introduced DNAT support to local real server but the
> > > >> IPv6 LOCAL_OUT handler ip_vs_local_reply6() is
> > > >> registered incorrectly as IPv4 hook causing any outgoing
> > > >> IPv4 traffic to be dropped depending on the IP header values.
> > > >>
> > > >> Chris tracked down the problem to CONFIG_IP_VS_IPV6=y
> > > >> Bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1349768
> > > >>
> > > >> Reported-by: Chris J Arges <chris.j.arges@canonical.com>
> > > >> Tested-by: Chris J Arges <chris.j.arges@canonical.com>
> > > >> Signed-off-by: Julian Anastasov <ja@ssi.bg>
> > > >
> > > > Thanks, and sorry for the delay.
> > > > I have queued this up in the ipvs tree as a fix for v3.17.
> > > > I also plan to ask for it to be considered for -stable.
> > > >
> > > Julian,
> > > Has this been queued up for netdev stable? Or should I send an email?
> > > Thanks,
> >
> > Pablo I'm not sure that this has been queued up for stable
> > (possibly due to some error on my part). What is the best
> > way forwards?
>
> Just sent a batch with pending Netfilter/IPVS to -stable. The patch
> authors has been Cc'ed. I didn't Cc'ed the mailing list to not
> generate more load on redudant patches, but I can do it if you prefer
> so.
>
> Let me know if we don't get any feedback from -stable soon to get this
> patches in. Thanks.
Thanks Pablo.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-30 5:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 14:53 [PATCH net] ipvs: fix ipv6 hook registration for local replies Julian Anastasov
2014-08-28 1:55 ` Simon Horman
2014-09-24 14:55 ` Chris J Arges
2014-09-25 0:22 ` Simon Horman
2014-09-25 16:57 ` Pablo Neira Ayuso
2014-09-30 5:13 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.