All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks
@ 2014-09-22 13:51 Ludovic Desroches
  2014-09-24 16:03 ` Nicolas Ferre
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Desroches @ 2014-09-22 13:51 UTC (permalink / raw)
  To: linux-arm-kernel

When introducing support for sama5d3, the write to PMC_PCDR register has
been accidentally removed.

Reported-by: Nathalie Cyrille <nathalie.cyrille@atmel.com>
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: <stable@vger.kernel.org> # 3.10.x and later
---

Sorry for the noise, typo in the cc list!

Ludovic

 arch/arm/mach-at91/clock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-at91/clock.c b/arch/arm/mach-at91/clock.c
index 034529d..d66f102 100644
--- a/arch/arm/mach-at91/clock.c
+++ b/arch/arm/mach-at91/clock.c
@@ -962,6 +962,7 @@ static int __init at91_clock_reset(void)
 	}
 
 	at91_pmc_write(AT91_PMC_SCDR, scdr);
+	at91_pmc_write(AT91_PMC_PCDR, pcdr);
 	if (cpu_is_sama5d3())
 		at91_pmc_write(AT91_PMC_PCDR1, pcdr1);
 
-- 
2.0.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [RESEND PATCH] ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks
  2014-09-22 13:51 [RESEND PATCH] ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks Ludovic Desroches
@ 2014-09-24 16:03 ` Nicolas Ferre
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2014-09-24 16:03 UTC (permalink / raw)
  To: linux-arm-kernel

On 22/09/2014 15:51, Ludovic Desroches :
> When introducing support for sama5d3, the write to PMC_PCDR register has
> been accidentally removed.
> 
> Reported-by: Nathalie Cyrille <nathalie.cyrille@atmel.com>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Cc: <stable@vger.kernel.org> # 3.10.x and later

Absolutely: thanks for the fix!

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

I queue it in at91-3.18-fixes-non-critical branch and it may show-up in
3.18 or 3.19.

Best regards,


> ---
> 
> Sorry for the noise, typo in the cc list!
> 
> Ludovic
> 
>  arch/arm/mach-at91/clock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-at91/clock.c b/arch/arm/mach-at91/clock.c
> index 034529d..d66f102 100644
> --- a/arch/arm/mach-at91/clock.c
> +++ b/arch/arm/mach-at91/clock.c
> @@ -962,6 +962,7 @@ static int __init at91_clock_reset(void)
>  	}
>  
>  	at91_pmc_write(AT91_PMC_SCDR, scdr);
> +	at91_pmc_write(AT91_PMC_PCDR, pcdr);
>  	if (cpu_is_sama5d3())
>  		at91_pmc_write(AT91_PMC_PCDR1, pcdr1);
>  
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-24 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-22 13:51 [RESEND PATCH] ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks Ludovic Desroches
2014-09-24 16:03 ` Nicolas Ferre

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.