All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: enable new AIC driver even if the old one is selected
Date: Wed, 24 Sep 2014 18:19:06 +0200	[thread overview]
Message-ID: <5422EEFA.7020303@atmel.com> (raw)
In-Reply-To: <1410254099-24680-1-git-send-email-boris.brezillon@free-electrons.com>

On 09/09/2014 11:14, Boris BREZILLON :
> The new AIC driver is currently only selected when only DT board support
> is enabled (and not when both DT and non-DT boards are supported), thus,
> when booting a "DT + non-DT" kernel with a dtb, the irqchip is never
> initialized/registered which then triggers a panic.
> 
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>

I'm not taking this right now. The Kconfig file is in flux. I'll try to
queue it during the 3.18-rc phase.

Bye,

> ---
>  arch/arm/mach-at91/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 7df2c9b..cd7c0cb 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -51,7 +51,7 @@ config HAVE_AT91_SMD
>  config SOC_AT91SAM9
>  	bool
>  	select AT91_SAM9_TIME
> -	select ATMEL_AIC_IRQ if !OLD_IRQ_AT91
> +	select ATMEL_AIC_IRQ
>  	select CPU_ARM926T
>  	select GENERIC_CLOCKEVENTS
>  
> @@ -111,7 +111,7 @@ endif
>  if SOC_SAM_V4_V5
>  config SOC_AT91RM9200
>  	bool "AT91RM9200"
> -	select ATMEL_AIC_IRQ if !OLD_IRQ_AT91
> +	select ATMEL_AIC_IRQ
>  	select CPU_ARM920T
>  	select GENERIC_CLOCKEVENTS
>  	select HAVE_AT91_DBGU0
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: at91: enable new AIC driver even if the old one is selected
Date: Wed, 24 Sep 2014 18:19:06 +0200	[thread overview]
Message-ID: <5422EEFA.7020303@atmel.com> (raw)
In-Reply-To: <1410254099-24680-1-git-send-email-boris.brezillon@free-electrons.com>

On 09/09/2014 11:14, Boris BREZILLON :
> The new AIC driver is currently only selected when only DT board support
> is enabled (and not when both DT and non-DT boards are supported), thus,
> when booting a "DT + non-DT" kernel with a dtb, the irqchip is never
> initialized/registered which then triggers a panic.
> 
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>

I'm not taking this right now. The Kconfig file is in flux. I'll try to
queue it during the 3.18-rc phase.

Bye,

> ---
>  arch/arm/mach-at91/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 7df2c9b..cd7c0cb 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -51,7 +51,7 @@ config HAVE_AT91_SMD
>  config SOC_AT91SAM9
>  	bool
>  	select AT91_SAM9_TIME
> -	select ATMEL_AIC_IRQ if !OLD_IRQ_AT91
> +	select ATMEL_AIC_IRQ
>  	select CPU_ARM926T
>  	select GENERIC_CLOCKEVENTS
>  
> @@ -111,7 +111,7 @@ endif
>  if SOC_SAM_V4_V5
>  config SOC_AT91RM9200
>  	bool "AT91RM9200"
> -	select ATMEL_AIC_IRQ if !OLD_IRQ_AT91
> +	select ATMEL_AIC_IRQ
>  	select CPU_ARM920T
>  	select GENERIC_CLOCKEVENTS
>  	select HAVE_AT91_DBGU0
> 


-- 
Nicolas Ferre

  reply	other threads:[~2014-09-24 16:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  9:14 [PATCH] ARM: at91: enable new AIC driver even if the old one is selected Boris BREZILLON
2014-09-09  9:14 ` Boris BREZILLON
2014-09-24 16:19 ` Nicolas Ferre [this message]
2014-09-24 16:19   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5422EEFA.7020303@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.