From: Behan Webster <behanw@converseincode.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: bcm@fixthebug.org, chris@printf.net, gnurou@gmail.com,
linus.walleij@linaro.org, mporter@linaro.org,
ulf.hansson@linaro.org, bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org,
rjui@broadcom.comlinus.walleij@linaro.org
Subject: Re: [PATCH v2 2/2] mmc, sdhci, bcm-kona, LLVMLinux: Remove use of __initconst
Date: Wed, 24 Sep 2014 11:21:16 -0700 [thread overview]
Message-ID: <54230B9C.9090703@converseincode.com> (raw)
In-Reply-To: <5774775.2EcFmuR4sV@wuerfel>
On 09/24/14 02:22, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 15:55:08 behanw@converseincode.com wrote:
>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>> @@ -225,7 +225,7 @@ static struct sdhci_pltfm_data sdhci_pltfm_data_kona = {
>> SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
>> };
>>
>> -static struct __initconst of_device_id sdhci_bcm_kona_of_match[] = {
>> +static struct of_device_id const sdhci_bcm_kona_of_match[] = {
>> { .compatible = "brcm,kona-sdhci"},
>> { .compatible = "bcm,kona-sdhci"}, /* deprecated name */
>> {}
>>
> Sorry for giving you trouble over such a simple patch (especially
> one that I have acked already), but I just noticed that this is
> not following the common style we use in the kernel.
It's all good. It's not like you haven't saved me a tonne of time
already! :)
> Almost everywhere in Linux, we use
>
> static const struct of_device_id sdhci_bcm_kona_of_match[] = {
>
> not
>
> static struct of_device_id const sdhci_bcm_kona_of_match[] = {
True enough. I put the const where I did to be in keeping with the
intent of __initconst, making the array const instead of the contained type.
> AFAICT they behave in identical ways,
Indeed. For C in both cases the resulting array of struct of_device_id
ends up in .rodata, so functionally equivalent.
> but the first one seems
> easier to read for someone familiar with kernel code.
No worries. Happy to post a v3.
Linus Walleij: Would you like me to respin the "gpio, bcm-kona,
LLVMLinux: Remove use of __initconst" patch as well?
Behan
--
Behan Webster
behanw@converseincode.com
WARNING: multiple messages have this Message-ID (diff)
From: Behan Webster <behanw@converseincode.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: bcm@fixthebug.org, chris@printf.net, gnurou@gmail.com,
linus.walleij@linaro.org, mporter@linaro.org,
ulf.hansson@linaro.org, bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, rjui@broadcom.com,
linus.walleij@linaro.org
Subject: Re: [PATCH v2 2/2] mmc, sdhci, bcm-kona, LLVMLinux: Remove use of __initconst
Date: Wed, 24 Sep 2014 11:21:16 -0700 [thread overview]
Message-ID: <54230B9C.9090703@converseincode.com> (raw)
In-Reply-To: <5774775.2EcFmuR4sV@wuerfel>
On 09/24/14 02:22, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 15:55:08 behanw@converseincode.com wrote:
>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>> @@ -225,7 +225,7 @@ static struct sdhci_pltfm_data sdhci_pltfm_data_kona = {
>> SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
>> };
>>
>> -static struct __initconst of_device_id sdhci_bcm_kona_of_match[] = {
>> +static struct of_device_id const sdhci_bcm_kona_of_match[] = {
>> { .compatible = "brcm,kona-sdhci"},
>> { .compatible = "bcm,kona-sdhci"}, /* deprecated name */
>> {}
>>
> Sorry for giving you trouble over such a simple patch (especially
> one that I have acked already), but I just noticed that this is
> not following the common style we use in the kernel.
It's all good. It's not like you haven't saved me a tonne of time
already! :)
> Almost everywhere in Linux, we use
>
> static const struct of_device_id sdhci_bcm_kona_of_match[] = {
>
> not
>
> static struct of_device_id const sdhci_bcm_kona_of_match[] = {
True enough. I put the const where I did to be in keeping with the
intent of __initconst, making the array const instead of the contained type.
> AFAICT they behave in identical ways,
Indeed. For C in both cases the resulting array of struct of_device_id
ends up in .rodata, so functionally equivalent.
> but the first one seems
> easier to read for someone familiar with kernel code.
No worries. Happy to post a v3.
Linus Walleij: Would you like me to respin the "gpio, bcm-kona,
LLVMLinux: Remove use of __initconst" patch as well?
Behan
--
Behan Webster
behanw@converseincode.com
next prev parent reply other threads:[~2014-09-24 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 19:30 [PATCH] gpio, bcm-kona, LLVMLinux: Remove use of __initconst behanw
2014-09-23 21:20 ` Matt Porter
2014-09-23 21:29 ` Matt Porter
2014-09-23 22:55 ` [PATCH v2 1/2] " behanw
2014-09-23 22:55 ` [PATCH v2 2/2] mmc, sdhci, " behanw
2014-09-24 9:22 ` Arnd Bergmann
2014-09-24 18:21 ` Behan Webster [this message]
2014-09-24 18:21 ` Behan Webster
2014-09-25 8:18 ` Linus Walleij
2014-09-25 22:45 ` [PATCH v3] " Behan Webster
2014-10-03 12:59 ` Ulf Hansson
2014-09-24 11:40 ` [PATCH v2 1/2] gpio, " Linus Walleij
2014-09-23 22:59 ` [PATCH] " Behan Webster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54230B9C.9090703@converseincode.com \
--to=behanw@converseincode.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bcm@fixthebug.org \
--cc=chris@printf.net \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mporter@linaro.org \
--cc=rjui@broadcom.comlinus.walleij \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.