* [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
@ 2014-09-24 3:44 ` Behan Webster
0 siblings, 0 replies; 10+ messages in thread
From: Behan Webster @ 2014-09-24 3:44 UTC (permalink / raw)
To: linux-arm-kernel
The ASM below does not compile with clang and is not the way that the mcr
command is used in other parts of the kernel.
arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
There are other forms that are supported on different ARM instruction sets but
generally the kernel just uses mcr as it is supported in all ARM instruction
sets.
Signed-off-by: Behan Webster <behanw@converseincode.com>
Reviewed-by: Mark Charlebois <charlebm@gmail.com>
Acked-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/mach-vt8500/vt8500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
index 2da7be3..3bc0dc9 100644
--- a/arch/arm/mach-vt8500/vt8500.c
+++ b/arch/arm/mach-vt8500/vt8500.c
@@ -69,7 +69,7 @@ static void vt8500_power_off(void)
{
local_irq_disable();
writew(5, pmc_base + VT8500_HCR_REG);
- asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
+ asm("mcr p15, 0, %0, c7, c0, 4" : : "r" (0));
}
static void __init vt8500_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
@ 2014-09-24 3:44 ` Behan Webster
0 siblings, 0 replies; 10+ messages in thread
From: Behan Webster @ 2014-09-24 3:44 UTC (permalink / raw)
To: linux, linux; +Cc: behanw, linux-arm-kernel, linux-kernel
The ASM below does not compile with clang and is not the way that the mcr
command is used in other parts of the kernel.
arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
There are other forms that are supported on different ARM instruction sets but
generally the kernel just uses mcr as it is supported in all ARM instruction
sets.
Signed-off-by: Behan Webster <behanw@converseincode.com>
Reviewed-by: Mark Charlebois <charlebm@gmail.com>
Acked-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/mach-vt8500/vt8500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
index 2da7be3..3bc0dc9 100644
--- a/arch/arm/mach-vt8500/vt8500.c
+++ b/arch/arm/mach-vt8500/vt8500.c
@@ -69,7 +69,7 @@ static void vt8500_power_off(void)
{
local_irq_disable();
writew(5, pmc_base + VT8500_HCR_REG);
- asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
+ asm("mcr p15, 0, %0, c7, c0, 4" : : "r" (0));
}
static void __init vt8500_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
2014-09-24 3:44 ` Behan Webster
@ 2014-09-24 9:16 ` Arnd Bergmann
-1 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-09-24 9:16 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 23 September 2014 20:44:44 Behan Webster wrote:
> The ASM below does not compile with clang and is not the way that the mcr
> command is used in other parts of the kernel.
>
> arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
> ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> There are other forms that are supported on different ARM instruction sets but
> generally the kernel just uses mcr as it is supported in all ARM instruction
> sets.
Just for confirm: both forms are actually correct and we don't need this
backported for stable, right?
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
> Acked-by: Will Deacon <will.deacon@arm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Tony, would you like to pick this one up and send it in a pull request
to arm-soc, or should we apply it to fixes-non-critical directly?
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
@ 2014-09-24 9:16 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-09-24 9:16 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Behan Webster, linux, linux, linux-kernel
On Tuesday 23 September 2014 20:44:44 Behan Webster wrote:
> The ASM below does not compile with clang and is not the way that the mcr
> command is used in other parts of the kernel.
>
> arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
> ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> There are other forms that are supported on different ARM instruction sets but
> generally the kernel just uses mcr as it is supported in all ARM instruction
> sets.
Just for confirm: both forms are actually correct and we don't need this
backported for stable, right?
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
> Acked-by: Will Deacon <will.deacon@arm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Tony, would you like to pick this one up and send it in a pull request
to arm-soc, or should we apply it to fixes-non-critical directly?
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
2014-09-24 9:16 ` Arnd Bergmann
@ 2014-09-24 18:11 ` Behan Webster
-1 siblings, 0 replies; 10+ messages in thread
From: Behan Webster @ 2014-09-24 18:11 UTC (permalink / raw)
To: linux-arm-kernel
On 09/24/14 02:16, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 20:44:44 Behan Webster wrote:
>> The ASM below does not compile with clang and is not the way that the mcr
>> command is used in other parts of the kernel.
>>
>> arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
>> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>> ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>> 1 error generated.
>>
>> There are other forms that are supported on different ARM instruction sets but
>> generally the kernel just uses mcr as it is supported in all ARM instruction
>> sets.
> Just for confirm: both forms are actually correct and we don't need this
> backported for stable, right?
My understanding is that the %? carries a condition code to the next
instruction (which in this case is then ignored). So essentially in this
situation both are equivalent.
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
>> Acked-by: Will Deacon <will.deacon@arm.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Tony, would you like to pick this one up and send it in a pull request
> to arm-soc, or should we apply it to fixes-non-critical directly?
Thanks,
Behan
--
Behan Webster
behanw at converseincode.com
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
@ 2014-09-24 18:11 ` Behan Webster
0 siblings, 0 replies; 10+ messages in thread
From: Behan Webster @ 2014-09-24 18:11 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel; +Cc: linux, linux, linux-kernel
On 09/24/14 02:16, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 20:44:44 Behan Webster wrote:
>> The ASM below does not compile with clang and is not the way that the mcr
>> command is used in other parts of the kernel.
>>
>> arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
>> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>> ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>> 1 error generated.
>>
>> There are other forms that are supported on different ARM instruction sets but
>> generally the kernel just uses mcr as it is supported in all ARM instruction
>> sets.
> Just for confirm: both forms are actually correct and we don't need this
> backported for stable, right?
My understanding is that the %? carries a condition code to the next
instruction (which in this case is then ignored). So essentially in this
situation both are equivalent.
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
>> Acked-by: Will Deacon <will.deacon@arm.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Tony, would you like to pick this one up and send it in a pull request
> to arm-soc, or should we apply it to fixes-non-critical directly?
Thanks,
Behan
--
Behan Webster
behanw@converseincode.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
2014-09-24 9:16 ` Arnd Bergmann
@ 2014-09-24 18:23 ` Tony Prisk
-1 siblings, 0 replies; 10+ messages in thread
From: Tony Prisk @ 2014-09-24 18:23 UTC (permalink / raw)
To: linux-arm-kernel
On 24/09/14 21:16, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 20:44:44 Behan Webster wrote:
>> The ASM below does not compile with clang and is not the way that the mcr
>> command is used in other parts of the kernel.
>>
>> arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
>> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>> ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>> 1 error generated.
>>
>> There are other forms that are supported on different ARM instruction sets but
>> generally the kernel just uses mcr as it is supported in all ARM instruction
>> sets.
> Just for confirm: both forms are actually correct and we don't need this
> backported for stable, right?
>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
>> Acked-by: Will Deacon <will.deacon@arm.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Tony, would you like to pick this one up and send it in a pull request
> to arm-soc, or should we apply it to fixes-non-critical directly?
>
> Arnd
Arnd,
You can apply it directly to fixes-non-critical if that's ok.
Regards
Tony Prisk
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
@ 2014-09-24 18:23 ` Tony Prisk
0 siblings, 0 replies; 10+ messages in thread
From: Tony Prisk @ 2014-09-24 18:23 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel; +Cc: Behan Webster, linux, linux-kernel
On 24/09/14 21:16, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 20:44:44 Behan Webster wrote:
>> The ASM below does not compile with clang and is not the way that the mcr
>> command is used in other parts of the kernel.
>>
>> arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
>> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>> ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>> 1 error generated.
>>
>> There are other forms that are supported on different ARM instruction sets but
>> generally the kernel just uses mcr as it is supported in all ARM instruction
>> sets.
> Just for confirm: both forms are actually correct and we don't need this
> backported for stable, right?
>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
>> Acked-by: Will Deacon <will.deacon@arm.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Tony, would you like to pick this one up and send it in a pull request
> to arm-soc, or should we apply it to fixes-non-critical directly?
>
> Arnd
Arnd,
You can apply it directly to fixes-non-critical if that's ok.
Regards
Tony Prisk
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
2014-09-24 18:23 ` Tony Prisk
@ 2014-09-25 23:26 ` Arnd Bergmann
-1 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-09-25 23:26 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 24 September 2014, Tony Prisk wrote:
> > Tony, would you like to pick this one up and send it in a pull request
> > to arm-soc, or should we apply it to fixes-non-critical directly?
> >
> > Arnd
> Arnd,
>
> You can apply it directly to fixes-non-critical if that's ok.
Applied, thanks!
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500
@ 2014-09-25 23:26 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-09-25 23:26 UTC (permalink / raw)
To: Tony Prisk; +Cc: linux-arm-kernel, Behan Webster, linux, linux-kernel
On Wednesday 24 September 2014, Tony Prisk wrote:
> > Tony, would you like to pick this one up and send it in a pull request
> > to arm-soc, or should we apply it to fixes-non-critical directly?
> >
> > Arnd
> Arnd,
>
> You can apply it directly to fixes-non-critical if that's ok.
Applied, thanks!
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-09-25 23:27 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24 3:44 [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500 Behan Webster
2014-09-24 3:44 ` Behan Webster
2014-09-24 9:16 ` Arnd Bergmann
2014-09-24 9:16 ` Arnd Bergmann
2014-09-24 18:11 ` Behan Webster
2014-09-24 18:11 ` Behan Webster
2014-09-24 18:23 ` Tony Prisk
2014-09-24 18:23 ` Tony Prisk
2014-09-25 23:26 ` Arnd Bergmann
2014-09-25 23:26 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.