From: David Marchand <david.marchand@6wind.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, pbonzini@redhat.com,
claudio.fontana@huawei.com, jani.kokkonen@huawei.com,
eblake@redhat.com, cam@cs.ualberta.ca, armbru@redhat.com,
arei.gonglei@huawei.com, mkletzan@redhat.com
Subject: Re: [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU
Date: Thu, 25 Sep 2014 10:38:40 +0200 [thread overview]
Message-ID: <5423D490.7050306@6wind.com> (raw)
In-Reply-To: <20140923155831.GB3150@stefanha-thinkpad.redhat.com>
On 09/23/2014 05:58 PM, Stefan Hajnoczi wrote:
> I'm not sure a full-fledged feature negotiation system is needed. The
> ivshmem protocol is local to the host and all participants are under
> control of the administrator.
>
> I suggested a protocol version to protect against misconfiguration. For
> example, building QEMU from source but talking to an outdated ivhsmem
> server that is still running from before.
>
> Remember that ivshmem-server and QEMU are shipped together by the
> distro. So in 99% of the cases they will have the same version anyway.
> But we want to protect against rare misconfiguration that break things
> (user mixing and matching incompatible software).
Ok, so how about keeping with this simple mechanism at the moment ?
If this versionning system is too limited in the future, I think we will
need a global rework on the protocol, anyway.
--
David Marchand
WARNING: multiple messages have this Message-ID (diff)
From: David Marchand <david.marchand@6wind.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, claudio.fontana@huawei.com,
qemu-devel@nongnu.org, armbru@redhat.com,
arei.gonglei@huawei.com, mkletzan@redhat.com,
pbonzini@redhat.com, jani.kokkonen@huawei.com,
cam@cs.ualberta.ca
Subject: Re: [Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU
Date: Thu, 25 Sep 2014 10:38:40 +0200 [thread overview]
Message-ID: <5423D490.7050306@6wind.com> (raw)
In-Reply-To: <20140923155831.GB3150@stefanha-thinkpad.redhat.com>
On 09/23/2014 05:58 PM, Stefan Hajnoczi wrote:
> I'm not sure a full-fledged feature negotiation system is needed. The
> ivshmem protocol is local to the host and all participants are under
> control of the administrator.
>
> I suggested a protocol version to protect against misconfiguration. For
> example, building QEMU from source but talking to an outdated ivhsmem
> server that is still running from before.
>
> Remember that ivshmem-server and QEMU are shipped together by the
> distro. So in 99% of the cases they will have the same version anyway.
> But we want to protect against rare misconfiguration that break things
> (user mixing and matching incompatible software).
Ok, so how about keeping with this simple mechanism at the moment ?
If this versionning system is too limited in the future, I think we will
need a global rework on the protocol, anyway.
--
David Marchand
next prev parent reply other threads:[~2014-09-25 8:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 9:17 [PATCH v6 0/3] ivshmem: update documentation, add client/server tools David Marchand
2014-09-08 9:17 ` [Qemu-devel] " David Marchand
2014-09-08 9:17 ` [PATCH v6 1/3] contrib: add ivshmem client and server David Marchand
2014-09-08 9:17 ` [Qemu-devel] " David Marchand
2014-09-08 9:51 ` Michael S. Tsirkin
2014-09-08 9:51 ` [Qemu-devel] " Michael S. Tsirkin
2014-09-08 9:17 ` [PATCH v6 2/3] docs: update ivshmem device spec David Marchand
2014-09-08 9:17 ` [Qemu-devel] " David Marchand
2014-09-08 10:01 ` Michael S. Tsirkin
2014-09-08 10:01 ` [Qemu-devel] " Michael S. Tsirkin
2014-09-08 9:17 ` [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU David Marchand
2014-09-08 9:17 ` [Qemu-devel] " David Marchand
2014-09-08 9:49 ` Michael S. Tsirkin
2014-09-08 9:49 ` [Qemu-devel] " Michael S. Tsirkin
2014-09-23 15:58 ` Stefan Hajnoczi
2014-09-23 15:58 ` [Qemu-devel] " Stefan Hajnoczi
2014-09-25 8:38 ` David Marchand [this message]
2014-09-25 8:38 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5423D490.7050306@6wind.com \
--to=david.marchand@6wind.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=claudio.fontana@huawei.com \
--cc=eblake@redhat.com \
--cc=jani.kokkonen@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=mkletzan@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.