From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, weidong.huang@huawei.com,
qemu-trivial@nongnu.org, luonengjun@huawei.com, mjt@tls.msk.ru,
armbru@redhat.com, peter.huangpeng@huawei.com,
pbonzini@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report
Date: Thu, 25 Sep 2014 06:35:33 -0600 [thread overview]
Message-ID: <54240C15.1010408@redhat.com> (raw)
In-Reply-To: <1411638384-5844-4-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On 09/25/2014 03:46 AM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> util/osdep.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/util/osdep.c b/util/osdep.c
> index b2bd154..7f6e483 100644
> --- a/util/osdep.c
> +++ b/util/osdep.c
> @@ -401,9 +401,9 @@ void fips_set_state(bool requested)
> #endif /* __linux__ */
>
> #ifdef _FIPS_DEBUG
> - fprintf(stderr, "FIPS mode %s (requested %s)\n",
> - (fips_enabled ? "enabled" : "disabled"),
> - (requested ? "enabled" : "disabled"));
> + error_report("FIPS mode %s (requested %s)",
> + (fips_enabled ? "enabled" : "disabled"),
> + (requested ? "enabled" : "disabled"));
Do we really want debugging messages going through error_report()? This
may be one hunk we don't want.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, weidong.huang@huawei.com,
qemu-trivial@nongnu.org, luonengjun@huawei.com, mjt@tls.msk.ru,
armbru@redhat.com, peter.huangpeng@huawei.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report
Date: Thu, 25 Sep 2014 06:35:33 -0600 [thread overview]
Message-ID: <54240C15.1010408@redhat.com> (raw)
In-Reply-To: <1411638384-5844-4-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On 09/25/2014 03:46 AM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> util/osdep.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/util/osdep.c b/util/osdep.c
> index b2bd154..7f6e483 100644
> --- a/util/osdep.c
> +++ b/util/osdep.c
> @@ -401,9 +401,9 @@ void fips_set_state(bool requested)
> #endif /* __linux__ */
>
> #ifdef _FIPS_DEBUG
> - fprintf(stderr, "FIPS mode %s (requested %s)\n",
> - (fips_enabled ? "enabled" : "disabled"),
> - (requested ? "enabled" : "disabled"));
> + error_report("FIPS mode %s (requested %s)",
> + (fips_enabled ? "enabled" : "disabled"),
> + (requested ? "enabled" : "disabled"));
Do we really want debugging messages going through error_report()? This
may be one hunk we don't want.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-09-25 12:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 9:46 [Qemu-trivial] [PATCH 0/4] os: convert fprintf/perror to error_report arei.gonglei
2014-09-25 9:46 ` [Qemu-devel] " arei.gonglei
2014-09-25 9:46 ` [Qemu-trivial] [PATCH 1/4] os-posix/win32: " arei.gonglei
2014-09-25 9:46 ` [Qemu-devel] " arei.gonglei
2014-09-25 12:33 ` [Qemu-trivial] " Eric Blake
2014-09-25 12:33 ` Eric Blake
2014-09-25 12:53 ` [Qemu-trivial] " Gonglei (Arei)
2014-09-25 12:53 ` Gonglei (Arei)
2014-09-25 9:46 ` [Qemu-trivial] [PATCH 2/4] os-posix: report error message when lock file failed arei.gonglei
2014-09-25 9:46 ` [Qemu-devel] " arei.gonglei
2014-10-01 8:45 ` [Qemu-trivial] " Markus Armbruster
2014-10-01 8:45 ` Markus Armbruster
2014-10-01 9:12 ` [Qemu-trivial] " Gonglei
2014-10-01 9:12 ` Gonglei
2014-10-01 10:24 ` [Qemu-trivial] " Markus Armbruster
2014-10-01 10:24 ` Markus Armbruster
2014-10-01 11:58 ` [Qemu-trivial] " Gonglei
2014-10-01 11:58 ` Gonglei
2014-10-01 12:38 ` [Qemu-trivial] " Markus Armbruster
2014-10-01 12:38 ` Markus Armbruster
2014-10-24 7:32 ` [Qemu-trivial] " Michael Tokarev
2014-10-24 7:32 ` [Qemu-devel] " Michael Tokarev
2014-10-24 8:56 ` Gonglei
2014-10-24 8:56 ` [Qemu-devel] " Gonglei
2014-09-25 9:46 ` [Qemu-trivial] [PATCH 3/4] osdep: convert fprintf to error_report arei.gonglei
2014-09-25 9:46 ` [Qemu-devel] " arei.gonglei
2014-09-25 12:35 ` Eric Blake [this message]
2014-09-25 12:35 ` Eric Blake
2014-09-25 12:54 ` [Qemu-trivial] " Gonglei (Arei)
2014-09-25 12:54 ` Gonglei (Arei)
2014-09-25 9:46 ` [Qemu-trivial] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror " arei.gonglei
2014-09-25 9:46 ` [Qemu-devel] " arei.gonglei
2014-09-25 12:36 ` [Qemu-trivial] " Eric Blake
2014-09-25 12:36 ` Eric Blake
2014-09-25 12:55 ` [Qemu-trivial] " Gonglei (Arei)
2014-09-25 12:55 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54240C15.1010408@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.