Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

On 09/24/2014 11:23 PM, Tony Breeds wrote:
> The command
>   qemu-img convert -O raw inputimage.qcow2 outputimage.raw
> 
> intermittently creates corrupted output images, when the input image
is not yet fully synchronized to disk.  This patch preferese the use of
seek_hole checks to determine if the sector is present in the disk image.

s/preferese/prefers/

Please wrap your commit messages to fit in 70 or so columns (so that git
log, which indents messages, is still legible in an 80-column window).

> 
> While we're there modify try_fiemap() to set FIEMAP_FLAG_SYNC.
> 
> Reported-By: Michael Steffens <michael_steffens@posteo.de>
> CC: Pádraig Brady <pbrady@redhat.com>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---
>  block/raw-posix.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Adding Kevin and Stefan in cc (per scripts/get_maintainer.pl).
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]