From: Max Reitz <mreitz@redhat.com>
To: Tony Breeds <tony@bakeyournoodle.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Pádraig Brady" <pbrady@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap
Date: Fri, 26 Sep 2014 19:05:06 +0200 [thread overview]
Message-ID: <54259CC2.20508@redhat.com> (raw)
In-Reply-To: <1411686852-26487-1-git-send-email-tony@bakeyournoodle.com>
On 26.09.2014 01:14, Tony Breeds wrote:
> Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter.
>
> Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl. This has
> the downside of significantly reducing performance.
>
> Reported-By: Michael Steffens <michael_steffens@posteo.de>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: Pádraig Brady <pbrady@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> ---
> Changes since v1:
> - split in to 2 patches
> - tried to make the commit messages better
>
> block/raw-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-09-26 17:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 5:23 [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap Tony Breeds
2014-09-25 6:21 ` Markus Armbruster
2014-09-25 6:29 ` Tony Breeds
2014-09-25 6:42 ` Greg Kurz
2014-09-25 6:48 ` Tony Breeds
2014-09-25 6:47 ` Markus Armbruster
2014-09-25 7:30 ` Kevin Wolf
2014-09-25 9:00 ` Tony Breeds
2014-09-25 9:52 ` Kevin Wolf
2014-09-25 10:41 ` Pádraig Brady
2014-09-25 12:45 ` Eric Blake
2014-09-25 12:40 ` Eric Blake
2014-09-25 23:14 ` [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap Tony Breeds
2014-09-25 23:14 ` [Qemu-devel] [PATCH v2 2/2] block/raw-posix: use seek_hole ahead of fiemap Tony Breeds
2014-09-26 17:04 ` Max Reitz
2014-09-26 17:22 ` Eric Blake
2014-09-26 17:05 ` Max Reitz [this message]
2014-09-26 17:09 ` [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap Eric Blake
2014-09-26 22:15 ` Tony Breeds
2014-10-14 12:35 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54259CC2.20508@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbrady@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.