Re: [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms()

[John Fastabend <john.r.fastabend@intel.com>]

On 09/25/2014 12:06 PM, Cong Wang wrote:
> When kmemdup() fails, we should return -ENOMEM.
> 
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---

Acked-by: John Fastabend <john.r.fastabend@intel.com>

Thanks Cong.

>  net/sched/cls_tcindex.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
> index 5054fae..9d78fd7 100644
> --- a/net/sched/cls_tcindex.c
> +++ b/net/sched/cls_tcindex.c
> @@ -237,15 +237,14 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base,
>  	if (err < 0)
>  		return err;
>  
> +	err = -ENOMEM;
>  	/* tcindex_data attributes must look atomic to classifier/lookup so
>  	 * allocate new tcindex data and RCU assign it onto root. Keeping
>  	 * perfect hash and hash pointers from old data.
>  	 */
>  	cp = kzalloc(sizeof(*cp), GFP_KERNEL);
> -	if (!cp) {
> -		err = -ENOMEM;
> +	if (!cp)
>  		goto errout;
> -	}
>  
>  	cp->mask = p->mask;
>  	cp->shift = p->shift;
>