From: John Fastabend <john.fastabend@gmail.com>
To: John Fastabend <john.r.fastabend@intel.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms()
Date: Thu, 25 Sep 2014 15:57:29 -0700 [thread overview]
Message-ID: <54249DD9.5060403@gmail.com> (raw)
In-Reply-To: <5424842A.60802@intel.com>
On 09/25/2014 02:07 PM, John Fastabend wrote:
> On 09/25/2014 12:06 PM, Cong Wang wrote:
>> When kmemdup() fails, we should return -ENOMEM.
>>
>> Cc: John Fastabend <john.fastabend@gmail.com>
>> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>> ---
>
> Acked-by: John Fastabend <john.r.fastabend@intel.com>
>
> Thanks Cong.
>
Related to this we should probably push error messages
from the dump routines correctly. If you see u32_dump()
returns a -EINVAL even though it was due to a memory
allocation failure. This is not necessarily due to my
patches though I think the error returning from dump
has always been a simple -1 value.
I'll take a look at it, unless you beat me to it, after
I finish up the percpu stats which I'm doing now.
.John
--
John Fastabend Intel Corporation
next prev parent reply other threads:[~2014-09-25 22:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 19:06 [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms() Cong Wang
2014-09-25 19:06 ` [Patch net-next 2/2] net_sched: fix another regression in cls_tcindex Cong Wang
2014-09-25 21:18 ` John Fastabend
2014-09-28 21:35 ` David Miller
2014-09-25 21:07 ` [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms() John Fastabend
2014-09-25 22:57 ` John Fastabend [this message]
2014-09-26 0:27 ` John Fastabend
2014-09-28 21:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54249DD9.5060403@gmail.com \
--to=john.fastabend@gmail.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.