From: dietmar.eggemann@arm.com (Dietmar Eggemann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 5/6] sched: replace capacity_factor by usage
Date: Fri, 26 Sep 2014 15:00:24 +0100 [thread overview]
Message-ID: <54257178.8010900@arm.com> (raw)
In-Reply-To: <CAKfTPtAHP_U=C4s6MO-zcJkaEwJB_0VuZ=D6JnTYTeEt_EtBXQ@mail.gmail.com>
On 26/09/14 13:39, Vincent Guittot wrote:
> On 25 September 2014 21:19, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>> On 25/09/14 09:35, Vincent Guittot wrote:
>
> [snip]
>
>>>>
>>>> In case sgs->group_type is group_overloaded you could set
>>>> sgs->group_out_of_capacity to 1 without calling group_is_overloaded again.
>>>
>>> I prefer to keep sgs->group_out_of_capacity = group_is_overloaded(sgs,
>>> env) and use it in group_classify in case of future changes in the
>>> classification order
>>
>> Ok, but than group_is_overloaded is called twice at the end of
>> update_sg_lb_stats with exactly the same result. Looks weird in my traces.
>
> sorry i don't catch your point.
> group_is_overloaded() is called once for group_out_of_capacity which
> is then used in group_classify so it should be called only once
You're right, I made a mistake in my local setup while replacing this
patch with the new version. Problem doesn't exist any more.
>
>>
>>>
>> [...]
>>
>>
>
WARNING: multiple messages have this Message-ID (diff)
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: "peterz@infradead.org" <peterz@infradead.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"preeti@linux.vnet.ibm.com" <preeti@linux.vnet.ibm.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"riel@redhat.com" <riel@redhat.com>,
Morten Rasmussen <Morten.Rasmussen@arm.com>,
"efault@gmx.de" <efault@gmx.de>,
"nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"pjt@google.com" <pjt@google.com>,
"bsegall@google.com" <bsegall@google.com>
Subject: Re: [PATCH v6 5/6] sched: replace capacity_factor by usage
Date: Fri, 26 Sep 2014 15:00:24 +0100 [thread overview]
Message-ID: <54257178.8010900@arm.com> (raw)
In-Reply-To: <CAKfTPtAHP_U=C4s6MO-zcJkaEwJB_0VuZ=D6JnTYTeEt_EtBXQ@mail.gmail.com>
On 26/09/14 13:39, Vincent Guittot wrote:
> On 25 September 2014 21:19, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>> On 25/09/14 09:35, Vincent Guittot wrote:
>
> [snip]
>
>>>>
>>>> In case sgs->group_type is group_overloaded you could set
>>>> sgs->group_out_of_capacity to 1 without calling group_is_overloaded again.
>>>
>>> I prefer to keep sgs->group_out_of_capacity = group_is_overloaded(sgs,
>>> env) and use it in group_classify in case of future changes in the
>>> classification order
>>
>> Ok, but than group_is_overloaded is called twice at the end of
>> update_sg_lb_stats with exactly the same result. Looks weird in my traces.
>
> sorry i don't catch your point.
> group_is_overloaded() is called once for group_out_of_capacity which
> is then used in group_classify so it should be called only once
You're right, I made a mistake in my local setup while replacing this
patch with the new version. Problem doesn't exist any more.
>
>>
>>>
>> [...]
>>
>>
>
next prev parent reply other threads:[~2014-09-26 14:00 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 16:07 [PATCH v6 0/6] sched: consolidation of cpu_capacity Vincent Guittot
2014-09-23 16:07 ` Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 1/6] sched: add per rq cpu_capacity_orig Vincent Guittot
2014-09-23 16:08 ` Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 2/6] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2014-09-23 16:08 ` Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 3/6] sched: add utilization_avg_contrib Vincent Guittot
2014-09-23 16:08 ` Vincent Guittot
2014-10-03 14:15 ` Peter Zijlstra
2014-10-03 14:15 ` Peter Zijlstra
2014-10-03 14:44 ` Vincent Guittot
2014-10-03 14:44 ` Vincent Guittot
2014-10-03 14:36 ` Peter Zijlstra
2014-10-03 14:36 ` Peter Zijlstra
2014-10-03 14:51 ` Vincent Guittot
2014-10-03 14:51 ` Vincent Guittot
2014-10-03 15:14 ` Peter Zijlstra
2014-10-03 15:14 ` Peter Zijlstra
2014-10-03 16:05 ` Morten Rasmussen
2014-10-03 16:05 ` Morten Rasmussen
2014-09-23 16:08 ` [PATCH v6 4/6] sched: get CPU's usage statistic Vincent Guittot
2014-09-23 16:08 ` Vincent Guittot
2014-09-25 19:05 ` Dietmar Eggemann
2014-09-25 19:05 ` Dietmar Eggemann
2014-09-26 12:17 ` Vincent Guittot
2014-09-26 12:17 ` Vincent Guittot
2014-09-26 15:58 ` Morten Rasmussen
2014-09-26 15:58 ` Morten Rasmussen
2014-09-26 19:57 ` Dietmar Eggemann
2014-09-26 19:57 ` Dietmar Eggemann
2014-11-21 5:36 ` Wanpeng Li
2014-11-21 5:36 ` Wanpeng Li
2014-11-21 12:17 ` Vincent Guittot
2014-11-21 12:17 ` Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 5/6] sched: replace capacity_factor by usage Vincent Guittot
2014-09-23 16:08 ` Vincent Guittot
2014-09-24 17:48 ` Dietmar Eggemann
2014-09-24 17:48 ` Dietmar Eggemann
2014-09-25 8:35 ` Vincent Guittot
2014-09-25 8:35 ` Vincent Guittot
2014-09-25 19:19 ` Dietmar Eggemann
2014-09-25 19:19 ` Dietmar Eggemann
2014-09-26 12:39 ` Vincent Guittot
2014-09-26 12:39 ` Vincent Guittot
2014-09-26 14:00 ` Dietmar Eggemann [this message]
2014-09-26 14:00 ` Dietmar Eggemann
2014-09-25 8:38 ` Vincent Guittot
2014-09-25 8:38 ` Vincent Guittot
2014-09-29 13:39 ` Dietmar Eggemann
2014-09-29 13:39 ` Dietmar Eggemann
2014-10-02 16:57 ` Morten Rasmussen
2014-10-02 16:57 ` Morten Rasmussen
2014-10-03 7:24 ` Vincent Guittot
2014-10-03 7:24 ` Vincent Guittot
2014-10-03 9:35 ` Morten Rasmussen
2014-10-03 9:35 ` Morten Rasmussen
2014-10-03 12:50 ` Vincent Guittot
2014-10-03 12:50 ` Vincent Guittot
2014-11-23 0:22 ` Wanpeng Li
2014-11-23 0:22 ` Wanpeng Li
2014-11-24 8:26 ` Vincent Guittot
2014-11-24 8:26 ` Vincent Guittot
2014-10-03 15:38 ` Peter Zijlstra
2014-10-03 15:38 ` Peter Zijlstra
2014-10-06 8:55 ` Vincent Guittot
2014-10-06 8:55 ` Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 6/6] sched: add SD_PREFER_SIBLING for SMT level Vincent Guittot
2014-09-23 16:08 ` Vincent Guittot
2014-09-24 12:27 ` Preeti U Murthy
2014-09-24 12:27 ` Preeti U Murthy
2014-09-25 12:10 ` Vincent Guittot
2014-09-25 12:10 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54257178.8010900@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.