[U-Boot] [PATCH 1/2] powerpc/mpc85xx: modify erratum A007186

[U-Boot] [PATCH 1/2] powerpc/mpc85xx: modify erratum A007186

[Zhao Qiang]

T2080 v1.0 has this errata while v1.1 has fixed
this errata by hardware, add a new function to
check the SVR_SOC_VER, SVR_MAJ and SVR_MIN first,
if the cpu is T2080 and version is not v1.0, doesn't
run the a007186 errata_workaround.

Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
 arch/powerpc/cpu/mpc85xx/cmd_errata.c          |   3 +-
 arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c | 210 ++++++++++++++-----------
 arch/powerpc/include/asm/fsl_errata.h          |  14 ++
 3 files changed, 130 insertions(+), 97 deletions(-)

diff --git a/arch/powerpc/cpu/mpc85xx/cmd_errata.c b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
index 3a04a89..741eb63 100644
--- a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
+++ b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
@@ -270,7 +270,8 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	puts("Work-around for Erratum USB14 enabled\n");
 #endif
 #ifdef CONFIG_SYS_FSL_ERRATUM_A007186
-	puts("Work-around for Erratum A007186 enabled\n");
+	if (!not_has_erratum_a007186())
+		puts("Work-around for Erratum A007186 enabled\n");
 #endif
 #ifdef CONFIG_SYS_FSL_ERRATUM_A006593
 	puts("Work-around for Erratum A006593 enabled\n");
diff --git a/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c b/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c
index d1fc76a..9b0a538 100644
--- a/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c
+++ b/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c
@@ -11,6 +11,7 @@
 #include <asm/processor.h>
 #include <asm/fsl_law.h>
 #include <asm/errno.h>
+#include <asm/fsl_errata.h>
 #include "fsl_corenet2_serdes.h"
 
 #ifdef CONFIG_SYS_FSL_SRDS_1
@@ -203,108 +204,125 @@ u64 serdes_init(u32 sd, u32 sd_addr, u32 sd_prctl_mask, u32 sd_prctl_shift)
  * This workaround for the protocols and rates that only have the Ring VCO.
  */
 #ifdef CONFIG_SYS_FSL_ERRATUM_A007186
-	sfp_spfr0 = in_be32(&sfp_regs->fsl_spfr0);
-	debug("A007186: sfp_spfr0= %x\n", sfp_spfr0);
+	if (!not_has_erratum_a007186()) {
+		sfp_spfr0 = in_be32(&sfp_regs->fsl_spfr0);
+		debug("A007186: sfp_spfr0= %x\n", sfp_spfr0);
 
-	sel = (sfp_spfr0 >> FUSE_VAL_SHIFT) & FUSE_VAL_MASK;
+		sel = (sfp_spfr0 >> FUSE_VAL_SHIFT) & FUSE_VAL_MASK;
 
-	if (sel == 0x01 || sel == 0x02) {
-		for (pll_num = 0; pll_num < SRDS_MAX_BANK; pll_num++) {
-			pll_status = in_be32(&srds_regs->bank[pll_num].pllcr0);
-			debug("A007186: pll_num=%x pllcr0=%x\n",
-			      pll_num, pll_status);
-			/* STEP 1 */
-			/* Read factory pre-set SerDes calibration values
-			 * from fuse block(SFP scratch register-sfp_spfr0)
-			 */
-			switch (pll_status & SRDS_PLLCR0_FRATE_SEL_MASK) {
-			case SRDS_PLLCR0_FRATE_SEL_3_0:
-			case SRDS_PLLCR0_FRATE_SEL_3_072:
-				debug("A007186: 3.0/3.072 protocol rate\n");
-				bc = (sfp_spfr0 >> BC1_SHIFT) & BC_MASK;
-				dc = (sfp_spfr0 >> DC1_SHIFT) & DC_MASK;
-				fc = (sfp_spfr0 >> FC1_SHIFT) & FC_MASK;
-				break;
-			case SRDS_PLLCR0_FRATE_SEL_3_125:
-				debug("A007186: 3.125 protocol rate\n");
-				bc = (sfp_spfr0 >> BC2_SHIFT) & BC_MASK;
-				dc = (sfp_spfr0 >> DC2_SHIFT) & DC_MASK;
-				fc = (sfp_spfr0 >> FC2_SHIFT) & FC_MASK;
-				break;
-			case SRDS_PLLCR0_FRATE_SEL_3_75:
-				debug("A007186: 3.75 protocol rate\n");
-				bc = (sfp_spfr0 >> BC1_SHIFT) & BC_MASK;
-				dc = (sfp_spfr0 >> DC1_SHIFT) & DC_MASK;
-				fc = (sfp_spfr0 >> FC1_SHIFT) & FC_MASK;
-				break;
-			default:
-				continue;
-			}
+		if (sel == 0x01 || sel == 0x02) {
+			for (pll_num = 0; pll_num < SRDS_MAX_BANK; pll_num++) {
+				pll_status = in_be32(&srds_regs->
+						     bank[pll_num].pllcr0);
+				debug("A007186: pll_num=%x pllcr0=%x\n",
+				      pll_num, pll_status);
+				/* STEP 1 */
+				/* Read factory pre-set SerDes calibration
+				 * values from fuse block(SFP scratch
+				 * register-sfp_spfr0)
+				 */
+				switch (pll_status &
+					SRDS_PLLCR0_FRATE_SEL_MASK) {
+				case SRDS_PLLCR0_FRATE_SEL_3_0:
+				case SRDS_PLLCR0_FRATE_SEL_3_072:
+					debug("A007186: ");
+					debug("3.0/3.072 protocol rate\n");
+					bc = (sfp_spfr0 >> BC1_SHIFT) & BC_MASK;
+					dc = (sfp_spfr0 >> DC1_SHIFT) & DC_MASK;
+					fc = (sfp_spfr0 >> FC1_SHIFT) & FC_MASK;
+					break;
+				case SRDS_PLLCR0_FRATE_SEL_3_125:
+					debug("A007186: 3.125 protocol rate\n");
+					bc = (sfp_spfr0 >> BC2_SHIFT) & BC_MASK;
+					dc = (sfp_spfr0 >> DC2_SHIFT) & DC_MASK;
+					fc = (sfp_spfr0 >> FC2_SHIFT) & FC_MASK;
+					break;
+				case SRDS_PLLCR0_FRATE_SEL_3_75:
+					debug("A007186: 3.75 protocol rate\n");
+					bc = (sfp_spfr0 >> BC1_SHIFT) & BC_MASK;
+					dc = (sfp_spfr0 >> DC1_SHIFT) & DC_MASK;
+					fc = (sfp_spfr0 >> FC1_SHIFT) & FC_MASK;
+					break;
+				default:
+					continue;
+				}
 
-			/* STEP 2 */
-			/* Write SRDSxPLLnCR1[11:16] = FC
-			 * Write SRDSxPLLnCR1[2] = BC
-			 */
-			pll_cr1 = in_be32(&srds_regs->bank[pll_num].pllcr1);
-			pll_cr_upd = (((bc << CR1_BCAP_SHIFT) & BCAP_MASK) |
-				      ((fc << CR1_FCAP_SHIFT) & FCAP_MASK));
-			out_be32(&srds_regs->bank[pll_num].pllcr1,
-				 (pll_cr_upd | pll_cr1));
-			debug("A007186: pll_num=%x Updated PLLCR1=%x\n",
-			      pll_num, (pll_cr_upd | pll_cr1));
-			/* Write SRDSxPLLnCR0[24:26] = DC
-			 */
-			pll_cr0 = in_be32(&srds_regs->bank[pll_num].pllcr0);
-			out_be32(&srds_regs->bank[pll_num].pllcr0,
-				 pll_cr0 | (dc << CR0_DCBIAS_SHIFT));
-			debug("A007186: pll_num=%x, Updated PLLCR0=%x\n",
-			      pll_num, (pll_cr0 | (dc << CR0_DCBIAS_SHIFT)));
-			/* Write SRDSxPLLnCR1[3] = 1
-			 * Write SRDSxPLLnCR1[6] = 1
-			 */
-			pll_cr1 = in_be32(&srds_regs->bank[pll_num].pllcr1);
-			pll_cr_upd = (BCAP_OVD_MASK | BYP_CAL_MASK);
-			out_be32(&srds_regs->bank[pll_num].pllcr1,
-				 (pll_cr_upd | pll_cr1));
-			debug("A007186: pll_num=%x Updated PLLCR1=%x\n",
-			      pll_num, (pll_cr_upd | pll_cr1));
+				/* STEP 2 */
+				/* Write SRDSxPLLnCR1[11:16] = FC
+				 * Write SRDSxPLLnCR1[2] = BC
+				 */
+				pll_cr1 = in_be32(&srds_regs->
+						  bank[pll_num].pllcr1);
+				pll_cr_upd = (((bc << CR1_BCAP_SHIFT) &
+					      BCAP_MASK) |
+					      ((fc << CR1_FCAP_SHIFT) &
+					      FCAP_MASK));
+				out_be32(&srds_regs->bank[pll_num].pllcr1,
+					 (pll_cr_upd | pll_cr1));
+				debug("A007186: pll_num=%x Updated PLLCR1=%x\n",
+				      pll_num, (pll_cr_upd | pll_cr1));
+				/* Write SRDSxPLLnCR0[24:26] = DC
+				 */
+				pll_cr0 = in_be32(&srds_regs->
+						  bank[pll_num].pllcr0);
+				out_be32(&srds_regs->bank[pll_num].pllcr0,
+					 pll_cr0 | (dc << CR0_DCBIAS_SHIFT));
+				debug("A007186: pll_num=%x, Update PLLCR0=%x\n",
+				      pll_num,
+				      (pll_cr0 | (dc << CR0_DCBIAS_SHIFT)));
+				/* Write SRDSxPLLnCR1[3] = 1
+				 * Write SRDSxPLLnCR1[6] = 1
+				 */
+				pll_cr1 = in_be32(&srds_regs->
+						  bank[pll_num].pllcr1);
+				pll_cr_upd = (BCAP_OVD_MASK | BYP_CAL_MASK);
+				out_be32(&srds_regs->bank[pll_num].pllcr1,
+					 (pll_cr_upd | pll_cr1));
+				debug("A007186: pll_num=%x Updated PLLCR1=%x\n",
+				      pll_num, (pll_cr_upd | pll_cr1));
 
-			/* STEP 3 */
-			/* Read the status Registers */
-			/* Verify SRDSxPLLnSR2[8] = BC */
-			pll_sr2 = in_be32(&srds_regs->bank[pll_num].pllsr2);
-			debug("A007186: pll_num=%x pllsr2=%x\n",
-			      pll_num, pll_sr2);
-			bc_status = (pll_sr2 >> 23) & BC_MASK;
-			if (bc_status != bc)
-				debug("BC mismatch\n");
-			fc_status = (pll_sr2 >> 16) & FC_MASK;
-			if (fc_status != fc)
-				debug("FC mismatch\n");
-			pll_cr0 = in_be32(&srds_regs->bank[pll_num].pllcr0);
-			out_be32(&srds_regs->bank[pll_num].pllcr0, pll_cr0 |
-								0x02000000);
-			pll_sr2 = in_be32(&srds_regs->bank[pll_num].pllsr2);
-			dc_status = (pll_sr2 >> 17) & DC_MASK;
-			if (dc_status != dc)
-				debug("DC mismatch\n");
-			pll_cr0 = in_be32(&srds_regs->bank[pll_num].pllcr0);
-			out_be32(&srds_regs->bank[pll_num].pllcr0, pll_cr0 &
-								0xfdffffff);
+				/* STEP 3 */
+				/* Read the status Registers */
+				/* Verify SRDSxPLLnSR2[8] = BC */
+				pll_sr2 = in_be32(&srds_regs->
+						  bank[pll_num].pllsr2);
+				debug("A007186: pll_num=%x pllsr2=%x\n",
+				      pll_num, pll_sr2);
+				bc_status = (pll_sr2 >> 23) & BC_MASK;
+				if (bc_status != bc)
+					debug("BC mismatch\n");
+				fc_status = (pll_sr2 >> 16) & FC_MASK;
+				if (fc_status != fc)
+					debug("FC mismatch\n");
+				pll_cr0 = in_be32(&srds_regs->
+						  bank[pll_num].pllcr0);
+				out_be32(&srds_regs->bank[pll_num].pllcr0,
+					 pll_cr0 | 0x02000000);
+				pll_sr2 = in_be32(&srds_regs->
+						  bank[pll_num].pllsr2);
+				dc_status = (pll_sr2 >> 17) & DC_MASK;
+				if (dc_status != dc)
+					debug("DC mismatch\n");
+				pll_cr0 = in_be32(&srds_regs->
+						  bank[pll_num].pllcr0);
+				out_be32(&srds_regs->bank[pll_num].pllcr0,
+					 pll_cr0 & 0xfdffffff);
 
-			/* STEP 4 */
-			/* Wait 750us to verify the PLL is locked
-			 * by checking SRDSxPLLnCR0[8] = 1.
-			 */
-			udelay(750);
-			pll_status = in_be32(&srds_regs->bank[pll_num].pllcr0);
-			debug("A007186: pll_num=%x pllcr0=%x\n",
-			      pll_num, pll_status);
+				/* STEP 4 */
+				/* Wait 750us to verify the PLL is locked
+				 * by checking SRDSxPLLnCR0[8] = 1.
+				 */
+				udelay(750);
+				pll_status = in_be32(&srds_regs->
+						     bank[pll_num].pllcr0);
+				debug("A007186: pll_num=%x pllcr0=%x\n",
+				      pll_num, pll_status);
 
-			if ((pll_status & SRDS_PLLCR0_PLL_LCK) == 0)
-				printf("A007186 Serdes PLL not locked\n");
-			else
-				debug("A007186 Serdes PLL locked\n");
+				if ((pll_status & SRDS_PLLCR0_PLL_LCK) == 0)
+					debug("A007186 Serdes PLL not lock\n");
+				else
+					debug("A007186 Serdes PLL lock\n");
+			}
 		}
 	}
 #endif
diff --git a/arch/powerpc/include/asm/fsl_errata.h b/arch/powerpc/include/asm/fsl_errata.h
index 64da4bb..a977544 100644
--- a/arch/powerpc/include/asm/fsl_errata.h
+++ b/arch/powerpc/include/asm/fsl_errata.h
@@ -82,3 +82,17 @@ static inline bool has_erratum_a007075(void)
 	return false;
 }
 #endif
+
+#ifdef CONFIG_SYS_FSL_ERRATUM_A007186
+static inline bool not_has_erratum_a007186(void)
+{
+	u32 svr = get_svr();
+	u32 soc = SVR_SOC_VER(svr);
+
+	if (((soc == SVR_T2080) && (SVR_MAJ(svr) > 1)) ||
+	    ((soc == SVR_T2080) && (SVR_MAJ(svr) == 1) && (SVR_MIN(svr) > 0)))
+		return true;
+
+	return false;
+}
+#endif
-- 
2.1.0.27.g96db324

[U-Boot] [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212

[Zhao Qiang]

T2080 v1.0 has this errata while v1.1 has fixed
this errata by hardware, add a new function to
check the SVR_SOC_VER, SVR_MAJ and SVR_MIN first,
if the cpu is T2080 and version is not v1.0, doesn't
run the a007212 errata_workaround.

Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
 arch/powerpc/cpu/mpc85xx/cmd_errata.c |  2 +-
 arch/powerpc/cpu/mpc85xx/cpu_init.c   |  2 ++
 arch/powerpc/cpu/mpc85xx/speed.c      |  3 ++-
 arch/powerpc/include/asm/fsl_errata.h | 14 ++++++++++++++
 4 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/cpu/mpc85xx/cmd_errata.c b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
index 741eb63..a50bb08 100644
--- a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
+++ b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
@@ -121,7 +121,7 @@ static void check_erratum_a007212(void)
 {
 	u32 __iomem *plldgdcr = (void *)(CONFIG_SYS_DCSRBAR + 0x21c20);
 
-	if (in_be32(plldgdcr) & 0x1fe) {
+	if (!not_has_erratum_a007212() && in_be32(plldgdcr) & 0x1fe) {
 		/* check if PLL ratio is set by workaround */
 		puts("Work-around for Erratum A007212 enabled\n");
 	}
diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c b/arch/powerpc/cpu/mpc85xx/cpu_init.c
index 78316a6..6219619 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu_init.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c
@@ -345,6 +345,8 @@ void fsl_erratum_a007212_workaround(void)
 	u32 __iomem *plldadcr3 = (void *)(CONFIG_SYS_DCSRBAR + 0x21c68);
 #endif
 #endif
+	if (not_has_erratum_a007212())
+		return;
 	/*
 	 * Even this workaround applies to selected version of SoCs, it is
 	 * safe to apply to all versions, with the limitation of odd ratios.
diff --git a/arch/powerpc/cpu/mpc85xx/speed.c b/arch/powerpc/cpu/mpc85xx/speed.c
index 3236f6a..904d19d 100644
--- a/arch/powerpc/cpu/mpc85xx/speed.c
+++ b/arch/powerpc/cpu/mpc85xx/speed.c
@@ -13,6 +13,7 @@
 #include <common.h>
 #include <ppc_asm.tmpl>
 #include <linux/compiler.h>
+#include <asm/fsl_errata.h>
 #include <asm/processor.h>
 #include <asm/io.h>
 
@@ -113,7 +114,7 @@ void get_sys_info(sys_info_t *sys_info)
 			FSL_CORENET_RCWSR0_MEM_PLL_RAT_SHIFT)
 			& FSL_CORENET_RCWSR0_MEM_PLL_RAT_MASK;
 #ifdef CONFIG_SYS_FSL_ERRATUM_A007212
-	if (mem_pll_rat == 0) {
+	if (!not_has_erratum_a007212() && mem_pll_rat == 0) {
 		mem_pll_rat = (in_be32(&gur->rcwsr[0]) >>
 			FSL_CORENET_RCWSR0_MEM_PLL_RAT_RESV_SHIFT) &
 			FSL_CORENET_RCWSR0_MEM_PLL_RAT_MASK;
diff --git a/arch/powerpc/include/asm/fsl_errata.h b/arch/powerpc/include/asm/fsl_errata.h
index a977544..8f7777d 100644
--- a/arch/powerpc/include/asm/fsl_errata.h
+++ b/arch/powerpc/include/asm/fsl_errata.h
@@ -96,3 +96,17 @@ static inline bool not_has_erratum_a007186(void)
 	return false;
 }
 #endif
+
+#ifdef CONFIG_SYS_FSL_ERRATUM_A007212
+static inline bool not_has_erratum_a007212(void)
+{
+	u32 svr = get_svr();
+	u32 soc = SVR_SOC_VER(svr);
+
+	if (((soc == SVR_T2080) && (SVR_MAJ(svr) > 1)) ||
+	    ((soc == SVR_T2080) && (SVR_MAJ(svr) == 1) && (SVR_MIN(svr) > 0)))
+		return true;
+
+	return false;
+}
+#endif
-- 
2.1.0.27.g96db324

[U-Boot] [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212

[York Sun]

On 9/25/14 9:37 PM, "Zhao Qiang" <B45475@freescale.com> wrote:

>T2080 v1.0 has this errata while v1.1 has fixed
>this errata by hardware, add a new function to
>check the SVR_SOC_VER, SVR_MAJ and SVR_MIN first,
>if the cpu is T2080 and version is not v1.0, doesn't
>run the a007212 errata_workaround.
>
>Signed-off-by: Zhao Qiang <B45475@freescale.com>
>---


Qiang,

I don't agree with your analysis.

This workaround has two parts. One part is to to disable DDR PLL in RCW.
The second part is to detect DDR PLL is disabled and to implement the
software workaround to bring DDR up. U-boot has the second part, it is
safe to apply to all versions for affected SoC. I put in the comments.
Your patch detects the SVR and decide if the workaround should be applied.
This is wrong. It should detect if DDR PLL is disabled. In case an old RCW
is used, you don't want to end up with a dead board because DDR is
disabled.

York

[U-Boot] [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212

[qiang.zhao at freescale.com]

On 9/26/14 1:01 PM, York Sun wrote:

> -----Original Message-----
> From: Sun York-R58495
> Sent: Friday, September 26, 2014 1:01 PM
> To: Zhao Qiang-B45475; u-boot at lists.denx.de
> Cc: Xie Xiaobo-R63061; Zhao Qiang-B45475
> Subject: Re: [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212
> 
> On 9/25/14 9:37 PM, "Zhao Qiang" <B45475@freescale.com> wrote:
> 
> >T2080 v1.0 has this errata while v1.1 has fixed this errata by
> >hardware, add a new function to check the SVR_SOC_VER, SVR_MAJ and
> >SVR_MIN first, if the cpu is T2080 and version is not v1.0, doesn't run
> >the a007212 errata_workaround.
> >
> >Signed-off-by: Zhao Qiang <B45475@freescale.com>
> >---
> 
> 
> Qiang,
> 
> I don't agree with your analysis.
> 
> This workaround has two parts. One part is to to disable DDR PLL in RCW.
> The second part is to detect DDR PLL is disabled and to implement the
> software workaround to bring DDR up. U-boot has the second part, it is
> safe to apply to all versions for affected SoC. I put in the comments.
> Your patch detects the SVR and decide if the workaround should be applied.
> This is wrong. It should detect if DDR PLL is disabled. In case an old
> RCW is used, you don't want to end up with a dead board because DDR is
> disabled.

OK , got it , I will modify it for v2.
Thanks for you comment.

> 
> York
Best Regards
Zhao Qiang

[U-Boot] [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212

[York Sun]

On 09/25/2014 10:55 PM, Zhao Qiang-B45475 wrote:
> 
> On 9/26/14 1:01 PM, York Sun wrote:
> 
>> -----Original Message-----
>> From: Sun York-R58495
>> Sent: Friday, September 26, 2014 1:01 PM
>> To: Zhao Qiang-B45475; u-boot at lists.denx.de
>> Cc: Xie Xiaobo-R63061; Zhao Qiang-B45475
>> Subject: Re: [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212
>>
>> On 9/25/14 9:37 PM, "Zhao Qiang" <B45475@freescale.com> wrote:
>>
>>> T2080 v1.0 has this errata while v1.1 has fixed this errata by
>>> hardware, add a new function to check the SVR_SOC_VER, SVR_MAJ and
>>> SVR_MIN first, if the cpu is T2080 and version is not v1.0, doesn't run
>>> the a007212 errata_workaround.
>>>
>>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
>>> ---
>>
>>
>> Qiang,
>>
>> I don't agree with your analysis.
>>
>> This workaround has two parts. One part is to to disable DDR PLL in RCW.
>> The second part is to detect DDR PLL is disabled and to implement the
>> software workaround to bring DDR up. U-boot has the second part, it is
>> safe to apply to all versions for affected SoC. I put in the comments.
>> Your patch detects the SVR and decide if the workaround should be applied.
>> This is wrong. It should detect if DDR PLL is disabled. In case an old
>> RCW is used, you don't want to end up with a dead board because DDR is
>> disabled.
> 
> OK , got it , I will modify it for v2.
> Thanks for you comment.
> 

Qiang,

I don't think you even need a patch for this. The logic for u-boot code is:

Regardless of the SVR, the workaround is not be applied if RCW doesn't disable
DDR PLL.
Regardless of the SVR, the workaround is and should be applied if RCW disables
DDR PLL.

York

[U-Boot] [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212

[qiang.zhao at freescale.com]

On 09/27/2014 12:02 AM, York Sun wrote:
> -----Original Message-----
> From: Sun York-R58495
> Sent: Saturday, September 27, 2014 12:02 AM
> To: Zhao Qiang-B45475; u-boot at lists.denx.de
> Cc: Xie Xiaobo-R63061
> Subject: Re: [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212
> 
> On 09/25/2014 10:55 PM, Zhao Qiang-B45475 wrote:
> >
> > On 9/26/14 1:01 PM, York Sun wrote:
> >
> >> -----Original Message-----
> >> From: Sun York-R58495
> >> Sent: Friday, September 26, 2014 1:01 PM
> >> To: Zhao Qiang-B45475; u-boot at lists.denx.de
> >> Cc: Xie Xiaobo-R63061; Zhao Qiang-B45475
> >> Subject: Re: [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212
> >>
> >> On 9/25/14 9:37 PM, "Zhao Qiang" <B45475@freescale.com> wrote:
> >>
> >>> T2080 v1.0 has this errata while v1.1 has fixed this errata by
> >>> hardware, add a new function to check the SVR_SOC_VER, SVR_MAJ and
> >>> SVR_MIN first, if the cpu is T2080 and version is not v1.0, doesn't
> >>> run the a007212 errata_workaround.
> >>>
> >>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> >>> ---
> >>
> >>
> >> Qiang,
> >>
> >> I don't agree with your analysis.
> >>
> >> This workaround has two parts. One part is to to disable DDR PLL in
> RCW.
> >> The second part is to detect DDR PLL is disabled and to implement the
> >> software workaround to bring DDR up. U-boot has the second part, it
> >> is safe to apply to all versions for affected SoC. I put in the
> comments.
> >> Your patch detects the SVR and decide if the workaround should be
> applied.
> >> This is wrong. It should detect if DDR PLL is disabled. In case an
> >> old RCW is used, you don't want to end up with a dead board because
> >> DDR is disabled.
> >
> > OK , got it , I will modify it for v2.
> > Thanks for you comment.
> >
> 
> Qiang,
> 
> I don't think you even need a patch for this. The logic for u-boot code
> is:
> 
> Regardless of the SVR, the workaround is not be applied if RCW doesn't
> disable DDR PLL.
> Regardless of the SVR, the workaround is and should be applied if RCW
> disables DDR PLL.

And how about the file arch/powerpc/cpu/mpc85xx/speed.c.
The code doesn't detect if the DDR PLL is disabled, it will config the mem_pll_rat.

> 
> York
Best Regards
Zhao Qiang

[U-Boot] [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212

[York Sun]

On 9/27/14 6:56 PM, "Zhao Qiang-B45475" <qiang.zhao@freescale.com> wrote:

>On 09/27/2014 12:02 AM, York Sun wrote:
>> -----Original Message-----
>> From: Sun York-R58495
>> Sent: Saturday, September 27, 2014 12:02 AM
>> To: Zhao Qiang-B45475; u-boot at lists.denx.de
>> Cc: Xie Xiaobo-R63061
>> Subject: Re: [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212
>> 
>> On 09/25/2014 10:55 PM, Zhao Qiang-B45475 wrote:
>> >
>> > On 9/26/14 1:01 PM, York Sun wrote:
>> >
>> >> -----Original Message-----
>> >> From: Sun York-R58495
>> >> Sent: Friday, September 26, 2014 1:01 PM
>> >> To: Zhao Qiang-B45475; u-boot at lists.denx.de
>> >> Cc: Xie Xiaobo-R63061; Zhao Qiang-B45475
>> >> Subject: Re: [PATCH 2/2] powerpc/mpc85xx: modify erratum A007212
>> >>
>> >> On 9/25/14 9:37 PM, "Zhao Qiang" <B45475@freescale.com> wrote:
>> >>
>> >>> T2080 v1.0 has this errata while v1.1 has fixed this errata by
>> >>> hardware, add a new function to check the SVR_SOC_VER, SVR_MAJ and
>> >>> SVR_MIN first, if the cpu is T2080 and version is not v1.0, doesn't
>> >>> run the a007212 errata_workaround.
>> >>>
>> >>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
>> >>> ---
>> >>
>> >>
>> >> Qiang,
>> >>
>> >> I don't agree with your analysis.
>> >>
>> >> This workaround has two parts. One part is to to disable DDR PLL in
>> RCW.
>> >> The second part is to detect DDR PLL is disabled and to implement the
>> >> software workaround to bring DDR up. U-boot has the second part, it
>> >> is safe to apply to all versions for affected SoC. I put in the
>> comments.
>> >> Your patch detects the SVR and decide if the workaround should be
>> applied.
>> >> This is wrong. It should detect if DDR PLL is disabled. In case an
>> >> old RCW is used, you don't want to end up with a dead board because
>> >> DDR is disabled.
>> >
>> > OK , got it , I will modify it for v2.
>> > Thanks for you comment.
>> >
>> 
>> Qiang,
>> 
>> I don't think you even need a patch for this. The logic for u-boot code
>> is:
>> 
>> Regardless of the SVR, the workaround is not be applied if RCW doesn't
>> disable DDR PLL.
>> Regardless of the SVR, the workaround is and should be applied if RCW
>> disables DDR PLL.
>
>And how about the file arch/powerpc/cpu/mpc85xx/speed.c.
>The code doesn?t detect if the DDR PLL is disabled, it will config the
>mem_pll_rat.

If you look closely in this file, you will see code guarded by macro
CONFIG_SYS_FSL_ERRATUM_A007212. In case mem_pll_rat is detected as 0, a
reserved field is used for DDR PLL ratio. It is written in erratum
workaround. It wasn't in original document but should be updated a while
ago.

York

>>

[U-Boot] [PATCH 1/2] powerpc/mpc85xx: modify erratum A007186

[York Sun]

On 09/25/2014 09:37 PM, Zhao Qiang wrote:
> T2080 v1.0 has this errata while v1.1 has fixed
> this errata by hardware, add a new function to
> check the SVR_SOC_VER, SVR_MAJ and SVR_MIN first,
> if the cpu is T2080 and version is not v1.0, doesn't
> run the a007186 errata_workaround.
> 
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
>  arch/powerpc/cpu/mpc85xx/cmd_errata.c          |   3 +-
>  arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c | 210 ++++++++++++++-----------
>  arch/powerpc/include/asm/fsl_errata.h          |  14 ++
>  3 files changed, 130 insertions(+), 97 deletions(-)
> 
> diff --git a/arch/powerpc/cpu/mpc85xx/cmd_errata.c b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
> index 3a04a89..741eb63 100644
> --- a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
> +++ b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
> @@ -270,7 +270,8 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  	puts("Work-around for Erratum USB14 enabled\n");
>  #endif
>  #ifdef CONFIG_SYS_FSL_ERRATUM_A007186
> -	puts("Work-around for Erratum A007186 enabled\n");
> +	if (!not_has_erratum_a007186())
> +		puts("Work-around for Erratum A007186 enabled\n");

Please use positive logic.


>  #endif
>  #ifdef CONFIG_SYS_FSL_ERRATUM_A006593
>  	puts("Work-around for Erratum A006593 enabled\n");
> diff --git a/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c b/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c
> index d1fc76a..9b0a538 100644
> --- a/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c
> +++ b/arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c
> @@ -11,6 +11,7 @@
>  #include <asm/processor.h>
>  #include <asm/fsl_law.h>
>  #include <asm/errno.h>
> +#include <asm/fsl_errata.h>
>  #include "fsl_corenet2_serdes.h"
>  
>  #ifdef CONFIG_SYS_FSL_SRDS_1
> @@ -203,108 +204,125 @@ u64 serdes_init(u32 sd, u32 sd_addr, u32 sd_prctl_mask, u32 sd_prctl_shift)
>   * This workaround for the protocols and rates that only have the Ring VCO.
>   */
>  #ifdef CONFIG_SYS_FSL_ERRATUM_A007186
> -	sfp_spfr0 = in_be32(&sfp_regs->fsl_spfr0);
> -	debug("A007186: sfp_spfr0= %x\n", sfp_spfr0);
> +	if (!not_has_erratum_a007186()) {
> +		sfp_spfr0 = in_be32(&sfp_regs->fsl_spfr0);
> +		debug("A007186: sfp_spfr0= %x\n", sfp_spfr0);
>  
> -	sel = (sfp_spfr0 >> FUSE_VAL_SHIFT) & FUSE_VAL_MASK;
> +		sel = (sfp_spfr0 >> FUSE_VAL_SHIFT) & FUSE_VAL_MASK;
>  
> -	if (sel == 0x01 || sel == 0x02) {

Can you put the checking of has_erratum_a007186() here? You may be able to avoid
the indentation change below.

York