From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: kbuild test robot <lkp@intel.com>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
zmxu@marvell.com, jszhang@marvell.com,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
kbuild-all@01.org, ezequiel.garcia@free-electrons.com,
computersforpeace@gmail.com, dwmw2@infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v3 1/4] mtd: nand: allow compile test of MTD_NAND_PXA3xx
Date: Thu, 15 Oct 2015 13:44:19 +0200 [thread overview]
Message-ID: <5425922.4Qu1HbLqzM@wuerfel> (raw)
In-Reply-To: <201510151736.7t9qDlAe%fengguang.wu@intel.com>
On Thursday 15 October 2015 17:12:18 kbuild test robot wrote:
> drivers/mtd/nand/pxa3xx_nand.c: In function 'drain_fifo':
> >> drivers/mtd/nand/pxa3xx_nand.c:507:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration]
> readsl(info->mmio_base + NDDB, data, 8);
> ^
It should be easy to fix this by changing the code to use ioread32_rep() instead
of readsl(). They behave the same way on pointers returned from ioremap() etc,
and the other one is available on all architectures.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] mtd: nand: allow compile test of MTD_NAND_PXA3xx
Date: Thu, 15 Oct 2015 13:44:19 +0200 [thread overview]
Message-ID: <5425922.4Qu1HbLqzM@wuerfel> (raw)
In-Reply-To: <201510151736.7t9qDlAe%fengguang.wu@intel.com>
On Thursday 15 October 2015 17:12:18 kbuild test robot wrote:
> drivers/mtd/nand/pxa3xx_nand.c: In function 'drain_fifo':
> >> drivers/mtd/nand/pxa3xx_nand.c:507:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration]
> readsl(info->mmio_base + NDDB, data, 8);
> ^
It should be easy to fix this by changing the code to use ioread32_rep() instead
of readsl(). They behave the same way on pointers returned from ioremap() etc,
and the other one is available on all architectures.
Arnd
next prev parent reply other threads:[~2015-10-15 11:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 7:17 [PATCH v3 0/4] mtd: pxa3xx_nand: rework the timing setup Antoine Tenart
2015-10-15 7:17 ` Antoine Tenart
2015-10-15 7:17 ` [PATCH v3 1/4] mtd: nand: allow compile test of MTD_NAND_PXA3xx Antoine Tenart
2015-10-15 7:17 ` Antoine Tenart
2015-10-15 9:12 ` kbuild test robot
2015-10-15 9:12 ` kbuild test robot
2015-10-15 11:44 ` Arnd Bergmann [this message]
2015-10-15 11:44 ` Arnd Bergmann
2015-10-15 11:52 ` Antoine Tenart
2015-10-15 11:52 ` Antoine Tenart
2015-10-15 7:17 ` [PATCH v3 2/4] mtd: pxa3xx_nand: add helpers to setup the timings Antoine Tenart
2015-10-15 7:17 ` Antoine Tenart
2015-10-17 13:57 ` Ezequiel Garcia
2015-10-17 13:57 ` Ezequiel Garcia
2015-10-19 9:32 ` Antoine Tenart
2015-10-19 9:32 ` Antoine Tenart
2015-10-15 7:17 ` [PATCH v3 3/4] mtd: pxa3xx_nand: rework flash detection and timing setup Antoine Tenart
2015-10-15 7:17 ` Antoine Tenart
2015-10-17 14:01 ` Ezequiel Garcia
2015-10-17 14:01 ` Ezequiel Garcia
2015-10-19 9:32 ` Antoine Tenart
2015-10-19 9:32 ` Antoine Tenart
2015-10-15 7:17 ` [PATCH v3 4/4] mtd: pxa3xx_nand: clean up the pxa3xx timings Antoine Tenart
2015-10-15 7:17 ` Antoine Tenart
2015-10-15 18:30 ` [PATCH v3 0/4] mtd: pxa3xx_nand: rework the timing setup Ezequiel Garcia
2015-10-15 18:30 ` Ezequiel Garcia
2015-10-16 6:38 ` Antoine Tenart
2015-10-16 6:38 ` Antoine Tenart
2015-10-20 19:30 ` Robert Jarzmik
2015-10-20 19:30 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5425922.4Qu1HbLqzM@wuerfel \
--to=arnd@arndb.de \
--cc=antoine.tenart@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jszhang@marvell.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lkp@intel.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.