From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Lauri Peltonen <lpeltonen@nvidia.com>,
Ben Skeggs <bskeggs@redhat.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Colin Cross <ccross@android.com>,
Dave Airlie <airlied@redhat.com>
Cc: Stephen Warren <swarren@nvidia.com>,
nouveau@lists.freedesktop.org, James Jones <jajones@nvidia.com>,
dri-devel@lists.freedesktop.org,
Thierry Reding <treding@nvidia.com>,
Ken Adams <kadams@nvidia.com>
Subject: Re: [RFC PATCH 6/7] drm/nouveau: Support marking buffers for explicit sync
Date: Sat, 27 Sep 2014 08:52:20 +0200 [thread overview]
Message-ID: <54265EA4.2010509@canonical.com> (raw)
In-Reply-To: <1411725612-10455-7-git-send-email-lpeltonen@nvidia.com>
Hey,
On 26-09-14 12:00, Lauri Peltonen wrote:
> Do not attach fences automatically to buffers that are marked for
> explicit synchronization.
>
> Signed-off-by: Lauri Peltonen <lpeltonen@nvidia.com>
> ---
> drm/nouveau_bo.c | 8 ++++----
> drm/nouveau_bo.h | 4 ++--
> drm/nouveau_drm.c | 1 +
> drm/nouveau_gem.c | 47 +++++++++++++++++++++++++++++++++++++++-------
> drm/nouveau_gem.h | 6 ++++--
> drm/nouveau_ttm.c | 8 ++++----
> drm/nv50_display.c | 2 +-
> drm/uapi/drm/nouveau_drm.h | 5 ++++-
> 8 files changed, 60 insertions(+), 21 deletions(-)
Considering this will break on eviction, is it really needed?
If a fence is waited on before starting an operation synchronization will be a noop.
~Maarten
next prev parent reply other threads:[~2014-09-27 6:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 10:00 [RFC] Explicit synchronization for Nouveau Lauri Peltonen
2014-09-26 10:00 ` [RFC PATCH 2/7] drm/nouveau: Split nouveau_fence_sync Lauri Peltonen
[not found] ` <1411725612-10455-1-git-send-email-lpeltonen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-09-26 10:00 ` [RFC PATCH 1/7] android: Support creating sync fence from drm fences Lauri Peltonen
2014-09-27 7:00 ` Maarten Lankhorst
2014-09-26 10:00 ` [RFC PATCH 3/7] drm/nouveau: Add fence fd helpers Lauri Peltonen
2014-09-26 10:00 ` [RFC PATCH 7/7] drm/prime: Support explicit fence on export Lauri Peltonen
2014-09-27 6:49 ` Maarten Lankhorst
[not found] ` <1411725612-10455-8-git-send-email-lpeltonen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-09-29 7:46 ` Daniel Vetter
2014-10-01 15:52 ` Lauri Peltonen
2014-09-26 10:00 ` [RFC PATCH 4/7] drm/nouveau: Support fence fd's at kickoff Lauri Peltonen
2014-09-26 10:00 ` [RFC PATCH 5/7] libdrm: nouveau: Support fence fds Lauri Peltonen
2014-09-26 10:00 ` [RFC PATCH 6/7] drm/nouveau: Support marking buffers for explicit sync Lauri Peltonen
2014-09-27 6:52 ` Maarten Lankhorst [this message]
2014-09-29 7:43 ` [RFC] Explicit synchronization for Nouveau Daniel Vetter
2014-09-29 15:42 ` Jerome Glisse
[not found] ` <20140929154217.GA2851-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-29 17:20 ` Daniel Vetter
2014-09-29 17:20 ` James Jones
2014-09-30 8:21 ` Daniel Vetter
2014-10-01 15:14 ` Lauri Peltonen
[not found] ` <20141001151416.GC25206-GyFFdlxoGbnFT5IIyIEb6QC/G2K4zDHf@public.gmane.org>
2014-10-01 15:58 ` Maarten Lankhorst
2014-10-01 17:27 ` Daniel Vetter
[not found] ` <20141001172721.GQ12343-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2014-10-02 14:59 ` Lauri Peltonen
2014-10-02 20:44 ` Daniel Vetter
2014-10-03 21:56 ` Rom Lemarchand
[not found] ` <CAABpnA_r1Vu8pGtxqXO8Ufg5KMhkUy_9RPic-VActaJQyLRm_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-06 12:25 ` Lauri Peltonen
[not found] ` <20141006122540.GA7974-GyFFdlxoGbnFT5IIyIEb6QC/G2K4zDHf@public.gmane.org>
2014-10-08 9:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54265EA4.2010509@canonical.com \
--to=maarten.lankhorst@canonical.com \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=ccross@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jajones@nvidia.com \
--cc=kadams@nvidia.com \
--cc=lpeltonen@nvidia.com \
--cc=nouveau@lists.freedesktop.org \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.