From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c
Date: Sat, 27 Sep 2014 10:39:14 +0200 [thread overview]
Message-ID: <542677B2.70506@samsung.com> (raw)
In-Reply-To: <201409262313.26272.arnd@arndb.de>
W dniu 26.09.2014 o 23:13, Arnd Bergmann pisze:
> On Friday 05 September 2014, Krzysztof Kozlowski wrote:
>> The commit only moves code around with one additional observable change:
>> the hotplug.c was compiled with custom CFLAGS (-march=armv7-a). These
>> CFLAGS are not necessary any more.
>
> This turns out to be wrong, and your change broke 'allmodconfig' builds
> in linux-next. Please apply this patch on top.
My patch definitely needed more testing.
I posted a fix here:
https://lkml.org/lkml/2014/9/24/163
However it seems that it wasn't picked up by anyone yet.
Russell, could you pick up the patch (with acks from Nicolas and Kukjin)?
Best regards,
Krzysztof
>
> Arnd
>
> 8<----------
> From 4ba6bf8806caec386e35930314dbad071284c837 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Fri, 26 Sep 2014 23:09:38 +0200
> Subject: [PATCH] ARM: EXYNOS: fix build error in platsmp.c
>
> /tmp/ccYeWL3V.s: Assembler messages:
> /tmp/ccYeWL3V.s:659: Error: selected processor does not support ARM mode `isb '
> /tmp/ccYeWL3V.s:664: Error: selected processor does not support ARM mode `isb '
> /tmp/ccYeWL3V.s:665: Error: selected processor does not support ARM mode `dsb '
> make[3]: *** [arch/arm/mach-exynos/platsmp.o] Error 1
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 17342534e1d932 ("ARM: EXYNOS: Move code from hotplug.c to platsmp.c")
>
> diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
> index 4e49d4efb264..64324bf5edb4 100644
> --- a/arch/arm/mach-exynos/Makefile
> +++ b/arch/arm/mach-exynos/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_PM_SLEEP) += suspend.o
> obj-$(CONFIG_PM_GENERIC_DOMAINS) += pm_domains.o
>
> obj-$(CONFIG_SMP) += platsmp.o headsmp.o
> +CFLAGS_platsmp.o := -march=armv7-a
>
> plus_sec := $(call as-instr,.arch_extension sec,+sec)
> AFLAGS_exynos-smc.o :=-Wa,-march=armv7-a$(plus_sec)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c
Date: Sat, 27 Sep 2014 10:39:14 +0200 [thread overview]
Message-ID: <542677B2.70506@samsung.com> (raw)
In-Reply-To: <201409262313.26272.arnd@arndb.de>
W dniu 26.09.2014 o 23:13, Arnd Bergmann pisze:
> On Friday 05 September 2014, Krzysztof Kozlowski wrote:
>> The commit only moves code around with one additional observable change:
>> the hotplug.c was compiled with custom CFLAGS (-march=armv7-a). These
>> CFLAGS are not necessary any more.
>
> This turns out to be wrong, and your change broke 'allmodconfig' builds
> in linux-next. Please apply this patch on top.
My patch definitely needed more testing.
I posted a fix here:
https://lkml.org/lkml/2014/9/24/163
However it seems that it wasn't picked up by anyone yet.
Russell, could you pick up the patch (with acks from Nicolas and Kukjin)?
Best regards,
Krzysztof
>
> Arnd
>
> 8<----------
> From 4ba6bf8806caec386e35930314dbad071284c837 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Fri, 26 Sep 2014 23:09:38 +0200
> Subject: [PATCH] ARM: EXYNOS: fix build error in platsmp.c
>
> /tmp/ccYeWL3V.s: Assembler messages:
> /tmp/ccYeWL3V.s:659: Error: selected processor does not support ARM mode `isb '
> /tmp/ccYeWL3V.s:664: Error: selected processor does not support ARM mode `isb '
> /tmp/ccYeWL3V.s:665: Error: selected processor does not support ARM mode `dsb '
> make[3]: *** [arch/arm/mach-exynos/platsmp.o] Error 1
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 17342534e1d932 ("ARM: EXYNOS: Move code from hotplug.c to platsmp.c")
>
> diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
> index 4e49d4efb264..64324bf5edb4 100644
> --- a/arch/arm/mach-exynos/Makefile
> +++ b/arch/arm/mach-exynos/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_PM_SLEEP) += suspend.o
> obj-$(CONFIG_PM_GENERIC_DOMAINS) += pm_domains.o
>
> obj-$(CONFIG_SMP) += platsmp.o headsmp.o
> +CFLAGS_platsmp.o := -march=armv7-a
>
> plus_sec := $(call as-instr,.arch_extension sec,+sec)
> AFLAGS_exynos-smc.o :=-Wa,-march=armv7-a$(plus_sec)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-09-27 8:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 12:34 [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c Krzysztof Kozlowski
2014-09-05 12:34 ` Krzysztof Kozlowski
2014-09-05 12:34 ` [PATCH v5 RESEND 2/3] ARM: EXYNOS: Remove unneeded __ref annotation for cpu_die function Krzysztof Kozlowski
2014-09-05 12:34 ` Krzysztof Kozlowski
2014-09-05 12:34 ` [PATCH v5 RESEND 3/3] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off Krzysztof Kozlowski
2014-09-05 12:34 ` Krzysztof Kozlowski
2014-09-09 3:39 ` [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c kgene
2014-09-09 3:39 ` kgene at kernel.org
2014-09-26 21:13 ` Arnd Bergmann
2014-09-26 21:13 ` Arnd Bergmann
2014-09-27 8:39 ` Krzysztof Kozlowski [this message]
2014-09-27 8:39 ` Krzysztof Kozlowski
2014-09-28 4:42 ` Kukjin Kim
2014-09-28 4:42 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542677B2.70506@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.