From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Janusz Uzycki <j.uzycki@elproma.com.pl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devicetree@vger.kernel.org,
Richard Genoud <richard.genoud@gmail.com>,
Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] serial: mxs-auart: enable PPS support
Date: Sat, 27 Sep 2014 16:47:44 +0400 [thread overview]
Message-ID: <5426B1F0.9050006@cogentembedded.com> (raw)
In-Reply-To: <1411811197-12638-5-git-send-email-j.uzycki@elproma.com.pl>
Hello.
On 9/27/2014 1:46 PM, Janusz Uzycki wrote:
> Enables PPS support in mxs-auart serial driver to make PPS API working.
> Signed-off-by: Janusz Uzycki <j.uzycki@elproma.com.pl>
> ---
> drivers/tty/serial/mxs-auart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index ab127a2..4f1ab98 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -787,6 +787,15 @@ static void mxs_auart_settermios(struct uart_port *u,
> mxs_auart_disable_ms(u);
> }
>
> +static void mxs_auart_set_ldisc(struct uart_port *port, int new)
> +{
> + if (new == N_PPS) {
> + port->flags |= UPF_HARDPPS_CD;
> + mxs_auart_enable_ms(port);
> + } else
> + port->flags &= ~UPF_HARDPPS_CD;
The kernel coding style dictates that {} should be in both arms of the
*if* statement.
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] serial: mxs-auart: enable PPS support
Date: Sat, 27 Sep 2014 16:47:44 +0400 [thread overview]
Message-ID: <5426B1F0.9050006@cogentembedded.com> (raw)
In-Reply-To: <1411811197-12638-5-git-send-email-j.uzycki@elproma.com.pl>
Hello.
On 9/27/2014 1:46 PM, Janusz Uzycki wrote:
> Enables PPS support in mxs-auart serial driver to make PPS API working.
> Signed-off-by: Janusz Uzycki <j.uzycki@elproma.com.pl>
> ---
> drivers/tty/serial/mxs-auart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index ab127a2..4f1ab98 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -787,6 +787,15 @@ static void mxs_auart_settermios(struct uart_port *u,
> mxs_auart_disable_ms(u);
> }
>
> +static void mxs_auart_set_ldisc(struct uart_port *port, int new)
> +{
> + if (new == N_PPS) {
> + port->flags |= UPF_HARDPPS_CD;
> + mxs_auart_enable_ms(port);
> + } else
> + port->flags &= ~UPF_HARDPPS_CD;
The kernel coding style dictates that {} should be in both arms of the
*if* statement.
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-09-27 12:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 9:46 [PATCH v3] serial: mxs-auart: gpios as modem signals (dirty) Janusz Uzycki
2014-09-27 9:46 ` Janusz Uzycki
2014-09-27 9:46 ` [PATCH 1/4] serial: mxs-auart: ctrl removed from mxs_auart_port Janusz Uzycki
2014-09-27 9:46 ` Janusz Uzycki
2014-09-27 10:03 ` Russell King - ARM Linux
2014-09-27 10:03 ` Russell King - ARM Linux
2014-09-27 11:44 ` [PATCH] serial: mxs-auart: clean get_mctrl and set_mctrl Janusz Uzycki
2014-09-27 11:44 ` Janusz Uzycki
2014-09-27 9:46 ` [PATCH 2/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals Janusz Uzycki
2014-09-27 9:46 ` Janusz Uzycki
2014-09-27 10:07 ` Russell King - ARM Linux
2014-09-27 10:07 ` Russell King - ARM Linux
2014-09-27 20:32 ` serial: mxs-auart: gpios as modem signals (dirty) Janusz Uzycki
2014-09-27 20:32 ` Janusz Uzycki
2014-09-27 20:32 ` [PATCH 1/2] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals Janusz Uzycki
2014-09-27 20:32 ` Janusz Uzycki
2014-09-27 20:32 ` [PATCH 2/2] serial: mxs-auart: add interrupts for modem control lines Janusz Uzycki
2014-09-27 20:32 ` Janusz Uzycki
2014-09-27 10:33 ` [PATCH 2/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals Janusz Użycki
2014-09-27 10:33 ` Janusz Użycki
2014-09-27 10:54 ` Russell King - ARM Linux
2014-09-27 10:54 ` Russell King - ARM Linux
2014-09-27 11:15 ` Janusz Użycki
2014-09-27 11:15 ` Janusz Użycki
2014-09-27 12:18 ` Russell King - ARM Linux
2014-09-27 12:18 ` Russell King - ARM Linux
2014-09-27 9:46 ` [PATCH 3/4] serial: mxs-auart: add interrupts for modem control lines Janusz Uzycki
2014-09-27 9:46 ` Janusz Uzycki
2014-10-24 15:32 ` Richard Genoud
2014-10-24 15:32 ` Richard Genoud
2014-10-24 15:36 ` Janusz Użycki
2014-10-24 15:36 ` Janusz Użycki
2014-09-27 9:46 ` [PATCH 4/4] serial: mxs-auart: enable PPS support Janusz Uzycki
2014-09-27 9:46 ` Janusz Uzycki
2014-09-27 12:47 ` Sergei Shtylyov [this message]
2014-09-27 12:47 ` Sergei Shtylyov
2014-09-27 13:36 ` [PATCH] " Janusz Uzycki
2014-09-27 13:36 ` Janusz Uzycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5426B1F0.9050006@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j.uzycki@elproma.com.pl \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.