From: Tomasz Figa <tomasz.figa@gmail.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: kgene.kim@samsung.com, s.nawrocki@samsung.com,
mturquette@linaro.org, naushad@samsung.com
Subject: Re: [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c
Date: Sat, 27 Sep 2014 15:20:59 +0200 [thread overview]
Message-ID: <5426B9BB.90606@gmail.com> (raw)
In-Reply-To: <1411796519-19417-3-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
On 27.09.2014 07:41, Pankaj Dubey wrote:
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Missing patch description.
> ---
> drivers/clk/samsung/clk.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
> index deab84d..31bf391 100644
> --- a/drivers/clk/samsung/clk.c
> +++ b/drivers/clk/samsung/clk.c
> @@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct samsung_clk_provider *ctx,
> * obtain the clock speed of all external fixed clock sources from device
> * tree and register it
> */
> -#ifdef CONFIG_OF
We still have non-DT platforms which use this code, i.e. s3c24xx and
s3c64xx. Have you checked if this compiles fine on them with CONFIG_OF
disabled?
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c
Date: Sat, 27 Sep 2014 15:20:59 +0200 [thread overview]
Message-ID: <5426B9BB.90606@gmail.com> (raw)
In-Reply-To: <1411796519-19417-3-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
On 27.09.2014 07:41, Pankaj Dubey wrote:
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Missing patch description.
> ---
> drivers/clk/samsung/clk.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
> index deab84d..31bf391 100644
> --- a/drivers/clk/samsung/clk.c
> +++ b/drivers/clk/samsung/clk.c
> @@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct samsung_clk_provider *ctx,
> * obtain the clock speed of all external fixed clock sources from device
> * tree and register it
> */
> -#ifdef CONFIG_OF
We still have non-DT platforms which use this code, i.e. s3c24xx and
s3c64xx. Have you checked if this compiles fine on them with CONFIG_OF
disabled?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-09-27 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 5:41 [PATCH 0/3] Some cleanup for samsung clock Pankaj Dubey
2014-09-27 5:41 ` Pankaj Dubey
2014-09-27 5:41 ` [PATCH 1/3] clk: samsung: Spelling s/bwtween/between/ Pankaj Dubey
2014-09-27 5:41 ` Pankaj Dubey
2014-09-27 12:56 ` Tomasz Figa
2014-09-27 12:56 ` Tomasz Figa
2014-09-27 5:41 ` [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c Pankaj Dubey
2014-09-27 5:41 ` Pankaj Dubey
2014-09-27 13:20 ` Tomasz Figa [this message]
2014-09-27 13:20 ` Tomasz Figa
2014-09-29 7:30 ` Pankaj Dubey
2014-09-29 7:30 ` Pankaj Dubey
2014-09-27 5:41 ` [PATCH 3/3] clk: samsung: remove unnecessary inclusion of header files from clk.h Pankaj Dubey
2014-09-27 5:41 ` Pankaj Dubey
2014-12-02 15:23 ` Sylwester Nawrocki
2014-12-02 15:23 ` Sylwester Nawrocki
2014-12-03 11:42 ` Pankaj Dubey
2014-12-03 11:42 ` Pankaj Dubey
2014-12-03 12:04 ` Sylwester Nawrocki
2014-12-03 12:04 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5426B9BB.90606@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=naushad@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.