From: Behan Webster <behanw@converseincode.com>
To: balbi@ti.com
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
daniel.vetter@ffwll.ch, geert@linux-m68k.org,
laurent.pinchart@ideasonboard.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
robdclark@gmail.com, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omap2 dss
Date: Sat, 27 Sep 2014 22:53:56 +0000 [thread overview]
Message-ID: <54274004.6010902@converseincode.com> (raw)
In-Reply-To: <20140927164554.GA7076@saruman>
On 09/27/14 09:46, Felipe Balbi wrote:
> On Fri, Sep 26, 2014 at 06:10:52PM -0700, Behan Webster wrote:
>> Replace the use of nested functions where a normal function will suffice.
>>
>> Nested functions are not liked by upstream kernel developers in general. Their
>> use breaks the use of clang as a compiler, and doesn't make the code any
>> better.
>>
>> This code now works for both gcc and clang.
>>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Arnd Bergmann <arnd@arndb.de>
> another one that make sense :-) And probably also deserves
> checkpatch/coccinelle/sparse.
Indeed! That would be very appreciated.
The clang static analyzer already points this one out. :)
Behan
--
Behan Webster
behanw@converseincode.com
WARNING: multiple messages have this Message-ID (diff)
From: Behan Webster <behanw@converseincode.com>
To: balbi@ti.com
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
daniel.vetter@ffwll.ch, geert@linux-m68k.org,
laurent.pinchart@ideasonboard.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
robdclark@gmail.com, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omap2 dss
Date: Sat, 27 Sep 2014 15:53:56 -0700 [thread overview]
Message-ID: <54274004.6010902@converseincode.com> (raw)
In-Reply-To: <20140927164554.GA7076@saruman>
On 09/27/14 09:46, Felipe Balbi wrote:
> On Fri, Sep 26, 2014 at 06:10:52PM -0700, Behan Webster wrote:
>> Replace the use of nested functions where a normal function will suffice.
>>
>> Nested functions are not liked by upstream kernel developers in general. Their
>> use breaks the use of clang as a compiler, and doesn't make the code any
>> better.
>>
>> This code now works for both gcc and clang.
>>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Arnd Bergmann <arnd@arndb.de>
> another one that make sense :-) And probably also deserves
> checkpatch/coccinelle/sparse.
Indeed! That would be very appreciated.
The clang static analyzer already points this one out. :)
Behan
--
Behan Webster
behanw@converseincode.com
next prev parent reply other threads:[~2014-09-27 22:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 1:10 [PATCH 0/2] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM Behan Webster
2014-09-27 1:10 ` Behan Webster
2014-09-27 1:10 ` [PATCH 1/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omap2 dss Behan Webster
2014-09-27 1:10 ` Behan Webster
2014-09-27 16:46 ` Felipe Balbi
2014-09-27 16:46 ` Felipe Balbi
2014-09-27 16:46 ` Felipe Balbi
2014-09-27 22:53 ` Behan Webster [this message]
2014-09-27 22:53 ` Behan Webster
2014-09-27 1:10 ` [PATCH 2/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omapfb Behan Webster
2014-09-27 1:10 ` Behan Webster
2014-09-27 16:46 ` Felipe Balbi
2014-09-27 16:46 ` Felipe Balbi
2014-09-27 16:46 ` Felipe Balbi
2014-09-30 10:15 ` [PATCH 0/2] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM Tomi Valkeinen
2014-09-30 10:15 ` Tomi Valkeinen
2014-09-30 10:15 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54274004.6010902@converseincode.com \
--to=behanw@converseincode.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=daniel.vetter@ffwll.ch \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.