All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Tanya Brokhman <tlinder@codeaurora.org>, dedeking1@gmail.com
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	linux-arm-msm@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC/PATCH 1/5] mtd: ubi: Read disturb infrastructure
Date: Sun, 28 Sep 2014 10:54:48 +0200	[thread overview]
Message-ID: <5427CCD8.2090605@nod.at> (raw)
In-Reply-To: <5427CB6E.7010007@codeaurora.org>

Am 28.09.2014 10:48, schrieb Tanya Brokhman:
>>> @@ -424,6 +440,8 @@ struct ubi_fm_sb {
>>>       __be32 used_blocks;
>>>       __be32 block_loc[UBI_FM_MAX_BLOCKS];
>>>       __be32 block_ec[UBI_FM_MAX_BLOCKS];
>>> +    __be32 block_rc[UBI_FM_MAX_BLOCKS];
>>> +    __be64 block_let[UBI_FM_MAX_BLOCKS];
>>
>> Doesn't this break the fastmap on-disk layout?
> 
> What do you mean "break"? I verified fastmap feature is working. the whole read-disturb depends on it so I tested this thoroughly.

Did you write a fastmap with your changes applied and then an attach using a fastmap implementation *without*
you changes?
I bet it will not work because the disk layout is now different.
Linux is not the only user of fastmap. We need to be very careful here.

Thanks,
//richard

  reply	other threads:[~2014-09-28  8:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28  6:37 [RFC/PATCH 1/5] mtd: ubi: Read disturb infrastructure Tanya Brokhman
2014-09-28  6:37 ` Tanya Brokhman
2014-09-28  6:37 ` Tanya Brokhman
2014-09-28  8:18 ` Richard Weinberger
2014-09-28  8:18   ` Richard Weinberger
2014-09-28  8:48   ` Tanya Brokhman
2014-09-28  8:54     ` Richard Weinberger [this message]
2014-09-28 10:46       ` Tanya Brokhman
2014-09-28 10:54         ` Richard Weinberger
2014-10-02 12:50           ` Tanya Brokhman
2014-10-02 13:24             ` Richard Weinberger
2014-10-02 13:42               ` Tanya Brokhman
2014-10-02 14:05                 ` Richard Weinberger
2014-10-03 15:38                   ` Artem Bityutskiy
2014-10-03 15:38                     ` Artem Bityutskiy
2014-10-07 13:55                 ` Richard Weinberger
2014-10-02 13:36             ` Richard Weinberger
2014-10-02 14:11               ` Tanya Brokhman
2014-09-28 12:11 ` Artem Bityutskiy
2014-09-28 12:11   ` Artem Bityutskiy
2014-09-28 14:54   ` Tanya Brokhman
2014-09-28 18:13 ` Jeremiah Mahler
2014-09-29  4:46   ` Tanya Brokhman
2014-09-29  6:49     ` Jeremiah Mahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5427CCD8.2090605@nod.at \
    --to=richard@nod.at \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dedeking1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tlinder@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.