From: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH 1/2] DT: add binding for mxs regulator
Date: Mon, 29 Sep 2014 08:00:50 +0200 [thread overview]
Message-ID: <5428F592.3020809@i2se.com> (raw)
In-Reply-To: <20140928102202.GM27755-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Hi Mark,
Am 28.09.2014 um 12:22 schrieb Mark Brown:
> On Sat, Sep 27, 2014 at 12:59:47AM +0000, Stefan Wahren wrote:
>> This patch adds the Device tree bindings for the Freescale MXS
>> on-chip regulators.
> Use subject lines matching the style for the subsystem.
sorry i'm not sure what's wrong with the subject lines.
Did you expect "[PATCH 1/2] regulator: add binding for mxs regulator"?
>
>> +Required regulator properties:
>> +- compatible: Must be "fsl,mxs-regulator"
>> +- reg: Absolute physical address of the register set for the regulator
>> +
>> +Any regulator property defined as part of the core regulator
>> +binding, defined in regulator.txt, can also be used.
> While this should be using compatibles to identify which regulator is
> being supported note that the binding doesn't document the fact that the
> code makes regulator-name mandatory or what values are required.
Is the following better?
- fsl,mxs-regulator-vddd
- fsl,mxs-regulator-vdda
- fsl,mxs-regulator-vddio
Thanks
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, shawn.guo@linaro.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
festevam@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] DT: add binding for mxs regulator
Date: Mon, 29 Sep 2014 08:00:50 +0200 [thread overview]
Message-ID: <5428F592.3020809@i2se.com> (raw)
In-Reply-To: <20140928102202.GM27755@sirena.org.uk>
Hi Mark,
Am 28.09.2014 um 12:22 schrieb Mark Brown:
> On Sat, Sep 27, 2014 at 12:59:47AM +0000, Stefan Wahren wrote:
>> This patch adds the Device tree bindings for the Freescale MXS
>> on-chip regulators.
> Use subject lines matching the style for the subsystem.
sorry i'm not sure what's wrong with the subject lines.
Did you expect "[PATCH 1/2] regulator: add binding for mxs regulator"?
>
>> +Required regulator properties:
>> +- compatible: Must be "fsl,mxs-regulator"
>> +- reg: Absolute physical address of the register set for the regulator
>> +
>> +Any regulator property defined as part of the core regulator
>> +binding, defined in regulator.txt, can also be used.
> While this should be using compatibles to identify which regulator is
> being supported note that the binding doesn't document the fact that the
> code makes regulator-name mandatory or what values are required.
Is the following better?
- fsl,mxs-regulator-vddd
- fsl,mxs-regulator-vdda
- fsl,mxs-regulator-vddio
Thanks
Stefan
next prev parent reply other threads:[~2014-09-29 6:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 0:59 [PATCH 0/2] regulator: add support for mxs regulator Stefan Wahren
2014-09-27 0:59 ` [PATCH 1/2] DT: add binding " Stefan Wahren
[not found] ` <1411779588-22031-2-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2014-09-28 10:22 ` Mark Brown
2014-09-28 10:22 ` Mark Brown
[not found] ` <20140928102202.GM27755-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-29 6:00 ` Stefan Wahren [this message]
2014-09-29 6:00 ` Stefan Wahren
[not found] ` <5428F592.3020809-eS4NqCHxEME@public.gmane.org>
2014-09-29 10:23 ` Mark Brown
2014-09-29 10:23 ` Mark Brown
2014-09-29 11:09 ` Mark Rutland
2014-09-29 11:09 ` Mark Rutland
2014-09-29 11:53 ` Stefan Wahren
2014-09-29 11:53 ` Stefan Wahren
[not found] ` <54294832.8000702-eS4NqCHxEME@public.gmane.org>
2014-09-29 12:41 ` Mark Rutland
2014-09-29 12:41 ` Mark Rutland
2014-09-29 13:10 ` Stefan Wahren
2014-09-29 13:10 ` Stefan Wahren
2014-09-29 13:23 ` Mark Rutland
2014-10-03 11:46 ` Stefan Wahren
2014-10-03 11:46 ` Stefan Wahren
2014-09-27 0:59 ` [PATCH 2/2] regulator: add mxs regulator driver Stefan Wahren
2014-09-28 10:16 ` Mark Brown
2014-09-29 6:38 ` Stefan Wahren
[not found] ` <5428FE7B.8060700-eS4NqCHxEME@public.gmane.org>
2014-09-29 17:13 ` Mark Brown
2014-09-29 17:13 ` Mark Brown
[not found] ` <20140929171314.GW16977-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-30 6:40 ` Stefan Wahren
2014-09-30 6:40 ` Stefan Wahren
2014-10-01 13:23 ` Stefan Wahren
2014-10-01 13:23 ` Stefan Wahren
2014-10-01 15:57 ` Mark Brown
2014-10-02 16:18 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5428F592.3020809@i2se.com \
--to=stefan.wahren-es4nqchxeme@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.