All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zefan Li <lizefan@huawei.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH 0/4] Simplify cpuset API and fix cpuset check in SL[AU]B
Date: Mon, 29 Sep 2014 15:25:22 +0800	[thread overview]
Message-ID: <54290962.8010603@huawei.com> (raw)
In-Reply-To: <cover.1411741632.git.vdavydov@parallels.com>

On 2014/9/26 22:50, Vladimir Davydov wrote:
> Hi,
> 
> SLAB and SLUB use hardwall cpuset check on fallback alloc, while the
> page allocator uses softwall check for all kernel allocations. This may
> result in falling into the page allocator even if there are free objects
> on other nodes. SLAB algorithm is especially affected: the number of
> objects allocated in vain is unlimited, so that they theoretically can
> eat up a whole NUMA node. For more details see comments to patches 3, 4.
> 
> When I last sent a fix (https://lkml.org/lkml/2014/8/10/100), David
> found the whole cpuset API being cumbersome and proposed to simplify it
> before getting to fixing its users. So this patch set addresses both
> David's complain (patches 1, 2) and the SL[AU]B issues (patches 3, 4).
> 
> Reviews are appreciated.
> 
> Thanks,
> 
> Vladimir Davydov (4):
>   cpuset: convert callback_mutex to a spinlock
>   cpuset: simplify cpuset_node_allowed API
>   slab: fix cpuset check in fallback_alloc
>   slub: fix cpuset check in get_any_partial
> 

Acked-by: Zefan Li <lizefan@huawei.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan@huawei.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: <linux-kernel@vger.kernel.org>, Christoph Lameter <cl@linux.com>,
	"Pekka Enberg" <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 0/4] Simplify cpuset API and fix cpuset check in SL[AU]B
Date: Mon, 29 Sep 2014 15:25:22 +0800	[thread overview]
Message-ID: <54290962.8010603@huawei.com> (raw)
In-Reply-To: <cover.1411741632.git.vdavydov@parallels.com>

On 2014/9/26 22:50, Vladimir Davydov wrote:
> Hi,
> 
> SLAB and SLUB use hardwall cpuset check on fallback alloc, while the
> page allocator uses softwall check for all kernel allocations. This may
> result in falling into the page allocator even if there are free objects
> on other nodes. SLAB algorithm is especially affected: the number of
> objects allocated in vain is unlimited, so that they theoretically can
> eat up a whole NUMA node. For more details see comments to patches 3, 4.
> 
> When I last sent a fix (https://lkml.org/lkml/2014/8/10/100), David
> found the whole cpuset API being cumbersome and proposed to simplify it
> before getting to fixing its users. So this patch set addresses both
> David's complain (patches 1, 2) and the SL[AU]B issues (patches 3, 4).
> 
> Reviews are appreciated.
> 
> Thanks,
> 
> Vladimir Davydov (4):
>   cpuset: convert callback_mutex to a spinlock
>   cpuset: simplify cpuset_node_allowed API
>   slab: fix cpuset check in fallback_alloc
>   slub: fix cpuset check in get_any_partial
> 

Acked-by: Zefan Li <lizefan@huawei.com>


  parent reply	other threads:[~2014-09-29  7:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 14:50 [PATCH 0/4] Simplify cpuset API and fix cpuset check in SL[AU]B Vladimir Davydov
2014-09-26 14:50 ` Vladimir Davydov
2014-09-26 14:50 ` [PATCH 1/4] cpuset: convert callback_mutex to a spinlock Vladimir Davydov
2014-09-26 14:50   ` Vladimir Davydov
2014-09-26 15:44   ` Christoph Lameter
2014-09-26 15:44     ` Christoph Lameter
2014-09-26 14:50 ` [PATCH 2/4] cpuset: simplify cpuset_node_allowed API Vladimir Davydov
2014-09-26 14:50   ` Vladimir Davydov
2014-09-26 15:53   ` Christoph Lameter
2014-09-26 15:53     ` Christoph Lameter
2014-09-26 14:50 ` [PATCH 3/4] slab: fix cpuset check in fallback_alloc Vladimir Davydov
2014-09-26 14:50   ` Vladimir Davydov
2014-09-26 16:31   ` Christoph Lameter
2014-09-26 16:31     ` Christoph Lameter
2014-09-27  8:12     ` Vladimir Davydov
2014-09-27  8:12       ` Vladimir Davydov
2014-09-26 14:50 ` [PATCH 4/4] slub: fix cpuset check in get_any_partial Vladimir Davydov
2014-09-26 14:50   ` Vladimir Davydov
2014-09-29  7:25 ` Zefan Li [this message]
2014-09-29  7:25   ` [PATCH 0/4] Simplify cpuset API and fix cpuset check in SL[AU]B Zefan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54290962.8010603@huawei.com \
    --to=lizefan@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.