From: Varka Bhadram <varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Anders Berg <anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx
Date: Mon, 29 Sep 2014 15:43:16 +0530 [thread overview]
Message-ID: <542930BC.4040806@gmail.com> (raw)
In-Reply-To: <20140929101319.GB1559@katana>
On 09/29/2014 03:43 PM, Wolfram Sang wrote:
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> Error checking on *res*...?
>>
>> We should *return* on platform_get_resource() failure..
>>
>>> + base = devm_ioremap_resource(&pdev->dev, res);
> Nope. devm_ioremap_resource does that.
>
Yes it will [1]. Thanks for the clarification.
[1]:http://lxr.free-electrons.com/source/lib/devres.c#L117
--
Regards,
Varka Bhadram.
WARNING: multiple messages have this Message-ID (diff)
From: varkabhadram@gmail.com (Varka Bhadram)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx
Date: Mon, 29 Sep 2014 15:43:16 +0530 [thread overview]
Message-ID: <542930BC.4040806@gmail.com> (raw)
In-Reply-To: <20140929101319.GB1559@katana>
On 09/29/2014 03:43 PM, Wolfram Sang wrote:
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> Error checking on *res*...?
>>
>> We should *return* on platform_get_resource() failure..
>>
>>> + base = devm_ioremap_resource(&pdev->dev, res);
> Nope. devm_ioremap_resource does that.
>
Yes it will [1]. Thanks for the clarification.
[1]:http://lxr.free-electrons.com/source/lib/devres.c#L117
--
Regards,
Varka Bhadram.
WARNING: multiple messages have this Message-ID (diff)
From: Varka Bhadram <varkabhadram@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Anders Berg <anders.berg@avagotech.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx
Date: Mon, 29 Sep 2014 15:43:16 +0530 [thread overview]
Message-ID: <542930BC.4040806@gmail.com> (raw)
In-Reply-To: <20140929101319.GB1559@katana>
On 09/29/2014 03:43 PM, Wolfram Sang wrote:
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> Error checking on *res*...?
>>
>> We should *return* on platform_get_resource() failure..
>>
>>> + base = devm_ioremap_resource(&pdev->dev, res);
> Nope. devm_ioremap_resource does that.
>
Yes it will [1]. Thanks for the clarification.
[1]:http://lxr.free-electrons.com/source/lib/devres.c#L117
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-09-29 10:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 9:32 [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx Anders Berg
2014-09-29 9:32 ` Anders Berg
[not found] ` <1411983159-4692-1-git-send-email-anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
2014-09-29 10:07 ` Varka Bhadram
2014-09-29 10:07 ` Varka Bhadram
2014-09-29 10:07 ` Varka Bhadram
[not found] ` <54292F74.2030209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-29 10:13 ` Wolfram Sang
2014-09-29 10:13 ` Wolfram Sang
2014-09-29 10:13 ` Wolfram Sang
2014-09-29 10:13 ` Varka Bhadram [this message]
2014-09-29 10:13 ` Varka Bhadram
2014-09-29 10:13 ` Varka Bhadram
2014-09-29 11:13 ` Anders Berg
2014-09-29 11:13 ` Anders Berg
2014-09-29 11:13 ` Anders Berg
[not found] ` <CAE0=X_0guSvMqZxHvdS39Zxx4G7qVvnddv96t72rp4FwpJLgfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-29 11:14 ` Varka Bhadram
2014-09-29 11:14 ` Varka Bhadram
2014-09-29 11:14 ` Varka Bhadram
[not found] ` <54293F2C.2090206-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-29 12:51 ` Wolfram Sang
2014-09-29 12:51 ` Wolfram Sang
2014-09-29 12:51 ` Wolfram Sang
2014-10-03 10:36 ` Wolfram Sang
2014-10-03 10:36 ` Wolfram Sang
2014-10-03 10:36 ` Wolfram Sang
2014-10-03 11:04 ` Anders Berg
2014-10-03 11:04 ` Anders Berg
2014-10-03 11:04 ` Anders Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542930BC.4040806@gmail.com \
--to=varkabhadram-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.